From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37DC0A09F6 for ; Thu, 17 Dec 2020 16:57:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 096C3CA2A; Thu, 17 Dec 2020 16:57:41 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by dpdk.org (Postfix) with ESMTP id 0CCA3CA2A for ; Thu, 17 Dec 2020 16:57:40 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id d13so8842358wrc.13 for ; Thu, 17 Dec 2020 07:57:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=A23FpTx5l+LKteSRt+99N4lZTH/zPIIlwyPYQD0csnw=; b=QXMOWeasK8fkrHmJY6RR6oz+4wXfPlO0NPBbIdqCzjneX/89phhVIOD1j2A6mS0DML jahhoDRVhXNmDdpfQQ6rFQRMCoIQJxQi6R/mSYZktZQzfyTp9mA5+v1yXImz41oRfX05 riiDNkkDpgZN6Hfz7swnFu9elWQntbuj0F/x7uaOTfQpsRPjEUbxyG8xmgahnoGmTODg ysmBv0VjDDQPOJg+tVLPgYq23unBbCwqO2m81DDPK3SBUfbH3rBNtPpWcf1bRGFLnZwW sxy4DM/V3eFhbPXQ1eFJmyqVELX6lLULoOCOW5OkwA1cQIeSZoHQm4RNRldEhW7ontOi 32PA== X-Gm-Message-State: AOAM533MbIXmYoiqODkiw8EiJeSLiFy3l4OCXPg5FdAPN/L9h4AgB+hU OaEspF4BrNSV8xNzXVhzqPE= X-Google-Smtp-Source: ABdhPJwVVUItIdWOeFL52/QodOH8uC+1ltdnykvDN2P7k3qJUEvFxwEjvZ4C4BMNMKtE3IVhIEcFKw== X-Received: by 2002:adf:f10f:: with SMTP id r15mr39649129wro.302.1608220658412; Thu, 17 Dec 2020 07:57:38 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id k6sm8508634wmf.25.2020.12.17.07.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Dec 2020 07:57:37 -0800 (PST) Message-ID: <9da466c5a8155ce123e983ab07a25fa866873f15.camel@debian.org> From: Luca Boccassi To: dapengx.yu@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com Cc: stable@dpdk.org Date: Thu, 17 Dec 2020 15:57:36 +0000 In-Reply-To: <20201217103608.234579-1-dapengx.yu@intel.com> References: <20201217103608.234579-1-dapengx.yu@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/iavf: enable port reset X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, 2020-12-17 at 18:36 +0800, dapengx.yu@intel.com wrote: > From: YU DAPENG >=20 > This patch is intended to add iavf_dev_reset ops, enable iavf to > support "port reset". And also make iavf_dev_close be called to > clean port resources. >=20 > Signed-off-by: YU DAPENG > --- > drivers/net/iavf/iavf_ethdev.c | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index 3291d18a2d..042dd93641 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -37,6 +37,7 @@ static int iavf_dev_configure(struct rte_eth_dev *dev); > static int iavf_dev_start(struct rte_eth_dev *dev); > static void iavf_dev_stop(struct rte_eth_dev *dev); > static void iavf_dev_close(struct rte_eth_dev *dev); > +static int iavf_dev_reset(struct rte_eth_dev *dev); > static int iavf_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info); > static const uint32_t *iavf_dev_supported_ptypes_get(struct rte_eth_dev = *dev); > @@ -99,6 +100,7 @@ static const struct eth_dev_ops iavf_eth_dev_ops =3D { > .dev_start =3D iavf_dev_start, > .dev_stop =3D iavf_dev_stop, > .dev_close =3D iavf_dev_close, > + .dev_reset =3D iavf_dev_reset, > .dev_infos_get =3D iavf_dev_info_get, > .dev_supported_ptypes_get =3D iavf_dev_supported_ptypes_get, > .link_update =3D iavf_dev_link_update, > @@ -1438,7 +1440,6 @@ static int > iavf_dev_uninit(struct rte_eth_dev *dev) > { > struct iavf_info *vf =3D IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private)= ; > - struct iavf_hw *hw =3D IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private); > =20 > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > return -EPERM; > @@ -1446,8 +1447,7 @@ iavf_dev_uninit(struct rte_eth_dev *dev) > dev->dev_ops =3D NULL; > dev->rx_pkt_burst =3D NULL; > dev->tx_pkt_burst =3D NULL; > - if (hw->adapter_stopped =3D=3D 0) > - iavf_dev_close(dev); > + iavf_dev_close(dev); > =20 > rte_free(vf->vf_res); > vf->vsi_res =3D NULL; > @@ -1470,6 +1470,21 @@ iavf_dev_uninit(struct rte_eth_dev *dev) > return 0; > } > =20 > +/* > + * Reset VF device only to re-initialize resources in PMD layer > + */ > +static int > +iavf_dev_reset(struct rte_eth_dev *dev) > +{ > + int ret; > + > + ret =3D iavf_dev_uninit(dev); > + if (ret) > + return ret; > + > + return iavf_dev_init(dev); > +} > + > static int eth_iavf_pci_probe(struct rte_pci_driver *pci_drv __rte_unuse= d, > struct rte_pci_device *pci_dev) > { Thank you, applied. Has this been validated by the QA team, and confirmed the test case now passes? --=20 Kind regards, Luca Boccassi