From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E173FA04DD for ; Thu, 19 Nov 2020 10:34:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E39C358C4; Thu, 19 Nov 2020 10:34:21 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id ACBED3B5; Thu, 19 Nov 2020 10:34:17 +0100 (CET) IronPort-SDR: f92xlW/Z4UmEYJYvgVVrKcqo87RkvdG4sy9b63fzlBmmGDok0BdZ6l9+sg0zM3sAs0+pY5+07K c8mBuxhmP1cA== X-IronPort-AV: E=McAfee;i="6000,8403,9809"; a="171358935" X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="171358935" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 01:34:15 -0800 IronPort-SDR: 43YGMU4KAJpKnrL4e5wiBpeg93gSBAEsUyoeILHf1mK+w+G4bi5M1rX9v5GLv/vUp2pS8H/qGw TPlM0CqN6j8w== X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="359900270" Received: from endaor2x-mobl.ger.corp.intel.com (HELO [10.213.211.127]) ([10.213.211.127]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 01:34:13 -0800 To: David Marchand , Maryam Tahhan Cc: Reshma Pattan , Roman Korynkevych , Harry van Haaren , dev , dpdk stable References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> <20201118114525.99053-2-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <9e442b10-02ad-dd90-4d31-301dcc9f90fa@intel.com> Date: Thu, 19 Nov 2020 09:34:10 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/7] app/procinfo: fix redundant condition X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 11/18/2020 2:10 PM, David Marchand wrote: > On Wed, Nov 18, 2020 at 12:46 PM Ferruh Yigit wrote: >> >> '_filters' is compared twice, second one will be always false, removing >> it using the message more relevant to the '_filters'. >> >> Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ferruh Yigit >> --- >> app/proc-info/main.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/app/proc-info/main.c b/app/proc-info/main.c >> index d743209f0d..35e5b596eb 100644 >> --- a/app/proc-info/main.c >> +++ b/app/proc-info/main.c >> @@ -420,11 +420,9 @@ static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len, >> } else if ((type_end != NULL) && >> (strncmp(cnt_name, "flow_", strlen("flow_"))) == 0) { >> if (strncmp(type_end, "_filters", strlen("_filters")) == 0) >> - strlcpy(cnt_type, "operations", cnt_type_len); >> + strlcpy(cnt_type, "filter_result", cnt_type_len); > > Do you know what impact this change of type could have? > Since the default behavior is changing it has potential to impact it's users but I don't know. "_filters" stat was searched twice and type were set "operations" & "filter_result" respectively, I unified it to one and selected "filter_result" which seems more relevant.