From: Yunjian Wang <wangyunjian@huawei.com> This patch removes logically dead code reported by coverity. Coverity issue: 360824 Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> --- drivers/net/bnxt/bnxt_reps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c index 6fa9a30d2..e924025cf 100644 --- a/drivers/net/bnxt/bnxt_reps.c +++ b/drivers/net/bnxt/bnxt_reps.c @@ -44,8 +44,6 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf) uint8_t que; vfr_eth_dev = &rte_eth_devices[port_id]; - if (!vfr_eth_dev) - return 1; vfr_bp = vfr_eth_dev->data->dev_private; /* If rxq_id happens to be > max rep_queue, use rxq0 */ que = queue_id < BNXT_MAX_VF_REP_RINGS ? queue_id : 0; -- 2.18.1
From: Yunjian Wang <wangyunjian@huawei.com> We should use rte_pktmbuf_free() instead of rte_free() to free the mbuf. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> --- drivers/net/bnxt/bnxt_reps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c index e924025cf..26bd0f626 100644 --- a/drivers/net/bnxt/bnxt_reps.c +++ b/drivers/net/bnxt/bnxt_reps.c @@ -61,7 +61,7 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf) } else { vfr_bp->rx_drop_bytes[que] += mbuf->pkt_len; vfr_bp->rx_drop_pkts[que]++; - rte_free(mbuf); /* Representor Rx ring full, drop pkt */ + rte_pktmbuf_free(mbuf); /* Representor Rx ring full, drop pkt */ } return 0; -- 2.18.1