Re: [dpdk-stable] [PATCH] net/i40e: add warning info when no perfect RSS key

["Zhao1, Wei" <wei.zhao1@intel.com>]

Thank you!

> -----Original Message-----
> From: Peng, Yuan
> Sent: Wednesday, March 20, 2019 5:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/i40e: add warning info when no perfect RSS key
> 
> Tested-by: Peng Yuan <yuan.peng@intel.com>
> 
> - Tested Branch: master
> - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c
> - OS: 4.13.9-300.fc27.x86_64
> - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
> - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
> - NIC: Intel Corporation Device Fortville [8086:1583]
> - Default x86_64-native-linuxapp-gcc configuration
> - Prerequisites:
> - Total 1 case1, 1 passed, 0 failed
> 
> - Case steps:
> 1. Bind the pf port to dpdk driver:
> ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 2. start testpmd:
> ./x86_64-native-linuxapp-gcc/app/testpmd --log-level=*:8 -c 1ffff -n 4 - -i --
> nb-cores=8 --rxq=4 --txq=4 --port-topology=chained
> 
> 3. set an invalid RSS-key
>  testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end
> key 67108863 / end
>  i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured
>  i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so use
> default configuration
> 
> Flow rule #0 created
>  there is a device warning reported.
> 
> 
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, March 20, 2019 11:31 AM
> To: dev@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; stable@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: add warning info when no perfect RSS key
> 
> There need a warning info when no perfect RSS key is config, so i40e will use
> default key.
> 
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index dca61f0..9235b08 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
>  		rss_conf.rss_key = (uint8_t *)rss_key_default;
>  		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
>  							sizeof(uint32_t);
> +		PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config
> for i40e, so
> +use default configuration\n");
>  	}
> 
>  	i40e_hw_rss_hash_set(pf, &rss_conf);
> --
> 2.7.5