From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id D1B13A00E6
for <public@inbox.dpdk.org>; Mon, 13 May 2019 05:30:47 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 90B304C95;
Mon, 13 May 2019 05:30:47 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id DE1D7239;
Mon, 13 May 2019 05:30:43 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
12 May 2019 20:30:42 -0700
X-ExtLoop1: 1
Received: from kmsmsx157.gar.corp.intel.com ([172.21.138.134])
by orsmga003.jf.intel.com with ESMTP; 12 May 2019 20:30:41 -0700
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.111]) by
kmsmsx157.gar.corp.intel.com ([169.254.5.17]) with mapi id 14.03.0415.000;
Mon, 13 May 2019 11:30:40 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
CC: "stable@dpdk.org" <stable@dpdk.org>, "Peng, Yuan" <yuan.peng@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>, "Lu, Wenzhuo"
<wenzhuo.lu@intel.com>
Thread-Topic: [PATCH v2] app/testpmd: remove port stop check for macsec
Thread-Index: AQHVBxA8HvJnX9dvYk2zWJjh3oYG3qZoakmA
Date: Mon, 13 May 2019 03:30:39 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07EE5CFD@PGSMSX103.gar.corp.intel.com>
References: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com>
<1557477677-54876-1-git-send-email-wei.zhao1@intel.com>
In-Reply-To: <1557477677-54876-1-git-send-email-wei.zhao1@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [172.30.20.206]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-stable] [PATCH v2] app/testpmd: remove port stop check
for macsec
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Tested-by: Peng Yuan <yuan.peng@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, May 10, 2019 4:41 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v2] app/testpmd: remove port stop check for macsec
>=20
> There is no need to do such a check when set macsec for ixgbe,
> reconfig_device_queueand is also useless. If we do not delete this unness=
ary
> code, users have to sotp port before enable or disable macsec, then resta=
rt this
> port after make configuration. All these process is useless. As this cmdl=
ine is a
> private API which is only used by ixgbe NIC, so remove it.
>=20
> Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>=20
> ---
>=20
> v2:
> -update log info and delete code in disable function
> ---
> app/test-pmd/cmdline.c | 10 ----------
> 1 file changed, 10 deletions(-)
>=20
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> c1042dd..dd0f698 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
>=20
> if (port_id_is_invalid(port_id, ENABLED_WARN))
> return;
> - if (!port_is_stopped(port_id)) {
> - printf("Please stop port %d first\n", port_id);
> - return;
> - }
>=20
> rte_eth_dev_info_get(port_id, &dev_info);
> if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT)
> { @@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
> case 0:
> ports[port_id].dev_conf.txmode.offloads |=3D
>=20
> DEV_TX_OFFLOAD_MACSEC_INSERT;
> - cmd_reconfig_device_queue(port_id, 1, 1);
> break;
> case -ENODEV:
> printf("invalid port_id %d\n", port_id); @@ -14138,10 +14133,6
> @@ cmd_set_macsec_offload_off_parsed(
>=20
> if (port_id_is_invalid(port_id, ENABLED_WARN))
> return;
> - if (!port_is_stopped(port_id)) {
> - printf("Please stop port %d first\n", port_id);
> - return;
> - }
>=20
> rte_eth_dev_info_get(port_id, &dev_info);
> if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT)
> { @@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed(
> case 0:
> ports[port_id].dev_conf.txmode.offloads &=3D
>=20
> ~DEV_TX_OFFLOAD_MACSEC_INSERT;
> - cmd_reconfig_device_queue(port_id, 1, 1);
> break;
> case -ENODEV:
> printf("invalid port_id %d\n", port_id);
> --
> 2.7.5