From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2A1A5A0AC5 for ; Sun, 26 May 2019 21:24:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E035E2C19; Sun, 26 May 2019 21:24:25 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by dpdk.org (Postfix) with ESMTP id 60762A49; Sun, 26 May 2019 21:24:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pgbkanCXRjfQ0cmjtDdgIDZa7aMm5VSzwcGk9/34xy0=; b=M9r0w/dBKb4E4IAjcWekVxNOJf1/vPQM+ZnqHuu3zJhZLsCEiaRlTvbpSWebBrKTFFur5bLOFTw46qxZ9/tF2mApXv7FXzEpmL0u/1Pue8AQ2wBN7UfZdJqBK+Ni2Vw8uysIK1gJ7XV2vg+5J53JLPrmnWhvkpnSc4hS53F1GfA= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3697.eurprd05.prod.outlook.com (52.133.46.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.18; Sun, 26 May 2019 19:24:19 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1922.021; Sun, 26 May 2019 19:24:19 +0000 From: Shahaf Shuler To: Ori Kam , Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix memory free on queue create error Thread-Index: AQHVDuOQiq8xERJskkiFpIsA34d2zqZ0SM0AgAmKjfA= Date: Sun, 26 May 2019 19:24:19 +0000 Message-ID: References: <40248d25f5870fbfd7e6b7df7dd6d5bd26f65559.1558339581.git.dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e97d6785-6531-4994-8f9a-08d6e20fc061 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3697; x-ms-traffictypediagnostic: AM0PR0502MB3697: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0049B3F387 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(366004)(396003)(136003)(13464003)(189003)(199004)(9686003)(76116006)(2906002)(229853002)(81156014)(81166006)(53546011)(6506007)(256004)(450100002)(8676002)(25786009)(68736007)(76176011)(4326008)(7736002)(6116002)(86362001)(71200400001)(66066001)(71190400001)(478600001)(305945005)(33656002)(7696005)(3846002)(99286004)(14454004)(102836004)(486006)(52536014)(54906003)(53936002)(476003)(6436002)(74316002)(11346002)(6246003)(446003)(14444005)(316002)(26005)(186003)(66946007)(8936002)(55016002)(66476007)(6636002)(66556008)(64756008)(66446008)(5660300002)(110136005)(73956011); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3697; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IzJxf/iuPxOpZVI7kxNEliLlg6QSSJoYW0ffxT91N0WC8v65Bn7RcbZzp3mYS38M0w7sVZHwpKL2VbyYI3rxRdn5Vk4j0k5pQl3zyVlVpW94hLTqBoaEz2VyJZJcGaCDNrM/NwDsDQyh0NbgkcCR3rItAx5nnB3RQ01qdP55/SCsH9N7EW1xc6En/WmTQJVK9GQ3Icrsm3zfH6ADmp/GkPsHbqpfMX0aKjAQliojFsMCuPErLATmr7ZwcfAnsmR0MzNDLiHQpEDCKOt1IRqdfa2u2DqcquyUQj4/GiKpyRv9oNjRxTrTI3mSpo5zJfGIWP/R/d5CAYjhlCGPRFn4B02uyPiC5VCBmaxFbEGIcO3v3Bos3dTqNnrCSNWbrbByfxWHN4fxaTYelcurkpkbiiEBYEPxA1EnPi6hlDQKua0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e97d6785-6531-4994-8f9a-08d6e20fc061 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2019 19:24:19.7940 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shahafs@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3697 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix memory free on queue create error X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Monday, May 20, 2019 8:42 PM, Ori Kam: > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix memory free on queue create > error >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Dekel Peled > > Sent: Monday, May 20, 2019 11:07 AM > > To: Yongseok Koh ; Shahaf Shuler > > > > Cc: dev@dpdk.org; Ori Kam ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix memory free on queue create > > error > > > > In function mlx5_rxq_ibv_new(), pointer *tmpl allocation is attempted > > at the start, but not validated or freed in case of error. > > In function mlx5_txq_ibv_new(), pointer *txq_ibv allocation is > > attempted at the start, but not freed in case of error. > > > > This patch adds pointers initialization, validation and freeing. > > > > Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue > > objects") > > Fixes: faf2667fe8d5 ("net/mlx5: separate DPDK from verbs Tx queue > > objects") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dekel Peled Applied to next-net-mlx, thanks.=20