From: Matan Azrad <matan@mellanox.com>
To: Suanming Mou <suanmingm@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix VLAN actions in meter
Date: Thu, 20 Feb 2020 07:52:02 +0000 [thread overview]
Message-ID: <AM0PR0502MB40196D7EE7A9BC9CC5EF2A6CD2130@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1582184744-91629-1-git-send-email-suanmingm@mellanox.com>
From: Suanming Mou
> Meter suffix subflow only has the port id and tag match item, if VLAN push
> and set VLAN id actions exist in the suffix subflow, the user defined VLAN
> items is required for the actions to set a correct VLAN id.
>
> Currently, the VLAN item stays in the meter prefix subflow. Without the
> VLAN item, VLAN id or pcp will not be inherited.
>
> Actions require the VLAN item as below:
> RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN
> RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID
>
> Add a private VLAN item to copy the user defined VLAN item to the meter
> suffix subflow, so the suffix subflow will have the chance to get the correct
> original VLAN id and pcp value from the VLAN item.
>
> Fixes: 9ea9b049a960 ("net/mlx5: split meter flow")
> Cc: stable@dpdk.org
>
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
next prev parent reply other threads:[~2020-02-20 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 7:45 Suanming Mou
2020-02-20 7:52 ` Matan Azrad [this message]
2020-02-20 12:43 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB40196D7EE7A9BC9CC5EF2A6CD2130@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=suanmingm@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).