patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/mlx5: fix RSS action validation of queue idx
@ 2019-11-11 14:32 Dekel Peled
  2019-11-12 14:16 ` Matan Azrad
  2019-11-12 15:30 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Dekel Peled @ 2019-11-11 14:32 UTC (permalink / raw)
  To: matan, shahafs, viacheslavo; +Cc: orika, dev, stable

RSS action validation function checks the queues included in RSS
to make sure they are valid.
A Queue is considered valid if the pointer to the queue (item at
location queue-index of RxQ array) is not a null value.
The queue indices are not checked. If a large value is entered as
queue index, using it as an index in RxQ array will result in a
pointer to memory out of array bounds. If this memory contains a
value which is not null, this queue will be wrongly considered valid.

This patch updates function mlx5_flow_validate_action_rss() with
check of the input queue indices, as done in function
mlx5_flow_validate_action_queue().

Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function")
Cc: stable@dpdk.org

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 092f7b4..14a89e2 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1151,6 +1151,11 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,
 					  RTE_FLOW_ERROR_TYPE_ACTION_CONF,
 					  NULL, "No queues configured");
 	for (i = 0; i != rss->queue_num; ++i) {
+		if (rss->queue[i] >= priv->rxqs_n)
+			return rte_flow_error_set
+				(error, EINVAL,
+				 RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+				 &rss->queue[i], "queue index out of range");
 		if (!(*priv->rxqs)[rss->queue[i]])
 			return rte_flow_error_set
 				(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/mlx5: fix RSS action validation of queue idx
  2019-11-11 14:32 [dpdk-stable] [PATCH] net/mlx5: fix RSS action validation of queue idx Dekel Peled
@ 2019-11-12 14:16 ` Matan Azrad
  2019-11-12 15:30 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Matan Azrad @ 2019-11-12 14:16 UTC (permalink / raw)
  To: Dekel Peled, Shahaf Shuler, Slava Ovsiienko; +Cc: Ori Kam, dev, stable



From: Dekel Peled
> RSS action validation function checks the queues included in RSS to make
> sure they are valid.
> A Queue is considered valid if the pointer to the queue (item at location
> queue-index of RxQ array) is not a null value.
> The queue indices are not checked. If a large value is entered as queue
> index, using it as an index in RxQ array will result in a pointer to memory out
> of array bounds. If this memory contains a value which is not null, this queue
> will be wrongly considered valid.
> 
> This patch updates function mlx5_flow_validate_action_rss() with check of
> the input queue indices, as done in function
> mlx5_flow_validate_action_queue().
> 
> Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function")
> Cc: stable@dpdk.org
Acked-by: Matan Azrad <matan@mellanox.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix RSS action validation of queue idx
  2019-11-11 14:32 [dpdk-stable] [PATCH] net/mlx5: fix RSS action validation of queue idx Dekel Peled
  2019-11-12 14:16 ` Matan Azrad
@ 2019-11-12 15:30 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2019-11-12 15:30 UTC (permalink / raw)
  To: Dekel Peled, Matan Azrad, Shahaf Shuler, Slava Ovsiienko
  Cc: Ori Kam, dev, stable

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Monday, November 11, 2019 4:33 PM
> To: Matan Azrad <matan@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS action validation of queue idx
> 
> RSS action validation function checks the queues included in RSS
> to make sure they are valid.
> A Queue is considered valid if the pointer to the queue (item at
> location queue-index of RxQ array) is not a null value.
> The queue indices are not checked. If a large value is entered as
> queue index, using it as an index in RxQ array will result in a
> pointer to memory out of array bounds. If this memory contains a
> value which is not null, this queue will be wrongly considered valid.
> 
> This patch updates function mlx5_flow_validate_action_rss() with
> check of the input queue indices, as done in function
> mlx5_flow_validate_action_queue().
> 
> Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 


Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-12 15:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 14:32 [dpdk-stable] [PATCH] net/mlx5: fix RSS action validation of queue idx Dekel Peled
2019-11-12 14:16 ` Matan Azrad
2019-11-12 15:30 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git