From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F14B1A0350 for ; Mon, 11 May 2020 14:33:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6BCF1C1C8; Mon, 11 May 2020 14:33:07 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20051.outbound.protection.outlook.com [40.107.2.51]) by dpdk.org (Postfix) with ESMTP id E3CAE1BFF3; Mon, 11 May 2020 14:33:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjaAYUxgYOG9o/DrRv7qiwNstYZHwHKNUAzNWC+y6udKuaG0ZJ58ccZpwkCVPzPU60j0y9SrRNsTTcBq4mSmK6UBhxQh5RdgqXQ0d8XHWSlFqf7geZMgJBoh1IkzvM/f8eb5297hJLGBb40ZP3HWnTWSbX/8BFZQ/hm+LncdpjtLcwYdynyxIu/vhdjTrA9rQEKekmZB48DhetZnbwCfgQnaE8SqgxryHGfwXD1kGlftfo03PALntLO8tigQ9jKs0+q6/UOkVV9CUhmOPgIxdX1N2rn8iwFadFSFFy7zNk8frL991h6hXPwP3/w1U1ngfTBqG+UXzNx7vyRAhJ/cKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zx9xZjqEwc+hehtIwF596/uNUZftkNuXa5QbduwOwcw=; b=GeKXk6nckPxoBYouE466Q2I+0xr9jqchOiD4/BV5LGW6SQ16KHU/tJ5dpYs9jEAwEVU1uI4buho9X3W5KTXVo9otWWuauL0CLoY7d9HnL5BE9kM7PWB/++45kJF7htGpB6Rew1Gvxy8yzSFXbWP8jJhK5dwCW9v/WCYruUEXqS3V0l+Q/Av48u9j1LnqlMqZ0lsfjz0elJXgNBJno7m5cfSJWVrUlpubTaQP6g59lXLhi5rUvvd/3vXlYp8WsacvTN1MrydG9grT5VqFGV8uY067czPXMISbWMMYOzlAaoxe8C8dyR9oh/QAF69vyThL9cXC421Atz8e9+aOOWT3tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zx9xZjqEwc+hehtIwF596/uNUZftkNuXa5QbduwOwcw=; b=MbeCc3h9bZswCpf6pPe4oz81R/ruDGiAY2DmZ1LbmahjA2RbmvXMe1lMEGaImkaF7WzkQ8yzjztKxjFJhk4SHulJSHQmzm86csI6n38ve8ORoK9S/4gZNCAItqU0Sl5axosFDVxB5Pcofap9cpnEi/Ni3U1bJBHgEAwLb7lZaQo= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4433.eurprd05.prod.outlook.com (2603:10a6:208:62::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Mon, 11 May 2020 12:33:04 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2979.033; Mon, 11 May 2020 12:33:04 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix meter color register consideration Thread-Index: AQHWI8LY8fucEQWswUKMM2i4J26CWqii2PSw Date: Mon, 11 May 2020 12:33:03 +0000 Message-ID: References: <1588782246-16271-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1588782246-16271-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.229.217] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d0901ccd-5ca3-4ce1-0ae1-08d7f5a7736e x-ms-traffictypediagnostic: AM0PR05MB4433:|AM0PR05MB4433: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DIhPmZvXVVZCkTaYLsz5TFgwK5sSn5fJPOdSUPUPB6nUB7jOvv0nv1Th2wJL0MBO0gCqv7F4OM/xEWCkEEP49jHBJP/cpK1aWAxldOtbcYyFEvDhzkuEtSB5o5uk8j8/od9NQBGSEBt4/za4kxB6Lb6yN21YRdwFqznLwFDCTTgAgFbxUq5mxilTnWXsf8UHUZua6Onvhg+w4CfAru38XnRUd7h2KL5na0AJGIsWtlevHp2IwPgpL0XYJAZa41GHsQxr57tY8ircZM1vFCC41IPapndjjlAcmFqz/lbJaHKUy3Z4AoOH47nixWLpeaZscCBa1ZatreAwHvZsfMgudiFbokkVqTiSdIqgyIo91gVgiBGIGWa+x4b4rzUsPiCvrMsUFrN0Ts6+3Vh1tFcr9Kbi7dg6x1vW9M9CcNb5qZq3fR8CWFO6kvHv5GY7fHcoJr/hBPnmRWSF9SyPxTmpJDDmaJaqDOeB9LrXyKTWwbTCpcK1YNkvDR7jWkd+b+7eW/vV5wn/F1/s40O2UpadzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(33430700001)(64756008)(66446008)(5660300002)(478600001)(33440700001)(52536014)(316002)(2906002)(8936002)(71200400001)(55016002)(110136005)(86362001)(9686003)(54906003)(8676002)(66556008)(66946007)(76116006)(66476007)(7696005)(33656002)(26005)(4326008)(450100002)(53546011)(6506007)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: SxrIvhiV9uMSi2OoyonGwg7mdoL1LzFTj+9kM1DiXglAmtEC1CGgtvzebORLkSEYL6QQ/mcYNTkYHEym9RBQKKR21GOQtwh4tkbYEcfqP2Usi6tAy3lEqsR6OHUXAFr8jRB321HpqJrNCtbJsZDEnRLg4Yl2C3aBheF+gjgqmifOPVN/RfCnX/ICIbWRt1IeVMLhPm0o7Uh7c+MUriqF+WHQBJwz/3EzEuU1Fgs96m8lhFcXdZIbpp6FnT5DTtBrNVxrVQPWw4Wu7QucgI6yj/5JuXKhmJSPf6Qh724AE9p/+42dSPL4cT+8QCxQCjLJKGAB3/8uQccKIrshYTOIzkL/V9ztbvlqw07NOomu8rj5oq6fMghdX/l7H1sMGRc6AcnKOvNpwxe17VEXpjZ/ZO9LAxRbwQhKRF0vwROXrkRw2l6Oi7OtTA3olPeX0mYCWjPWdvJfRtXzUjWLAEcH9LnIcu+u0XPoxHqLF3KdTx2Nl+L8hjzOcpl1jmAjQ2gH Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0901ccd-5ca3-4ce1-0ae1-08d7f5a7736e X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 12:33:04.0144 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GgcQhTkSRIBGs8N54xURLESShnrsGy3aYn7HPmfszuxBWp0hTyP1drUrev+vz8p6EIeLrwUpmN1gpITfcC+CvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4433 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix meter color register consideration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, May 6, 2020 7:24 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix meter color register considerat= ion >=20 > The mlx5_flow_get_reg_id() function translates tag ID to register > from the registers that are supported and available for use. The > user does not know which register is available at a time and therefore > there is an array that represents mapping to the available registers. > Usually the free registers are continuous in the flow_mreg_c array but > sometimes the mtr_color_reg register is between them and it must be > skipped and the next register returned, in which case the function > returns the mapping of the next entity in the array. >=20 > When the function reads from the next entity in the array, it does not > check whether such an entity exists and in some situation invalid access > to memory occurs beyond the array boundaries. >=20 > So, when all the registers are valid from HW perspective and the meter > color register is not the default, the tag id 5 causes an out of bound > access. >=20 > Validate registers availability when meter color register is not the > default. >=20 > Coverity issue: 146355 > Fixes: 792e749e92d5 ("net/mlx5: fix register usage in meter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 01376f3..08c7cdf 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -442,6 +442,10 @@ struct mlx5_flow_tunnel_info { > */ > if (skip_mtr_reg && config->flow_mreg_c > [id + start_reg - REG_C_0] >=3D priv->mtr_color_reg) { > + if (id >=3D (REG_C_7 - start_reg)) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ITEM, > + NULL, "invalid tag > id"); > if (config->flow_mreg_c > [id + 1 + start_reg - REG_C_0] !=3D REG_NONE) > return config->flow_mreg_c > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh