From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C05C3A054E for ; Sun, 8 Mar 2020 12:33:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADF371BFF0; Sun, 8 Mar 2020 12:33:42 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2080.outbound.protection.outlook.com [40.107.20.80]) by dpdk.org (Postfix) with ESMTP id AEF8F1BFF0; Sun, 8 Mar 2020 12:33:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qq0ItSCQkWPHRRZu1YhwXQX4blJtyUq3Cu4TxI62eSk2eMJu/9lj3LC3dW1Dj+QN1UQNiLzZPEoNbbEMkZ3uPHcGfDFsgsG48lFS3Gj54fR+Jtn2XZYGgZCarVrpSFrwJxrPBopjCNkzkaDBmitys0h6NLJJtJlmJzsskuHZ4JXx5kxgkOdGJo+d9W6maNvyLo0FxZgnf/BZIZnVpbxEPL0hbDlVbEGgJMaohMd7brscMNtp/ucvzPTe5CkkqiRtwsprS/V0wJOpAx1pr1pkFx3S3WYUuWzPi9PPsZ9Oe+KKKzILoPP2tODNBl0HhOdLRITdNfOsAHPk2ZA6CZ49ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=727x+QRyFkhEF8UTg1TcA+EaqZnGHebJJQ1wExKqwNo=; b=HSZLSUenaBH39DzTvpPLE85JfvjeN05nkS8KhI2inmhvClvsiuUjxpYUwXWcanIALt1hHnRsdVbxddZcjp804r/sMfLISEUBu18P+JSBBtGgtWWwgJqCJreMP1WvIojifHBeeFej25/XLbVzfoJwkE8IwD4Z24/VuLscfwKy904JbnXldZJNaC0OYNUB6ksS7JUE1CumK0hLHuq/8ID9b9cHqgZYAw7+at3SjBi/Jw8K96SkPZik7t2LIgcpoqYHHazD6JKCANqudtiXHxUQuS+4BLH+vwGrAEBR4bzUkq98/oLbE7RG/Zw+IZzutCReNKx+LBcKVFoH7xD7YhiCjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=727x+QRyFkhEF8UTg1TcA+EaqZnGHebJJQ1wExKqwNo=; b=cBTc6bSL1u0MR2Pdllq0SvsPo5NFI4pfK2E5wY2jTZIjnuqQIR8yM+7768JpRT0dvvmTj0JAfZux98VM8dxZLyU3Kb6V5cmr6yhuuUY+cQ4zhJX35zi6uthgtC3h/KJUNqdXoQALtYmCQ+UhAKQUm85A1nz8LIZN81HXMU6gCeU= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB4500.eurprd05.prod.outlook.com (52.134.124.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.17; Sun, 8 Mar 2020 11:33:40 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9%7]) with mapi id 15.20.2793.013; Sun, 8 Mar 2020 11:33:40 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix mask used for IPv6 item validation Thread-Index: AQHV8ViVQVjEIq05V0mbTmYYvUjoKKg+mATg Date: Sun, 8 Mar 2020 11:33:40 +0000 Message-ID: References: <5b62429c2368041d9f6a4e1d9b5a8b389261c8cd.1583238768.git.dekelp@mellanox.com> In-Reply-To: <5b62429c2368041d9f6a4e1d9b5a8b389261c8cd.1583238768.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8e9d35f8-7647-47d4-0f60-08d7c3548cb8 x-ms-traffictypediagnostic: AM0PR05MB4500:|AM0PR05MB4500: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 03361FCC43 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(39860400002)(346002)(366004)(396003)(199004)(189003)(66556008)(86362001)(66446008)(64756008)(8936002)(33656002)(81166006)(81156014)(8676002)(9686003)(7696005)(478600001)(76116006)(66476007)(66946007)(55016002)(450100002)(5660300002)(186003)(4326008)(26005)(2906002)(6636002)(54906003)(71200400001)(53546011)(6506007)(52536014)(316002)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4500; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9zWJN06mcqKo0aAzZLSWUVOh5Tqdds5qmtFU9vlLdaY+XmGlN3yXhgHKFT7S5axDrHUWRmQp/CDTM47KuCG7Vxe2xdUuuNozdzd8Z9f+DyNehcLXYR/6YpSz2r6xxWukSZNbRc5LVdJbMwIyhCv0UN1xcBsri3dKCMtBz/YlGfNtAhQcb+tx7TmcV+kp7vzUhePToJlrrOqkKdH4w8zAwFsbKmo8E+SI5Ae9QfQK0MtE6lfrv3buXzlLc4YpxcxkBNyLaGqU1F6KRTtx6WQz/2PbPJeLPPqSxOw5bxCkVATU/4hZfIZo+MmA00w159TdAF/fpLH5GQNz05qvNjtcwK8lGM5pXARXJwBIVueQ75k20czKDZ/Sr+yaoZE+Oc1TbOA4bwo692diNHbahimY8HEvYM0WFkhlFLe4yWfxqNPoEJw7q0iOY/6XkcV9FouL x-ms-exchange-antispam-messagedata: 36ZF/Bgju+/e3P2AhpCioYpyhB58Hn1IL+qNMnybb56X70q7ByDYCm9htPDsiofP7bWs4P1Bq8uFJ3nPrjTr6Vx6RjuMvzn3JOrkTEXVeZnHGQkEblkjDHEtHAeCNgi2AyZJwr4zVzX8SOUc4kS4kg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e9d35f8-7647-47d4-0f60-08d7c3548cb8 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2020 11:33:40.0691 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LN414bDM/qoNQbBQA7Z4N043sc6wtfFsyizoSrjHcaJT0ucG3WWZXgQKKiGWlMcvCj8F4Ik3wF8Dov2Dk/v1dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4500 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix mask used for IPv6 item validation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Dekel Peled > Sent: Tuesday, March 3, 2020 2:38 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix mask used for IPv6 item validation >=20 > The nic_mask struct in function mlx5_flow_validate_item_ipv6() > includes hop_limits field. > This is redundant since matching on this item is not supported using > Verbs flow engine (dv_flow_en=3D0). >=20 > (Separate patch will be sent to handle this issue for DV flow engine.) >=20 > Setting a rule including match on this field will fail: > testpmd> flow create 0 ingress pattern eth / ipv6 hop is 1 / end actions > drop / end > port_flow_complain(): Caught PMD error type 1 (cause unspecified): > hardware refuses to create flow: Operation not supported >=20 > This patch removes the redundant field from nic_mask, to ensure that > such flow rules will be rejected by PMD validation: > testpmd> flow create 0 ingress pattern eth / ipv6 hop is 1 / end actions > drop / end > port_flow_complain(): Caught PMD error type 13 (specific pattern item): > cause: 0x7fffffffa2c8, mask enables non supported bits: Operation not > supported >=20 > The related lines in function flow_verbs_translate_item_ipv6() are > removed as well, since they are redundant. >=20 > Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated functi= on") > Fixes: 84c406e74524 ("net/mlx5: add flow translate function") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.c | 1 - > drivers/net/mlx5/mlx5_flow_verbs.c | 3 --- > 2 files changed, 4 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 16c1ef3..41072da 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1640,7 +1640,6 @@ uint32_t mlx5_flow_adjust_priority(struct > rte_eth_dev *dev, int32_t priority, > "\xff\xff\xff\xff\xff\xff\xff\xff", > .vtc_flow =3D RTE_BE32(0xffffffff), > .proto =3D 0xff, > - .hop_limits =3D 0xff, > }, > }; > const int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c > b/drivers/net/mlx5/mlx5_flow_verbs.c > index 04845f8..459e7b6 100644 > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > @@ -494,14 +494,12 @@ > ipv6.val.traffic_class =3D (vtc_flow_val & > RTE_IPV6_HDR_TC_MASK) >> > RTE_IPV6_HDR_TC_SHIFT; > ipv6.val.next_hdr =3D spec->hdr.proto; > - ipv6.val.hop_limit =3D spec->hdr.hop_limits; > ipv6.mask.flow_label =3D > rte_cpu_to_be_32((vtc_flow_mask & > RTE_IPV6_HDR_FL_MASK) >> > RTE_IPV6_HDR_FL_SHIFT); > ipv6.mask.traffic_class =3D (vtc_flow_mask & > RTE_IPV6_HDR_TC_MASK) >> > RTE_IPV6_HDR_TC_SHIFT; > ipv6.mask.next_hdr =3D mask->hdr.proto; > - ipv6.mask.hop_limit =3D mask->hdr.hop_limits; > /* Remove unwanted bits from values. */ > for (i =3D 0; i < RTE_DIM(ipv6.val.src_ip); ++i) { > ipv6.val.src_ip[i] &=3D ipv6.mask.src_ip[i]; > @@ -510,7 +508,6 @@ > ipv6.val.flow_label &=3D ipv6.mask.flow_label; > ipv6.val.traffic_class &=3D ipv6.mask.traffic_class; > ipv6.val.next_hdr &=3D ipv6.mask.next_hdr; > - ipv6.val.hop_limit &=3D ipv6.mask.hop_limit; > } > flow_verbs_spec_add(&dev_flow->verbs, &ipv6, size); > } > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh