From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2267EA0350 for ; Mon, 29 Jun 2020 10:45:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 15C2F1BEAC; Mon, 29 Jun 2020 10:45:25 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80072.outbound.protection.outlook.com [40.107.8.72]) by dpdk.org (Postfix) with ESMTP id 2BB751BE9C; Mon, 29 Jun 2020 10:45:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XB+hV+oYS6XG09R93be2qwRQgIrh67OxiNu4EfTNHiwiPF4alErMPzSUFxqNvHj/fwOhx39WvLtsiMwSRrDwcnWJmRtxcNNTRaQbbWDpv4bkM17sZCJrbEWPq9n7a+4JyeBfvzfRuZdx+6ZfWC/zeORxXwYyrZURrteguciSAAHoVKAfn3xOqV5AJU1aQ2CKWyirjusvsssxjP5qeMh0XqItQZ/2AByLbvaisUL5W9jVMi4Wwp4iNE0ZnlJZCmbZQoyMltQiVsq0+NisGcrpXA6M83II3qva4cKFdOEQ51v8YxewJjahdqfW2kFMnykDqUlSgxnkZ5c7z8+Z8iFg1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nWYhWmeKB9KYNGrQGZM9uI7u1QAximYpB+8zKZa4cpA=; b=jGUMts4vBqWihZJ0pD18ELIcqZTRdwp5JTIWBlbMxw1cPwmItlqCCziKZ41//YrJm+xAM++iY6A0vLBiFcLFB86hn7xJlwMs0B6wggbZqedbLLfzwxntEXsueUbDz4qhqlvLb5Hjs+8Uc77/roCZgM3IeEszgrQM6XXBKncIBNdsffHolixXr0ZD+5BAktuzUwZLQGIFJo/ad0IeWBATS/CYjcLf8e6BDD0KorjET6x86TesF9E6KBK1BFO8BP/2JRQKTVE3Mg7s6LrOMqctZy9nx45lme8VGCgQJ6882NEJE95zU8/NCD5JXgCp8N11raAMk4hcgyfOvwwWVztExA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nWYhWmeKB9KYNGrQGZM9uI7u1QAximYpB+8zKZa4cpA=; b=Ys8u0I0NrBVwr0gbsystLadAY5/K6W2QEPAQVpPcqEkllRj7kHqs98ifhAgInwKdqOUoL6NUCQB6LIdSLs4WlNs72CYeYPjcYDtG/UYjdZTDr03Q/WQB+r8C7j5V2YEtnXzA+OY8Sddg+wLaFGduvWA4MOdpLJyTfCVhmPlvlt4= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5939.eurprd05.prod.outlook.com (2603:10a6:208:128::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.24; Mon, 29 Jun 2020 08:45:20 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3131.027; Mon, 29 Jun 2020 08:45:20 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix iterator type in Rx queue management Thread-Index: AQHWSjGitnWQym2d1Uu1wjq5JbUQyKjvTsVg Date: Mon, 29 Jun 2020 08:45:20 +0000 Message-ID: References: <1593007618-8066-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1593007618-8066-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ae2d4c22-ccf8-4c57-60fd-08d81c08c1a2 x-ms-traffictypediagnostic: AM0PR05MB5939: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 044968D9E1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KQOmIAIaCLVuJ/r5NO4hrg3fiSkhjzxIptWE6zP3Ra05K0BEHQByQT2Oibk6+60m3LBNfGENut453yVVbUokWXRMGNxtLvV3fqrzRx54mYsBy68TMzsd0n0ek4PQLlV6d2RFOpQsdqstq28ZPRo+KlJVnkAu0Xjg8z/HVw7WLi4d0w8DcawrcFnxEM8ydgK7ZN8Tvog6xhY155iAj9o9KDJYMMrDea+EzUQJ8JSkcMMivh6enbD34Uzw09vYojg2LX42PNz1wVnDPGM45jhpHcFcTwGShnXSck4hN8JX25cGHV83g4rtjC9uc+pMgHG4DY7fLyp1mbUt0jrVBojPWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(33656002)(6506007)(9686003)(26005)(186003)(53546011)(55016002)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(7696005)(110136005)(54906003)(316002)(86362001)(83380400001)(71200400001)(478600001)(5660300002)(52536014)(450100002)(4326008)(8936002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: qK6hDMJOEtjSnK8Dc1BfVatOoKt6bGrWW/z9GvtGIk2kv40rJ66200Kc3JHoNaZrFCLGXtT4Yn0/BHYPXk7vrLHYAuqpY4+NVIKHYNJWC0SAs5FiRgiKEqQ5dvH95CU1fwpUO9gC8dRYuP69ldYdjnVoajrtRNM6sSe9bVVtDhBjyz8/OA7wIZOAG3fdNQAFlgjoq8jM01xx888NANw65EhxEdVAYVwosrivPZgNWCnKGtZddzfaQd3F7RdDABfjTHsy/WHAbJOr0dLNnRCT9HRNX2nbGJ5/cHCEo9D7zFtaQvrZjawxr/jUx1tGYjj3LwqPvRwVuDmRnShkyzbpO2BtGrhhPdvA6+urOBfaVpjFeKeWuEkfW52Gw+1za2DPeo9t8mVyfG6cEN56lfUr0uaTUAJ0bdOQ1Gh0jB+m88q8ftlIUoHnGcNhHEEgaQN1H4y5S9iF8vxHECRbR+x4nikrEj1kM1zKf+vRwbZ/GtmrKhayrU1jtGhDCyL2NpBa Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae2d4c22-ccf8-4c57-60fd-08d81c08c1a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 08:45:20.5402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iVCIcvO2JsaJdfAif+CsMSvrUmTDZJTQZs1dCgfyyo8mQClzidgghm1n8BnKG8Nm+TdhLZ0OcOBIDpHL2+rpVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5939 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix iterator type in Rx queue management X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 5:07 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix iterator type in Rx queue > management >=20 > The mlx5_check_vec_rx_support function in the mlx5_rxtx_vec.c file > passes the RX queues array in the loop. Similarly, the mlx5_mprq_enabled > function in the mlx5_rxq.c file passes the RX queues array in the loop. >=20 > In both cases, the iterator of the loop is called i and the variable > representing the array size is called rxqs_n. > The i variable is of UINT16_T type while the rxqs_n variable is of > unsigned int type. The size of the rxqs_n variable is much larger than > the number of iterations allowed by the i type, theoretically there may > be a situation where the value of the rxqs_n will be greater than can be > represented by 16 bits and the loop will never end. >=20 > Change the type of i to UINT32_T. >=20 > Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support") > Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_rxq.c | 2 +- > drivers/net/mlx5/mlx5_rxtx_vec.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index bd0037b..b436f06 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -108,7 +108,7 @@ > mlx5_mprq_enabled(struct rte_eth_dev *dev) > { > struct mlx5_priv *priv =3D dev->data->dev_private; > - uint16_t i; > + uint32_t i; > uint16_t n =3D 0; > uint16_t n_ibv =3D 0; >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec.c > b/drivers/net/mlx5/mlx5_rxtx_vec.c > index b38bd20..7fae201 100644 > --- a/drivers/net/mlx5/mlx5_rxtx_vec.c > +++ b/drivers/net/mlx5/mlx5_rxtx_vec.c > @@ -156,7 +156,7 @@ > mlx5_check_vec_rx_support(struct rte_eth_dev *dev) > { > struct mlx5_priv *priv =3D dev->data->dev_private; > - uint16_t i; > + uint32_t i; >=20 > if (!priv->config.rx_vec_en) > return -ENOTSUP; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh