From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 809E6A0540 for ; Thu, 23 Jul 2020 10:57:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CBF41BFE7; Thu, 23 Jul 2020 10:57:33 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) by dpdk.org (Postfix) with ESMTP id 9C5471BE9A; Thu, 23 Jul 2020 10:57:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OkQPd4DnH/XE7si6Jxldm9nCnqw7/el1lqLoP2z67xjOmitYp9xzDsG3ucdM++H/GVNfWq+28u8qMmfOnr6ZdW1Us+FFsc58fLZodALwIjb3wD/5WRi8LincDUeuQWhhcSL4KM2KaqEHZXqGxmKX6eoTpHYWbeN4haZxkPLJpmM9jJzAQLBaYWuqpTu00fQnTcooT9JLZzCz+jHdmqBbYd66zNcO2cTnj76fg1LYeB7ylxA3vZ4BzxfhOlDvQFurwIv+M8rUoX1nwMCxGisSvyf4nWDb43UnPzJHQVCq07MXXOLCR6o5U/UZSjjGvQD/yjv9wIRtiX2H4GYATgvk4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oTAW4xB/BMollCfcjL7TrNam93tiqm2gVXD9xe6gvzQ=; b=Yc9XGCcKRYi3oQwTnU+KyDDE0+lcxbiSjfGlSMfO+x2rQF465YojvaMwUJLPmmM/paUgJqwtSE8PNpK52ePzIcXgUMSTF+UxCiQL2cBxQTzSbsOOB5+wW6K/psrpjS44kW3CR1ussvVbbuRnYa2XOXZShw0mqQJeDF6Rm30+EImhKduKElL5j2aYd2TceQKMvzdlP/ti88jq5MtT7/MYeoRzGzekCgFsugjoegXSsoJ5JMiT8GQl4Db+7LD+BqTh3sOz/Fq+ierqSZ2xOXSOcxHAylX+IWHDtdYrsZlEaKG8SV7euyVZKJ0h1b7/HW/Iz3tW9i62Td4XOzzcvkwalw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oTAW4xB/BMollCfcjL7TrNam93tiqm2gVXD9xe6gvzQ=; b=iW1flUoakuoA8REBQte04+35WPPAA4JoL2QcPIQc7/RHKd7V7wuAyM3WJtjlbZyP1zOcxfINoftlgBRX9B2etBgExnkirlFyXvbFgvizJjaCNmnH8UGiE25OHQAIuXpLYilbavzPMXkoLqHeHnX7jPsQCBO1yVFj7OaibbXGlbc= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4402.eurprd05.prod.outlook.com (2603:10a6:208:5c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Thu, 23 Jul 2020 08:57:26 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Thu, 23 Jul 2020 08:57:26 +0000 From: Raslan Darawsheh To: Raslan Darawsheh , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix VF MAC address set over Bluefield Thread-Index: AQHWYAee2/nsNo2AQU6ZatqaJZBWqakU3gjA Date: Thu, 23 Jul 2020 08:57:26 +0000 Message-ID: References: <20200722090755.26103-1-rasland@mellanox.com> In-Reply-To: <20200722090755.26103-1-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4a2bb748-1047-448d-383f-08d82ee66c0c x-ms-traffictypediagnostic: AM0PR05MB4402: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q9/IVt6f9OvbWnmAksadHE/lQ42ckFC1duyT/KXblFItGqnvtFAmRIvRBCwjVNBIQDCHvAJjPvFeHU0+umX+TGcVQuDVLtVNa8SqSMPJMqFev678xCxxQabRXINMbcUsSfds+PY9Z5ONszVgVExyeWEVxq/oePGK8Y0Sl+xsJmA5Sn2DQ9IcnYlPKcetj9D41jRhSmC4tkhsCT77xIk5rAZi6KL326BlALOB9kKhxYOjLyExuYUETCAqHHkH6zWqC7lvTjrEHBfYFr+zwdBUHwRlPbiEdNDjkOa2g4JaPw46Q2ZqT0bbspyAFdA3KH/Q2fi7Cy/tyxgpC68MF9Pvzg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(107886003)(110136005)(5660300002)(316002)(54906003)(8676002)(9686003)(66446008)(66946007)(8936002)(66476007)(450100002)(64756008)(66556008)(76116006)(55016002)(4326008)(7696005)(33656002)(26005)(2906002)(186003)(478600001)(53546011)(6506007)(86362001)(52536014)(83380400001)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 4gXkqZ5FpRskl1pizpjpgpBzKM44IZW4f117TK+GO0izlcJONsRHgh4F568KFRva4IUvGciaRbeolRKvFCOFcuhLAeikrVtwQ1q53m8k8T9KUXbL7qP5se0a6tTRIL+AV7NkmAISMWePEW3IR3mnadhGI+quJ2aJZ2B0ir8ab2XypGwIPmwhOrBhtBTpNwlZtpFMuvN2nLhzii4dhkzkfSGc45B0NHdVhD3Q1U4KGoOSKTgn2IEUf3dbq9xXjrqvafFffDD1Pxbiml6aerZ3DWhvYvJ+VqAWxAhgL6Pk/UTVfxmBurIpuh1RbG+HjBWE91dRQIiJIg9QLXwnKB9/MQWsrChoEKBpTQQ2lM9zZSW/tc170HWlGxQ5hzVhN6apAD5nouMREWckFF9FgzG31AgbNwUAhptH4BzRp0hUUwbN9/ula/5FIj+D1XozcaZ+Aji33Igf/mmxVDF9+QNBQPrBiF9el4m+x3IIliMmm5tv3nTlYXR+GQOERbppDM0Z Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a2bb748-1047-448d-383f-08d82ee66c0c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 08:57:26.0990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KwuYwGd33oUbwEiem/T9xpH+ngt9cZL9VV1AqdodSBcIQ6AOGICXXNneY2NXk8LOxH2GX5s6AufMdktYZaItRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4402 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix VF MAC address set over Bluefield X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Raslan Darawsheh > Sent: Wednesday, July 22, 2020 12:08 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Slava Ovsiienko > Subject: [dpdk-dev] [PATCH] net/mlx5: fix VF MAC address set over Bluefie= ld >=20 > When trying to set MAC address of an ethethet device and if it was > a representor, PMD sets the MAC over the corresponding VF instead. >=20 > For the case of HPF (Host PF representor on BluueField), PMD shouldn't > attempt to set it, since it doesn't have any corresponding VF and fails. >=20 > This will fix the issue by setting the MAC on the dev directly. >=20 > Fixes: 0d1d73170820 ("net/mlx5: set VF MAC address from host") > Cc: stable@dpdk.org >=20 > Signed-off-by: Raslan Darawsheh > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_mac.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c > index 2d808d629..c75b1a169 100644 > --- a/drivers/net/mlx5/mlx5_mac.c > +++ b/drivers/net/mlx5/mlx5_mac.c > @@ -157,8 +157,11 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct > rte_ether_addr *mac_addr) > uint16_t port_id; > struct mlx5_priv *priv =3D dev->data->dev_private; >=20 > - /* Configuring the VF instead of its representor. */ > - if (priv->representor) { > + /* > + * Configuring the VF instead of its representor, > + * need to skip the special case of HPF on Bluefield. > + */ > + if (priv->representor && priv->representor >=3D 0) { > DRV_LOG(DEBUG, "VF represented by port %u setting > primary MAC address", > dev->data->port_id); > RTE_ETH_FOREACH_DEV_SIBLING(port_id, dev->data- > >port_id) { > -- > 2.27.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh