From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 498B6A0526 for ; Sun, 5 Jul 2020 10:05:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3350C1DA95; Sun, 5 Jul 2020 10:05:32 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00068.outbound.protection.outlook.com [40.107.0.68]) by dpdk.org (Postfix) with ESMTP id A6F9A1D9A6; Sun, 5 Jul 2020 10:05:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XmIZbRMFB2CIlDURrvGpVZ1uTpO9X/2czbBuPnlBX2gleexkF6SJ6qbjuFB4lenNFnzHjn7QB1qISt0VmTydUr8bp0gFhoIpvgGU5ankBdz2IZ/4pEgcIGJqC44jh1qg6I9Xw8Xs/R3nKuX+6gEaJndAOICXsadjz4nXcLXdScN3gwP4muGGCUE1Y7vveipLuNXCrN/LV9hkW78QzT+0TQCHpQSiu2kAjxnuj3QmKlLdxFLKDL/U8iOujy0XebifYn1ePYOlF5kyd5XTjCQdG0MHA/cWdPygsg2h1bYbk9hXjed+xM5UnUjD/VfAr2CfAr+eLgpFm67EyDTGxOzUJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W4JxOoDH++eN/EqGad3GrYyYrUXTHjSCI4ae7jrzJk8=; b=EujH67P+S+m6A7LnAujN3dlEEM+251g76HnuHuyL/6Yj5g0GlcIcLG2dTs1Qveel51cY4rkMSeQlZUsaFzdFkNnMo9MqT6xBxox6q3o1iulWDy37/ytu8MIEcsRQDrlYGXwxy329Gu16kyvro/IOCoyg7MWv30DYn8Wxu/YzRVGy4gJcFQfV9gyOREjjNlsCdA1985jtno4bthaDM8wWhiOXK0lMpgCrPg/UNFWzjPgQihz3GpSF4uyUKDGLEVfp5Z4sfB6BU7Gab7nIZO5T+Zyg/vDUROCuxkwAdYKjAhqoY2MmZtYcL/6uHWGNAh1TCCEI7WnMTmtTzy/ETDd6sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W4JxOoDH++eN/EqGad3GrYyYrUXTHjSCI4ae7jrzJk8=; b=lv8Do9B5FI3Ln73rMdQ8uR+h/YYO8yb6IiM7X1UlOJl07U0E/nEtB51NChSqLvbV9ONR0e2QGo4L+c9ICqqFnk8l1ZlBVhSeUCEY2NfQCZnrgfZNTZfu90OqUNmOcdyAFZBLKsI+rU2MwM0AhrQGg2tU4wPujYZqX1IFmAmE/iM= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5795.eurprd05.prod.outlook.com (2603:10a6:208:111::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.27; Sun, 5 Jul 2020 08:05:28 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3153.029; Sun, 5 Jul 2020 08:05:28 +0000 From: Raslan Darawsheh To: Shy Shyman , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation Thread-Index: AQHWTS+mLQZdftDWPU+2B0OeSPs0u6j4q1aA Date: Sun, 5 Jul 2020 08:05:28 +0000 Message-ID: References: <20200628093631.56672-1-shys@mellanox.com> In-Reply-To: <20200628093631.56672-1-shys@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fecc507f-35e4-4fa2-4518-08d820ba2e32 x-ms-traffictypediagnostic: AM0PR05MB5795: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 045584D28C x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oiaWi2oSD3hO9zdojhJjx72YNMeX6rFWzNUnLyT3xy89o4naQQi4UnaPbKrjuiKWRz1epOjW5Xhzbve/x1GEIOxawH+FLbbsQt1lhC7gbkSyMiESa4SJTBTkQPmfSVy6JTQ2sKqzrm4P/ehcT2aDoaa5nFRnjjI2QX5TwSn1Hqmn3ILL2MSuDZbYapmL9Jx4UCv3W4/zxzqNuAmZT0H98kkqRcXCrv/07lqGXbm8Ohgt85nJZtjqsZhixnYAKdhcNugRXVOnuTIYAijXKL/G2LV01810Px/xm9qZ5/S/2o9xxxvsWERMjO03m/IsmfFUnN5hPcNhDAJf/qyy5dx3tg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39850400004)(396003)(136003)(366004)(376002)(8676002)(4326008)(33656002)(66946007)(450100002)(76116006)(66476007)(64756008)(66556008)(55016002)(66446008)(83380400001)(86362001)(71200400001)(478600001)(8936002)(110136005)(316002)(53546011)(2906002)(5660300002)(54906003)(6506007)(26005)(7696005)(52536014)(186003)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: yVD7e7kyvHZNJZnrqH7V4ts4d4/9mEMnidlOOWOq1Os1jT+7fhFhX2ILqKxca4BmNkNSHJJIVdrBLMZzI6E1DOGuEPeL3omPX16o9P3RagJUEsWwbWCHrjjEWt12XDiIwZhJnYSgCN0QGbvfQGFmHduKoW5F+7ksesfUuk0NKiC2lgRxCpXkBnXzM0CrTHKqBlOAtrTA/o2j2nXIf/roTkBMq/2P5xNfLOQx3VXMDpbGEx2hi/PEoE/j1nvsBktm+o+Lor2k7A1C9G6Ik4UmcP5QRYMqLiDDu735m/U46uCUZFFwmyC+5jxPl4ioEXR//a85NXmeDOkLkeQp6CUuzoAIpjJ1RE4M36OB8Ldj38XR1QKLkqBArqpiyQfaHrbB1F5nhv1RV9ZLWJi0GnUHCGr3bLibzc5IfJoH4AdxcRQ4yLO9nCxLjU6FK8AtQFn0hHbHnZHAgAnxSdYEBK/oJU2v52yp81pTy1yfn8oSukU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fecc507f-35e4-4fa2-4518-08d820ba2e32 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2020 08:05:28.3449 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /XbIBvFiUfA3RCspduOoBzv45Ar9NAeU3eYzCUTdYbqm6YgsZhDmTtrdSH1L4WjB9LVjWXNxvvnj/7pzGFNxIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5795 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Shy Shyman > Sent: Sunday, June 28, 2020 12:37 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation >=20 > When flow is inserted with meta match item it requires a certain > register support. > As part of the flow validation of such flows, the validation > function is missing a check that the mlx5 driver is not in > legacy mode in terms of extended meta data support > (MLX5_XMETA_MODE_LEGACY flag). > If the driver is in legacy mode it will cause downstream > function that allocates needed register for meta data. >=20 > The fix checks explicitly the conditions for support of > meta data in FDB mode. if the conditions are not met > an error message will be issued. >=20 > Fixes: 9bf26e1318 ("ethdev: move egress metadata to dynamic field") > Cc: viacheslavo@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Shy Shyman > --- > drivers/net/mlx5/mlx5_flow_dv.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 6318bd99cd..e037643c98 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1479,6 +1479,13 @@ flow_dv_validate_item_meta(struct rte_eth_dev > *dev __rte_unused, > "isn't supported"); > if (reg !=3D REG_A) > nic_mask.data =3D priv->sh->dv_meta_mask; > + } else if (attr->transfer) { > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ITEM, item, > + "extended metadata feature " > + "should be enabled when " > + "meta item is requested " > + "with e-switch mode "); > } > if (!mask) > mask =3D &rte_flow_item_meta_mask; > -- > 2.21.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh