From: Raslan Darawsheh <rasland@mellanox.com>
To: Michael Baum <michaelba@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin splitter
Date: Wed, 22 Jul 2020 15:30:49 +0000 [thread overview]
Message-ID: <AM0PR05MB67079EBB86A435AF5108D9BBC2790@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1595332804-6860-1-git-send-email-michaelba@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum
> Sent: Tuesday, July 21, 2020 3:00 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin
> splitter
>
> The flow_hairpin_split function defines a pointer called addr that
> points to the list of items.
> When the function wants to progress in the list, it adds the size of an
> item to the pointer.
>
> At the end of the function, it precedes the pointer one more time even
> though it is not used afterwards. In fact, this line is unaffected and
> the operation of the function would have been no different without it.
>
> Remove the line where the pointer is preceded unnecessarily.
>
> Fixes: d85c7b5ea59f ("net/mlx5: split hairpin flows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index aba8f41..cf7052b 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -3518,7 +3518,6 @@ struct mlx5_flow_tunnel_info {
> tag_item->data = UINT32_MAX;
> tag_item->id = UINT16_MAX;
> item->mask = tag_item;
> - addr += sizeof(struct mlx5_rte_flow_item_tag);
> item->last = NULL;
> item++;
> item->type = RTE_FLOW_ITEM_TYPE_END;
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-07-22 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 12:00 [dpdk-stable] " Michael Baum
2020-07-22 15:30 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB67079EBB86A435AF5108D9BBC2790@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=michaelba@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).