From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44893A0526 for ; Wed, 22 Jul 2020 17:31:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F0C91C00F; Wed, 22 Jul 2020 17:31:01 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2064.outbound.protection.outlook.com [40.107.22.64]) by dpdk.org (Postfix) with ESMTP id 1C4141BFE7; Wed, 22 Jul 2020 17:30:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etY0C8apgI7Sebfi/u/0oO/DePMoj6BRxnmNPKwKzlAFxY8BUbNirtOGce9Yw52JBrzIBE2Ph28FAzigbo5IUCNCLIFJF+RdgBTgU45Ano+qtQ/cfvUDNYsRCSj6r+2QfyL73fb9E/8tmhLQNaVALZp20bSAbkR1QFPYczPGxyRZo3wa1Tem0uelx3O88Y8xnSugXxbKvkQE97MHHMIsoPSQmz4k98iyGa3mPaWxNqsTrB9MJhPrviZZ+idUADkYFSEA2Nh0iZMvYjyHtqUEfckh7ewD2emHYZhi4WjItMl7EncrjLJkkZ64yIucHJdgmzcezEBPnb6ZD9LlvtQh7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RMEDb7BUwgeVz+HeQMOqEYgTVpcTrRzwx7sFo3SZXNg=; b=Quy+2hKSQhqsYzMxemiRdtT5zpMzTTb89qiFb9gKAyNvGIqFqp5hYjH9HqRGGqA10JlDKUIffghEzj0VMk4G66UW2Reg2CuojXmR4HKRYpVaOmmouLiEV9qoMd9EBJRUIO2NjT8z/8KSo8YmQ0CZaHR9CLfQ23HAEFjYN1l5wh6BHmk3ho5tyuDipJfvdQEuTI09ERnuyFiNXM+fmj9FxDVuXFQz7kf9z0R3c7DAx74r6ZD6x7ZkyrvngdbpCKgR/1A03J01/LjSXrbDmy07mNKLrzHbbA7tKS25PnUT/fBmf9RLPG6GI8O3p0mSfosS6ATY4QG1lgd7mixB/lz58Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RMEDb7BUwgeVz+HeQMOqEYgTVpcTrRzwx7sFo3SZXNg=; b=WKigE1WUAIdmQnqBONHpSXhiAdGtBPtvqWZ84ZG5jBHKdeKCTZSbYAyEs+TVDkXHD/otSMfZPWPC+Sv0XH5PWK4rB6jXGMbrNTAgF5QYsqWItyJiYVcrVwyM3QfqnWE7u9UqgcHzJVT4U1FMvvCoucyXXXoaPME7K7UFGVHPMXw= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul 2020 15:30:51 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020 15:30:51 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK action conversion Thread-Index: AQHWX1ciE82yOT9zC0yy6mLpXSoPrqkTuxDA Date: Wed, 22 Jul 2020 15:30:51 +0000 Message-ID: References: <1595333077-7179-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1595333077-7179-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 72a3f495-6242-4b88-9ce5-08d82e543774 x-ms-traffictypediagnostic: AM0PR05MB4401: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KryNu8UrzlbKHtM6OR775e2jf07RXs9rKygeWqCfExKlxKkxZDBKjpfcY0jjXB1Fz51KBIQQaB4dYCa/vMdZd4YKnbzDyYwJO2Ww20OQ4yOepS4Z+sDh8K1Q1ivdTYRt20iFfzq7O6Xth0oyCwMwe+mAdMkOVPSVR9rv4OhoJ4AnUY18p/b5ZRdLARgqJuT9LF/humVufJjpb1dYz1fSzAfaSdDqT5a0Gy+nyLmuTTrStWD4Daj4aJEsLTIDwr93zMk2OUPd01N1ONtgTL5SoH6M+8rR6ny82vJRpifeONCKvUiuyDL95J/ropLAQaFS4dF4wEG1UAYkoOE2Sfdu5w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(6506007)(26005)(4326008)(7696005)(53546011)(450100002)(478600001)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ErxrHo4d6MJlBg+xlo3Ri3JvOzmhxy+Z0WURdu385WtCaNJl8aThAXVCYKm/ZdoPNjzEflfIGXIOdHZ18KM7Ffi3o+ix7/xDRaDDm9Qp/yyT1kAIr3Mlx0tiHyKQq4m4saGBqUiY3XRbPuVn0aJYaRfh6AnfhJcnRhLTB8X58hGGlKKK8wF/Y+zy/ZUhd3laT7sMmUE8QTP9z2IDiNhMQxb5Jz5n3d9aLbtTvEmAzkp5OLx1d/D+V0hQJeIZxfVaxyfotkU+mj10jTgRjE2H8SuJ126DwAqPrfCTfmuXpFQkC8cCLzWlDLGJ1bmHr9A9FRfs7Uz4TDIShQduJDQb1DGi5JVIqBpnX/RziErTy2BM/KT6XHsTH6A/Rdq385SbfKajWeJiSnWpw6i8QTWHajvST3kM3TaxbW1iHdZLft/OZTsXbmSyQUHWyA3wIZaWxe0xBzII/jLPvQRt12DRZX31tIgBF3d8dF1vB4x1xOMygM6glxH06WkfdSeJLRCM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72a3f495-6242-4b88-9ce5-08d82e543774 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 15:30:51.4618 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 706IEQTQlKx9Nh6HKNztmEJe1VC8ZnebYcH5Vc6QErQAocHQnqDv29Wup4fJ85HZm9cGn6+7attGRT8BjhFnqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4401 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK action conversion X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:05 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK action > conversion >=20 > The flow_dv_convert_action_mark function defines an array of > field_modify_info structures and initializes the first entity. >=20 > In the first entity id field, it initializes to 0, even though its type > is an enum that has no value of 0. > In fact, the function does not use this id field before assigning the > appropriate register id into it, so the initialization is unnecessary. > Moreover, this initialization is int into enum, and it would be better > not to create a type conflict for no reason. >=20 > Wait for the first entity initialization until the appropriate register > id is already known. >=20 > Fixes: 55deee1715f0 ("net/mlx5: extend flow mark support") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow_dv.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index caeafd9..0f258b4 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1151,8 +1151,7 @@ struct field_modify_info modify_tcp[] =3D { > .mask =3D &mask, > }; > struct field_modify_info reg_c_x[] =3D { > - {4, 0, 0}, /* dynamic instead of > MLX5_MODI_META_REG_C_1. */ > - {0, 0, 0}, > + [1] =3D {0, 0, 0}, > }; > int reg; >=20 > @@ -1172,7 +1171,7 @@ struct field_modify_info modify_tcp[] =3D { > mask =3D rte_cpu_to_be_32(mask) & msk_c0; > mask =3D rte_cpu_to_be_32(mask << shl_c0); > } > - reg_c_x[0].id =3D reg_to_field[reg]; > + reg_c_x[0] =3D (struct field_modify_info){4, 0, reg_to_field[reg]}; > return flow_dv_convert_modify_action(&item, reg_c_x, NULL, > resource, > MLX5_MODIFICATION_TYPE_SET, > error); > } > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh