From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85039A04A3 for ; Tue, 16 Jun 2020 10:02:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5150D1BDFD; Tue, 16 Jun 2020 10:02:44 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) by dpdk.org (Postfix) with ESMTP id 53FF531FC; Tue, 16 Jun 2020 10:02:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KsDbm1Mb9OCq31sKqMH/3xH+wU7/7vOnNaPC6Yh4ZaN0oz10qXX1MGnLnucxFZuIvXVYHu/lNptU25lYm7F+aeV0HvsNng5VOOpmIocUZN/FNmUWOQvJ4tYNkLKltoA8sZRzrdjvaq1g/BRF2sOzwZFZqWX3dJjC3L3Vk20poyAwLhcQfFP50vu2ikxsryxe0XnlgEZ7CcjV4QGJyqDDZFBnHPMyXxBYDyO5VLPsO+4l58+V7rR1SdIkZu5ot/1Ta+aCO1EL3EAipuOOut2SduzbYnRPT9hKLOlzqCrm/OEcosAfAkRxZs2rJaekWiBuI34Wwe+bwME00dhymKzwTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rlTOuwo8myD9eCMNhmmhAJcLdQnUEssnogb51V0Yh9I=; b=DNz/wWwGd+5/BpLKoOUENqx3RkwTo5BRjX5YRXuwolIwvEx2TdNNDjLLkWXy2wFGTxPQ4mF+0NghvheWjUi1PvQI18cuhyDSYF/mbv/uAnnqzaQIGw3XJo5pkJ2xog5I0fXtOZ3ip9SkYyzhMWGpGg5/1BQH/OtsuGLrlxXP+7r/Q+6AD8wVy/5ADIr4yjP80SnLLBwkEJTYSW4iLxIyfQqSCXUYOHtFskvi+TW2RSQ2KQJXupGJYkG/9L6Y4TAdkD0QzWcIlzzIJ3LSaM1dA8Z3OQtcxWDdJVV9zmO1QAhMaF7vOqW7aDKH8kYVTWx7OH6or6ielGl92cdhqpsjIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rlTOuwo8myD9eCMNhmmhAJcLdQnUEssnogb51V0Yh9I=; b=V1VKLKrZSnTDv1mHtyKLVYKZ7+IAr9lEN2+9DuDd7mFtMAAIlpB3XzTFQle0qN+t6Oeh6nYnSomYhYnMKffxX/xoDF+lABaF1QeS65nKsUSaHhVKdAG51812SU4lLBnYVNndXteB6E7GqIq0gjTNKw5V2V4dGvVxAn8/ujc0ysA= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4468.eurprd05.prod.outlook.com (2603:10a6:208:5c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Tue, 16 Jun 2020 08:02:39 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3088.029; Tue, 16 Jun 2020 08:02:39 +0000 From: Raslan Darawsheh To: Bill Zhou , "dev@dpdk.org" CC: "stable@dpdk.org" , Matan Azrad Thread-Topic: [PATCH] net/mlx5: fix LRO checksum completence Thread-Index: AQHWQJeOfbWBKJ0FDEWJEpVLXf4ijKja5qNQ Date: Tue, 16 Jun 2020 08:02:39 +0000 Message-ID: References: <20200612085746.21139-1-dongz@mellanox.com> In-Reply-To: <20200612085746.21139-1-dongz@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 46b475b3-fe34-47e1-abc8-08d811cba3d8 x-ms-traffictypediagnostic: AM0PR05MB4468: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 04362AC73B x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o/47Yns4xnFXvg+lvKxUeBbbFq7ShMgHE95YRjum/8mcxANOzmtaL7rDO9E7tCnkTRqMKehnwRFxfEfrfHdm+oPNZNXcYroMZbPz2yFxu1KBImmQShMda6bK6IdLCBpGDZC9nlRUOL+x+Kwdwi39oJHEEeKaQe4lC5NZbfELFPv3nPjunHE/ATvD0n5dA5k1O6679K+zXBlVuCd8Zy5hNcl6MFtfkWAprVqdOzw3LHu2JKDELI26eR+g3/zWACAVcG/Jfhp5qNASEWag8UwhOpE3z58rlwZZyGQTyVNfUnAE6bofb26HJlEALVMQXLUXbbeD4pKYzWHDujqPRxKH8A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(39860400002)(376002)(346002)(136003)(5660300002)(8676002)(186003)(450100002)(52536014)(8936002)(53546011)(478600001)(26005)(2906002)(4326008)(83380400001)(107886003)(9686003)(316002)(33656002)(55016002)(6506007)(66946007)(66476007)(110136005)(64756008)(54906003)(66556008)(66446008)(7696005)(71200400001)(86362001)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: +It+D5pIt79axWeVYIzDI9Xif258qPINBhTd+pMj/tlj21ZIZ5RFNOOiR7n255KamKQMJkzSTq+LnT+/aiCKsIfHOJqBC4tT5cXAHRKtQBW9FGpWQOOk8LtSpDms1DPXX1H7cmlnWeF+ah5GKfEGmZ3MBZTcvx9wlCdLrE241nC3HPHk5h4Ci/VyS8NOBGuld/q4ZTcCIFHhrsf0mj82bEZCR75q4zVqA9RuQOcVZdLv5Yqop4V8VtnsXVLpkw82h/U4weHWsnVNEtcWCR+J104ZVLhmfbNc0QM0XCdERJaDHDYP8916C0g2L6kjEHGp8V7t8dvhSTW1enMUf8HK+T97oTOsnFUwSp7GB4fIiE+E27dWk4TRVjx3E5HOhi5mMBWHpp41E40ZwhzzNly5KfBxhzcwUK5KfbR5HvRaA+wKb3yOcTyUq3MOYv6JeZa1+pa8TAx7z9uXrmElmXSBdfKC86x7E+M+uafD9iSjA5A= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46b475b3-fe34-47e1-abc8-08d811cba3d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2020 08:02:39.6251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oXcl+NCa8vbanvdEqAPG+wTXJ7kuEC1mXjBzK+dujzTXKWAP7G/q1asdYWcqu+YoWZFf3erowMwmmDpZemkEYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4468 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix LRO checksum completence X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Bill Zhou > Sent: Friday, June 12, 2020 11:58 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Matan > Azrad > Subject: [PATCH] net/mlx5: fix LRO checksum completence >=20 > The TCP checksum includes IPV4 pseudo-header checksum and L3 > payload checksum which include TCP header and TCP payload. > When mlx5 LRO is enabled, HW will calculate the TCP payload > checksum, PMD need complete the IPV4 pseudo-header checksum > and the TCP header checksum. >=20 > The mlx5_lro_update_tcp_hdr function completes the TCP header > checksum, but this function using lower 4 bits of data-offset > field in TCP header to get the whole TCP header length, this > will cause TCP header checksum wrong calculation. >=20 > Update the code using higher 4 bits of data-offset field > instead of lower 4 bits. >=20 > Fixes: e4c2a16eb1de ("net/mlx5: handle LRO packets in Rx queue") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bill Zhou > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 6a17a9a5d0..e4c1c95b0e 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1529,7 +1529,7 @@ mlx5_lro_update_tcp_hdr(struct rte_tcp_hdr > *restrict tcp, > if (cqe->lro_tcppsh_abort_dupack & MLX5_CQE_LRO_PUSH_MASK) > tcp->tcp_flags |=3D RTE_TCP_PSH_FLAG; > tcp->cksum =3D 0; > - csum +=3D rte_raw_cksum(tcp, (tcp->data_off & 0xF) * 4); > + csum +=3D rte_raw_cksum(tcp, (tcp->data_off >> 4) * 4); > csum =3D ((csum & 0xffff0000) >> 16) + (csum & 0xffff); > csum =3D (~csum) & 0xffff; > if (csum =3D=3D 0) > -- > 2.21.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh