From: Raslan Darawsheh <rasland@mellanox.com>
To: Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix flow match on GRE key
Date: Wed, 19 Feb 2020 13:07:01 +0000 [thread overview]
Message-ID: <AM0PR05MB6707CC9A25E5EC06882176FFC2100@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1582037120-11735-1-git-send-email-matan@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Tuesday, February 18, 2020 4:45 PM
> To: dev@dpdk.org
> Cc: Slava Ovsiienko <viacheslavo@mellanox.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow match on GRE key
>
> The RTE_FLOW_ITEM_TYPE_GRE_KEY means that GRE key should
> be present on the flow and in addition can explicitly match on the GRE
> key field itself.
>
> When no value is set in this item any GRE key should match the flow.
>
> The match on GRE key wrongly was not added if the item fields are NULL
> while at least the GRE key should be present in the flow.
>
> Add the GRE key present match when RTE_FLOW_ITEM_TYPE_GRE_KEY is in
> the flow item list.
>
> Fixes: a7a0365565a4 ("net/mlx5: match GRE key and present bits")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Ori Kam <orika@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index a8c8a58..402250e 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -5593,13 +5593,13 @@ struct field_modify_info modify_tcp[] = {
> void *misc_v = MLX5_ADDR_OF(fte_match_param, key,
> misc_parameters);
> rte_be32_t gre_key_default_mask = RTE_BE32(UINT32_MAX);
>
> + /* GRE K bit must be on and should already be validated */
> + MLX5_SET(fte_match_set_misc, misc_m, gre_k_present, 1);
> + MLX5_SET(fte_match_set_misc, misc_v, gre_k_present, 1);
> if (!key_v)
> return;
> if (!key_m)
> key_m = &gre_key_default_mask;
> - /* GRE K bit must be on and should already be validated */
> - MLX5_SET(fte_match_set_misc, misc_m, gre_k_present, 1);
> - MLX5_SET(fte_match_set_misc, misc_v, gre_k_present, 1);
> MLX5_SET(fte_match_set_misc, misc_m, gre_key_h,
> rte_be_to_cpu_32(*key_m) >> 8);
> MLX5_SET(fte_match_set_misc, misc_v, gre_key_h,
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-02-19 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 14:45 [dpdk-stable] " Matan Azrad
2020-02-19 13:07 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707CC9A25E5EC06882176FFC2100@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).