From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37EA4A0526 for ; Wed, 22 Jul 2020 17:31:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 858821C031; Wed, 22 Jul 2020 17:30:58 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2049.outbound.protection.outlook.com [40.107.20.49]) by dpdk.org (Postfix) with ESMTP id 203491BFE4; Wed, 22 Jul 2020 17:30:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nqe61kemPh/JrJ9yKjz3+h8IT5BE6xYvc1FMtfwh0sA+U17ABs8EjNuf4c1RVCjfmHXYME1kYeTNwcaRkLcq9CiwlFW9Rm1a+zJ63UIXu1ASD8x8wTDt2meTkZt7TxscuA3LlQX1suJp+2pLtrSppNISd9qDW7hXaLaHc+1X9uKd56YIQaHlb63mJoPZjhQVYe3xXd+OkEa57lamy0o6ijGLW+G+17n7ZODtBkYqiQ5YVlvxIh8cwqvbe14J7z0DLNZWw3Xc+SXQi1G7UIgeJ8Q5nGKfOc5UGl5ilnYLcTiCym7yCa09lDrM44XXnqERWrFpkqymURLpAEyPAAa+6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iPhK5NBG+5CLZkX8weCU2Pqy3h7BjFA0RRrfqtF77Go=; b=fs1HPd1D/s9od2Hk1nZ7TxAv5agGqKPu9jQMh/mfqaC4ulxAFfkUqgVPEStuCeXIOuEcOwnGXsAI1aZQ7PVi0OhMo5BCLVXL0HfmgvKBQKDdTk8F31WYhwqkTeo+d4Nx2IlNP6r8FXCcI0TSTi0nl0n/h2qQ1xtRnWeNGBBXcfjevjDSxx3mbxLROkuyLjmEaVS46YBS9DFcVRkYqXJHw9yXHUxspOztn8Rl0ux95HdXZDyMsBXmYeEWt+YDxA3Qt8jKOXN7ebBdg29VqOH2wagR/XCq3iIvvz3PJ9nOpF+daGgb59A5XlOHxP+/CTpybkJgXMZVe8KGGyf6Rau9Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iPhK5NBG+5CLZkX8weCU2Pqy3h7BjFA0RRrfqtF77Go=; b=sBmYJXPrKmh4FJeccRrD6BrUQcZDELQ9lgbKFjvyvYYs8ffOjCKS7P99PonuX94Iyrq63BDiCr+uqKoX7zRbVI3RH2xUfPCitPXO7gut+O0C+6jMe9TRE+5IIDH9DOKGE/FDmJQw07Oa/rmgRY8NDsi4qpkDvBEza4rufK4GDik= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul 2020 15:30:50 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020 15:30:50 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch info detection Thread-Index: AQHWX1bYKTyPlYeIs060NgxHGmhxz6kTuvEw Date: Wed, 22 Jul 2020 15:30:50 +0000 Message-ID: References: <1595332952-7035-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1595332952-7035-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 32e12a6b-8acd-4c79-1e5a-08d82e5436bb x-ms-traffictypediagnostic: AM0PR05MB4401: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:883; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zCqNo2CS4/XaCNXxxjAo10RDCQqKnIqJjk9u/xmejDfR4B/jvqdy9JFGW+63brfrsG6JETUPzj6CF2MzqfOd0btli00t+CfchbVm1JWfxwZUg07EYZwOrqiIS2MmWayJHYg6sJwTIW0DsPhqIGkNYvNdh1aKSuA19lt4GMRemgSfRSQXEL14/jYNl6VMGfOTUtYschTj23YpoecIJxdSb1r6ctVKBw70D5q+uTFxZZfkjVZomUMMihBCpZM0s+5xNegOrtm9j6YzO3WWFlBdVmNTTHDNbZCVpV0+D4LsEcgh/J2N53kyVX89ngXdC0A5y+hz0mDmGWXaGmjw1EWzOQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(6506007)(26005)(4326008)(7696005)(53546011)(450100002)(478600001)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: sbZF9WRNXuu3Ey1QWCh5KSkXlfKwQn1sRLYZix06FCR7cXs74E8VExYzIjNrO+sf8xe3k/DDn+D7x3Uovp+SXffYLXvMAc1RkzLSZ5XjFG5U1vi2y9BX6sOlJ3x8WfFeCYR/bDCU0xzonRmXwe27Y4Yqtq8KGfc9LF0xrMbnOsBCcdp+Ld3dNFao09qdexAbGV8ykoxusJSZEgw9K2fPBLQaLCa6mBEg+4Gzad1+6eI3NY7uxk4hDZIFANeFj0Hawkpaddpkb9G0HMH2RmZdwIppSmi/9c5X+1WX93NrixTTGsq3Vp+2EJHFyXR3Wn/VF9Ak7/CuIQFFAW4UOo+BTAcsZYv4qKFjvWN760/CLcKC/71P2g2UVvpLM/Rxy/CO0ddkEbWzjmWI2AdDEI+se8KMibrxWWU/ra1iL5ACqIOnxfO8aRHVaaE+pisoH3oTDAAmCeL/TXRBqucG1ZU3+1HPJl9ceRJQZOeAXaA+dFVckxm5I+5BCl7OJK6tUdwe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32e12a6b-8acd-4c79-1e5a-08d82e5436bb X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 15:30:50.2252 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cwsBYG12XSAEJ56dcSlb3zhVA4EWtnjy59G8zmFafEwgusYqqVKJAzWWW9kfpS+KsJs7oNJAYz0QOuWAt3u7ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4401 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch info detection X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:03 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch info > detection >=20 > In mlx5_sysfs_switch_info function, the driver gets switch information > associated with network interface. >=20 > The driver writes the port name into buffer and translates it. > However, when it writes the name, it does not limit writing to the > buffer size. >=20 > Limit writing to the size of the buffer. >=20 > Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c > b/drivers/net/mlx5/linux/mlx5_ethdev_os.c > index 1735157..3d3dd2e 100644 > --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c > +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c > @@ -1067,7 +1067,7 @@ struct ethtool_link_settings { >=20 > file =3D fopen(phys_port_name, "rb"); > if (file !=3D NULL) { > - ret =3D fscanf(file, "%s", port_name); > + ret =3D fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", > port_name); > fclose(file); > if (ret =3D=3D 1) > mlx5_translate_port_name(port_name, &data); > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh