From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF212A0527 for ; Wed, 22 Jul 2020 17:30:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A8121BFE7; Wed, 22 Jul 2020 17:30:52 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50072.outbound.protection.outlook.com [40.107.5.72]) by dpdk.org (Postfix) with ESMTP id 58B882C6E; Wed, 22 Jul 2020 17:30:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QsKm7ZBnsQGXiRSmrJnAK7NltKASpSVWB2UFgkMg5sIuqCYLdwBLXxlRFAcpg8269Oqj2sRC4c9G/9KiW8apD8yNXW3iviTMJMCtsHEOSKXtPNe7HI9wmLb5YhbSMqHv6X/BqHAfxSKJaxk7kE4ehhMugs5owmJzqb0ChTvOjuDdqZKA+PAwAHWEZGuN09lAfRBH24xMkJEdKbwAbz8GpYPR4ppXtgEKZsdemehQoIiKCtN1Pljs+tc8JgoJQtp1eolLM+OdUuYYWGu0cKpqnU48rGrzv5uoMF4vxuFn4VLB3T3+FnBlyIfy2iW/E4TGMgIWSeNHa8ySBOtCMVYZ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N0zpD7NY8S8yk7RdFdqMzU9DSArb6Zf7QRl3egd/UOQ=; b=Q6aF2phWNT1QnsInc4toIJn02PYZq9wOYSH72fBxPr6ssnlGhaenPXEmeQmSzPKnNNZ4M6IDQ1jmDptG1wLdw8mii7TdqlzT9P3tmDBJxAhr90Ite+Z+Liu+DVdM286gaINqPCu707gy2VeP2GQBO/p5HAgbBKUDBEiq/asnld7/UzepoT9ze9sMQa2XOQ+sJPX3jvbYf0knDZs8tYUTH8ezbvz3byl8VZvFY0YW/w9M3VTUGwcdDFyQNENFDEmeAQP18TczgigvkNwjURX0EWoUMAKkszUunkTntlaBN+kZP4qtTqzimfMIm83YfPoWjoRuDI+MTjno8nBQDc+k4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N0zpD7NY8S8yk7RdFdqMzU9DSArb6Zf7QRl3egd/UOQ=; b=tqX/tyX3IDHMp4s60XafvKu9P9MiQKVgTw2eCbwciRA0lz2/QqDoVPeUc+r1OxNtURdrKrW8obs3FtWfKdqXDlBX5pxKZknfXA0R1veYx3FwC9qd9waalPyoRp1+Ad3YRwTj73kAg7aBozARYDGpjtq5VLU1o3Zo5MEWITGa06w= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul 2020 15:30:47 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020 15:30:47 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix enum misusing for steering registers Thread-Index: AQHWX1Yjd1BpF2Z8WUSo7M8JxU1t8akTuqeA Date: Wed, 22 Jul 2020 15:30:47 +0000 Message-ID: References: <1595332641-6144-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1595332641-6144-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bbd1a0b6-1463-4194-3842-08d82e5434f8 x-ms-traffictypediagnostic: AM0PR05MB4401: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fsJDdQVA4gpJES7RrSEUy4B447Bz16ID3i72HGxjOfM1DaoYK0H2eugk6qBM+Y+C4BjHIiwpGt3+dQkeXOV+d+qpUL02MZyL6xKmyPym+qkulMypyejhzD6BpV6VHaVYFBtYi0Mwintpjhq3B7OSe4kaURWxpnBoEOR+bFAjYU1PfjgvkIHx9JtLYobOQ9XYs6Tw+7SJXPywzMvE7PZzALvX67o2NIPZW2w+LX1DEpNnJ7OketdApHZjcv2tuPJeySphkYEJgETrdlFiSXl5QFF9CJNRz4bkIO/Vstl/TauFCssN5irtUD+/+XybWphE53rB3X8gBmK4H/mlScejuQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(6506007)(26005)(4326008)(7696005)(53546011)(450100002)(478600001)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: K2YF3i5be9sFdWGoDSWXuEDDsJ+pOdyzokMEEycgLmDeU5A2dZBLWkNKW5jrrmYEDUfgXcxZOhje3wug7+gj5YGT2yAcN/b5/O6QaAbon2JFq6+fmtqip3//b62okUzJTBHfUOrKPGoi57RUqRyL0RQPg44f3w5WPY25ZBqTmPpWA3jZdcDHb091Z8XriJhwMyYUVCxJADy1pLgNSdbsNOPzG4U5Daite4huKNNllCTdqyyCaJ/iTg70pR6zKJg/jonJr3ViNmGNZMhz0U2bS+OJ8ybCM1KtEOId0514X2q75YJDHvfSkKgZLodkxyEQMVJcYmLhWysVzuNn037ibjRQV3COLHDK5i/2XHZVLil7F6W+pmgcvttLq4MaLgF/549NwQJwFXBc7WoD1RghEhzSvlIOEd1YoWAaLweW3LkriGJnOg3zFtOlqIo4Iwon6rm0l1eb1mP/mcP4mRkhlXihYJnfv1s6K5nzB8cCHIs77i8KrKxe3dJRu2137PXx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbd1a0b6-1463-4194-3842-08d82e5434f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 15:30:47.2523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: olic+OdRdM7ZVhLOvIjOUPk2r/0DACctcILI5DKDfBiqatMzAMpvRwKg58xpMUBH5tsy3QrkVjIPZ/Xy8yHMGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4401 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix enum misusing for steering registers X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 2:57 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix enum misusing for steering > registers >=20 > The mlx5_flow_action_copy_mreg structure contains a field called src > type enum modify_reg, similarly the mlx5_rte_flow_item_tag field > contains a field called id type enum modify_reg. > The enum modify_reg variable represents different registers in the > system and it also has a field called REG_NONE whose value is 0 which > means that the register does not exist. >=20 > The flow_mreg_add_copy_action function sets a variable of struct > mlx5_flow_action_copy_mreg type, and initializes the src field to be 0. > similarly the flow_create_split_metadata function sets a variable of > struct mlx5_rte_flow_item_tag type and initializes the id field to be 0. > In both functions, they initialize a enum modify_reg type variable with > an int type value while modify_reg has an appropriate field for that > value (REG_NONE). >=20 > Replace assigning 0 with REG_NONE in both functions. >=20 > Fixes: dd3c774f6ffb ("net/mlx5: add metadata register copy table") > Fixes: 71e254bc0294 ("net/mlx5: split Rx flows to provide metadata copy") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index b56bee4..aba8f41 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -3011,7 +3011,7 @@ struct mlx5_flow_tunnel_info { > }; > struct mlx5_flow_action_copy_mreg cp_mreg =3D { > .dst =3D REG_B, > - .src =3D 0, > + .src =3D REG_NONE, > }; > struct rte_flow_action_jump jump =3D { > .group =3D MLX5_FLOW_MREG_ACT_TABLE_GROUP, > @@ -4067,7 +4067,7 @@ struct mlx5_flow_tunnel_info { > /* Internal PMD action to set register. */ > struct mlx5_rte_flow_item_tag q_tag_spec =3D { > .data =3D qrss_id, > - .id =3D 0, > + .id =3D REG_NONE, > }; > struct rte_flow_item q_items[] =3D { > { > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh