From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 299E7A04A3 for ; Mon, 15 Jun 2020 10:51:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E607D4C90; Mon, 15 Jun 2020 10:51:37 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) by dpdk.org (Postfix) with ESMTP id 491AF2B87; Mon, 15 Jun 2020 10:51:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItDRgMTFtUftRybc5U2Z+irNDEAnt6tUOeGo7J1T+tqCK/lRr3oPXgdh1e3F1+Ogj9O9+jB1rlKW/61JjhusQXeq/8S7AhMR/wfULBz3exeVHvF4wHTYdHnWjIATQJcEW6QuHrXrEagwiNjWOsXqoDlfKgEiM1iR6R0RB25smSZ+nLmPGnLyOhJMgd2QH4K6NLpFiuFnXHKT78g8NVNQUVWMyGQjTUe0gMY4jg4ZrjGdlJFxLgHdR5YcyirpXuJGluvmKnM9fQOrXE56oVAJTLSFAISPrnHEqBSq7MaKR67C9iVFhEsu1m0l3K/4Ks+UUxnw2D0Ibv3dTxATwQUhHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4zQQgppT5+M2yt8qp9BUmiX7q+VsEPcxYBP9sQV2sjo=; b=XLigVs73MX9GEj9xmXo7oRofwxwMsB5+FXuKcCJHsfMYCkvK4Ck7ol6IY/M6La+foSUXuBwfcVrEi57+hFacgvE28BG2GA+qgDIwUANZHqnil4dYEg5Yw/J5PEaBiJNIhfFr9cqKnMpoUjIUaL8fTjXAA63MU1z4MmRURzgFwiwJIEYFYBDprm5lV+G5AYqO0/wMMLOSkSxuSLhFGK7N7kx6+s8Swx5hJVkH6WXG1ti2tZhZwE9Net2gfb6Fvvwp/CTG24s8QZRQnb2FGkog12CzCTG8HWV/A8URVI4lqqYXPTts8t0mF50E0YLvdUBTI9m6727HFURs+izSDXm7JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4zQQgppT5+M2yt8qp9BUmiX7q+VsEPcxYBP9sQV2sjo=; b=WUhvFshlJiifkRgj0h+Pj4yqspC+DUT0WIFy6qGGrZDB20GacHo9aheLZ2h85pZN6qxk0/Myev9S7i/szAas0WAW7L60F6nAjIRDLLg+qtCVrGiHx8PICdZfJtGpagCE24tiZ8bzTu82X1/LEb73/HWkQTzekArEUWZ2Rl14H5w= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5137.eurprd05.prod.outlook.com (2603:10a6:208:e9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.24; Mon, 15 Jun 2020 08:51:32 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3088.029; Mon, 15 Jun 2020 08:51:32 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko Thread-Topic: [PATCH] net/mlx5: do not select legacy MPW implicitly Thread-Index: AQHWQBfCA6K+cqxLIUC7ogtsZst9h6jZY7Xg Date: Mon, 15 Jun 2020 08:51:32 +0000 Message-ID: References: <1591897320-15192-1-git-send-email-akozyrev@mellanox.com> In-Reply-To: <1591897320-15192-1-git-send-email-akozyrev@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ed936d06-5607-4205-1cf5-08d811094dbc x-ms-traffictypediagnostic: AM0PR05MB5137: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 04359FAD81 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cA0T0FSwHnGL6/6rqF1AS6J8BKUle8y+uISRyFMGZ6GBfbR8dNrTV+Ftwj6GXcZxiWj1MPRVU7iK9ZWL0MR0kQP9Oz4lyU1HRFvRl7LT/rzO//p+L/SMr/S3mM2pgsUnIA27MSZNNeW9kUAgbP6bzy4PvKPUE4OClTEhGrCSM3R6IV/n2NmmWXIIbzDjhUjBaLM2jv5Ltrpk1Mtwxlf6WdCeV+Iey/lZ4Ix4knHGZh8RGcBbdO3K9I7Z8ptC1BOS09h6RSEtMJnHFxo6k7zot636sKAMA3oR2c6BhA2nk4ZYJGPPy79V7yVnOlFkTPi/ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(366004)(39860400002)(346002)(396003)(316002)(478600001)(4326008)(53546011)(76116006)(450100002)(7696005)(9686003)(66946007)(66476007)(66556008)(33656002)(64756008)(107886003)(66446008)(6506007)(110136005)(54906003)(8676002)(52536014)(2906002)(186003)(8936002)(26005)(55016002)(83380400001)(86362001)(5660300002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: sQH2MS2ThRs21r4UHxnNpoHswqGrDG/zrGhYQPVvn+3/wgLBzJnu3lMCNrHaXJND36Kn8H1NeyV7BNZ9s8iMT8jba44RX2cTm8N6jefR8Gp45Yo6HWZsv8EwsnPhSNRxs5oTu8Qn/YvnfUsNJ6/g3/1JTZ8F8V4v5+MRP8inula+RbmHeCkoXxJVPBdM8LJDLULRuZCbYxkDg5y8wT4M9szPymeBL5G52WVb2zI5TAkiQFjz7UFB9S/KW2mGmTMH09Pe8hWAQLSeFhRA+Y2O1QnLQWTisr9iaKOCgI33q2lXTOdmhK7FvARKJ2NsghGCjvMORauNR4Qwo7Q5nFL0GISQYLTmEzOJxT/DCtzg76vlT7V62eWlNQvmqaUjy5inXELgZsQU/b0tnDCI+x8BacQCNwmy59ALH+B+nzsxl+QPFJ8G4yLOD0rm0CjkSLP9yy7h0ZWRHb7QJsO/McSpkytWI+niwQ5CjtAWmE4IBa1dmB59Z4Pr8rPS5ZcA9yGV Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed936d06-5607-4205-1cf5-08d811094dbc X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2020 08:51:32.8998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3QONZl1/QCbGzVtY95JZyeHYOaXHNPAKZElaE9EikpeN9N+9KYVBQpS56wUf+Fza7Eb/0UTQXmYnwRX+ltTB5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5137 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: do not select legacy MPW implicitly X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Thursday, June 11, 2020 8:42 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: do not select legacy MPW implicitly >=20 > The Legacy MPW (multi-packet write) should not be engaged implicitly. > We should exclude this function form a Tx burst routine selection process > unless it is requested specifically by setting the txq_mpw_en devarg. > Exclude this function from the selection process the same way it is done > for the Enhanced MPW in the mlx5_select_tx_function() routine. >=20 > Fixes: eb8121ab9dac ("net/mlx5: introduce Tx burst routine template") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > --- > drivers/net/mlx5/mlx5_rxtx.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 6a17a9a..df58af5 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -5542,6 +5542,9 @@ enum mlx5_txcmp_code { > /* Does not meet requested offloads at all. */ > continue; > } > + if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_MPW) > + /* Do not enable legacy MPW if not configured. */ > + continue; > if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_EMPW) > /* Do not enable eMPW if not configured. */ > continue; > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh