From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1E33A0527 for ; Wed, 22 Jul 2020 11:17:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95C541BFF9; Wed, 22 Jul 2020 11:17:23 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30085.outbound.protection.outlook.com [40.107.3.85]) by dpdk.org (Postfix) with ESMTP id BC0541BE90; Wed, 22 Jul 2020 11:17:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ijTQXcbzgr1+csy+S4rZcVBBxGK/skId0A3AHdl403jrUdN8M4RyWOqxK+VHDHHEoDV17dBr1C2PfFO1JhLKF16pRVBKGdiLmu8LaIMQMmeB3WP6S6fUgte3cPqBoZVfYfm/yizUG9R/PCDVvb9S6wzawFuf9O81WlOBqMbjVf9TuedhPlmlOkm8ixhWXXIMeXC4H7ffEIQBWZ61ACoTJr1ejhlcKc+mkkS3+yoLHswu6jx9SVOwULGPxaGfnJKxZ95vUAcfmdK5Fk1ABQN6qtA42S/MCIwnccs8Fd8fUT8oKXFfYCe00pezYxbosZ2ytwp7X5k+8+4P+g5lfPDTJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJYChS4gx4BGfX2xNrZcaUhCwf8e8zopAMqleH4j1Js=; b=IxsVL53TlQQt3/itpZfvbdDFrfLA1Ua6rDzzq3OccD5hIOFup1ePGvlohyNAHoG5QHzNEnJQCrxz0Fhil2C1dKAN0DzgV1qr/i0QELwDmeCbdfwEC0HyCmT8vHzoQpVr/nyNTIIOz7rj1+BEdl+Vx6Nv7H4CSiZnpr82KIoDzSKDOuMdKUEj4Z8nnISHAFKrMHRtBaXl3bXJX5dm0usoYRK3+Lx4X6MSuAfvWPTLDJ9zKn1melmgsEcyuUrFKl6JndZ8gi2mAmWAX9re1AxeFCIv8YqSQ9VgfvqSR0CCcASyp9KbY+dKl4EzwW5IHLSOYnDVP3s7oiuBLRftrfY85g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJYChS4gx4BGfX2xNrZcaUhCwf8e8zopAMqleH4j1Js=; b=smiwTOaWx4D4sfhLad5f1IXpLHr/mQ566a0L4d20FLgESDVHvfIASmiIF6h0AVszDcDJief+augPsa0o7Ur/7jU53Gqnhoi1SgsWK/0p20+T+7EzaQlYrRu+l6tT8kbTTepGzoZRaGjUkOvgEx4tgZ7vrvNtsnJoaEYfGb+4Cbo= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6468.eurprd05.prod.outlook.com (2603:10a6:208:139::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul 2020 09:17:19 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020 09:17:19 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Thomas Monjalon , Dekel Peled , "stable@dpdk.org" Thread-Topic: [PATCH v2] common/mlx5: fix Rx/Tx queue doorbell record size Thread-Index: AQHWX0+zmF9OvwKUpEulZor6H6buDakTUa2w Date: Wed, 22 Jul 2020 09:17:19 +0000 Message-ID: References: <1595165997-12225-1-git-send-email-viacheslavo@mellanox.com> <1595329889-31516-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1595329889-31516-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0a99e43a-6a64-4b2b-5655-08d82e2008de x-ms-traffictypediagnostic: AM0PR05MB6468: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:457; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i/wRoyiq5m60HdfhD4B8aurj8xCl3yW4CCjlvo2O8AQVZGaWjEISzddFxws7sP99sj2I8qUGYzDMAEIzsOMttNcbuLizAGrOOsC40m40Wx4K0IzmfGUYhaSRhlJTCIVOFqSlcmOX9Y6OI/zfQEap0uMeXCG4W0rw0BsQHEDp+gWRzwjRt7a8VzblJsDadmRK2i8iTrZcDIgEDtsSBxmy3X6Cnqyxgr1BTnZ4C+9ZnbuIDxm/lkBHbggUJ6j8u6poOKr68iIjnezoPQk80rlb7oGHewdYXBK0KPXhyoVVXVXElsJYw/IGkICPtpTBdAKbtlN/YgggqVFQvcb2vsGujw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(53546011)(2906002)(5660300002)(33656002)(478600001)(110136005)(4326008)(186003)(316002)(6506007)(52536014)(55016002)(54906003)(9686003)(71200400001)(76116006)(26005)(64756008)(66446008)(8676002)(66556008)(7696005)(66946007)(83380400001)(8936002)(86362001)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ih0RbGPoqH8q3hEVlfYRcYchm+ZPhkU4F/V0zqmpIJOmMCHecXUJGiDi/dA0MBG9jF0kn8HTKZPXn+9bx0QPCuiQpe0SwF66wzRRF4JR93Pm58IqcG5wFZbGT9MlLJx8oyE/FnPYLsADM4vPghigodaRj19eLFEv5RnbzH7lxsPczZlJdFp4rAM/YnvIhMzFCAPZJL0zUiRaEgY9v+8r4MlSUJOHsesf4+0P4q2H2YIQFOtSbz57DfU/przT0PYfYCdqDc5fXi8yasUl2GGPtabY6mEQpkednQbXJDubvKJGK2lN1Y6XmBAC9bn8x8NofWFOwNTZ87rVGn3K+DobQokDlTFoAQ7b993kGuIr1R6SsXwi3mSPCyEGIcxXtzL7rCREyDpVlnCjiWQG03pgcjLc7XMH/MknPm9oLpFgfTi2bM4Rz05ni9+DfKqvreOXR392Kvsgw2NKdDk4N3LG4s8mnCvsOSp1w+DnW/IrlFK/9xSKjnoxxJyp+Xkpvxcp Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a99e43a-6a64-4b2b-5655-08d82e2008de X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 09:17:19.4858 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DU9334SBe9614tF6rERKxSAljfZYdADXdg7zmre5vK1/Smnj+R5+kytdUhE+/YPd9lgYUxUA1Hw5uVIOegdB2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6468 Subject: Re: [dpdk-stable] [PATCH v2] common/mlx5: fix Rx/Tx queue doorbell record size X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Tuesday, July 21, 2020 2:11 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon ; > Dekel Peled ; stable@dpdk.org > Subject: [PATCH v2] common/mlx5: fix Rx/Tx queue doorbell record size >=20 > When Rx/Tx queue was being created with DevX the allocated > doorbell record size was only uint64_t. That was definitely > less than size of CPU cacheline and it might have happened the > doorbell records attached to different queues handled by > different cores were allocated within same cacheline. It might > have caused the contention on doorbell record writing. >=20 > This patch extends the allocated memory size for doorbell > record to cacheline size. >=20 > Fixes: 21cae8580fd0 ("net/mlx5: allocate door-bells via DevX") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Matan Azrad >=20 > --- > v2: - rebase > - clarify commit message, register is replaced with record >=20 > drivers/common/mlx5/mlx5_common.c | 2 +- > drivers/common/mlx5/mlx5_common.h | 10 ++++++---- > 2 files changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_common.c > b/drivers/common/mlx5/mlx5_common.c > index 79cd5ba..193e73b 100644 > --- a/drivers/common/mlx5/mlx5_common.c > +++ b/drivers/common/mlx5/mlx5_common.c > @@ -187,7 +187,7 @@ static inline void mlx5_cpu_id(unsigned int level, > page->dbr_bitmap[i] |=3D (UINT64_C(1) << j); > page->dbr_count++; > *dbr_page =3D page; > - return (((i * 64) + j) * sizeof(uint64_t)); > + return (i * CHAR_BIT * sizeof(uint64_t) + j) * MLX5_DBR_SIZE; > } >=20 > /** > diff --git a/drivers/common/mlx5/mlx5_common.h > b/drivers/common/mlx5/mlx5_common.h > index 5b9b7bd..ef7b61b 100644 > --- a/drivers/common/mlx5/mlx5_common.h > +++ b/drivers/common/mlx5/mlx5_common.h > @@ -214,10 +214,12 @@ enum mlx5_class { > MLX5_CLASS_VDPA =3D RTE_BIT64(1), > }; >=20 > -#define MLX5_DBR_PAGE_SIZE 4096 /* Must be >=3D 512. */ > -#define MLX5_DBR_SIZE 8 > -#define MLX5_DBR_PER_PAGE (MLX5_DBR_PAGE_SIZE / MLX5_DBR_SIZE) > -#define MLX5_DBR_BITMAP_SIZE (MLX5_DBR_PER_PAGE / 64) > +#define MLX5_DBR_SIZE RTE_CACHE_LINE_SIZE > +#define MLX5_DBR_PER_PAGE 64 > +/* Must be >=3D CHAR_BIT * sizeof(uint64_t) */ > +#define MLX5_DBR_PAGE_SIZE (MLX5_DBR_PER_PAGE * MLX5_DBR_SIZE) > +/* Page size must be >=3D 512. */ > +#define MLX5_DBR_BITMAP_SIZE (MLX5_DBR_PER_PAGE / (CHAR_BIT * > sizeof(uint64_t))) >=20 > struct mlx5_devx_dbr_page { > /* Door-bell records, must be first member in structure. */ > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh