From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84E36A0350 for ; Sun, 28 Jun 2020 14:17:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 75F6C1C1C3; Sun, 28 Jun 2020 14:17:18 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00056.outbound.protection.outlook.com [40.107.0.56]) by dpdk.org (Postfix) with ESMTP id 15FD31C1C3; Sun, 28 Jun 2020 14:17:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IKmOTlHUrugtmEV6wT3ic97qQlXHPRsnqH7/meax9JeTW6JheU/0eaexzPmgj4yghXC9GL+0cM/rxzgRssbqchKupUQq7QLfMnVD3ooIL/tzVqMBfJ/X2x2+uNQ0O9ioNGua1AGm6KznVBEQwsUrUT69kC95qsi2nt+HYktkAclsNiCTnRRN4MThXmqbUueitAiQk2qvQvcpasD4wDG2s/iBa17XyiVwlKrCqx+WVMSPpmqMsuVXUYE6dHrDkQK4BcMU3UAkOsZEv4bS96SIzSLk/rzHmdUWpOrXTdfa6SkTPjISBCkrGWGxZKbK4MMncpCRoMnVMTImYdQFPfKziQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QvhJOo8WCwVAvZqIruBd181yDXIka/LG/cLpSZBaeFM=; b=kOutEWlddpgdAw6BXsj5667b2u6kR7m1Rj1KABIUMQAsaccN7UmyVLeRzT6u3IpJujPHNyFDewRo/op0Ftz4xDldQ8Kfb5HzUpO8eOARFz84OAwojdhaCgKruMQsxdEBTXuA5A8aBVhbtqgM5jZNYiwy0pTHEZpSfdWNlMRsYFmgPvhEb3fg0JA1EoW9NkSYzFrheXOeiis2cUATk6yCyygMFy3brjkeWeK8k6Pq5nMQxof13cSXTEWxKG0/PZEYDXs6/wmaisHFOYBBoE003VXAxH3RgWmf9+abvpqBrIiLEmOryPCdXsWDmt31Awi0/3T31KA28+zkyB4oOnuyPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QvhJOo8WCwVAvZqIruBd181yDXIka/LG/cLpSZBaeFM=; b=WLVvLGW2JuDvn/anKyeK7FpppCX6KBD+WrBjSsnxIe3sJ+EfriFD5tIWsXez5ThMgrcsHpfEDVTsJ9BDw8iv/8BylTS30wIUEfy5w7YpDYJ3Mv/GC6UC2VWUBvJVbpMGYQGO84ENTR/cl5NET41R6H8KTtEpVDzx8Ik3r4GOguw= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6708.eurprd05.prod.outlook.com (2603:10a6:20b:144::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Sun, 28 Jun 2020 12:17:15 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3131.026; Sun, 28 Jun 2020 12:17:15 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] common/mlx5: fix code arrangement in tag allocation Thread-Index: AQHWSipQ8P9y1lZTjEqsOtc31HIlW6jt9tKw Date: Sun, 28 Jun 2020 12:17:15 +0000 Message-ID: References: <1593004831-4073-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1593004831-4073-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4483c7c6-d331-42fa-e554-08d81b5d3210 x-ms-traffictypediagnostic: AM0PR05MB6708: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0448A97BF2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h3gQnL+ft7uUdhV565/QSEpDL9/L3m68I1LJvqn7BHGs96Iwtfija85qeP1SEcG5sXv9alOBMT6V5wSIv8U6VEWaIfCkup6vRoUVUMVM32Mw5VSiyK8qWdNn7hWQkXgq41SYsdwz+xE3XakZFbTpBCYw4zTFZ8xjUafmKd7zHcqx221+iW+o3HmP2/c+zEKCYkL5nAredoTpXCytXKxrUV1skAY4MVTPyiF+Fr0H2uhqb7T+Aat6nIFBhPhf3B0KGFNlc8W39id7eTDAPZCbZnLDRb7i95xp6HFCD4gXvsjHAvZei/aqyIeBrz30SDd7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(136003)(396003)(366004)(376002)(39860400002)(33656002)(4326008)(110136005)(71200400001)(316002)(9686003)(83380400001)(6506007)(55016002)(54906003)(186003)(7696005)(450100002)(53546011)(26005)(64756008)(478600001)(66476007)(66946007)(76116006)(52536014)(5660300002)(66556008)(66446008)(2906002)(86362001)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: pbLLE+xabnjIZEO+9V19IKmHWEr6v/0GTvjCfTMRUj8DM+ylGr3IypFz453LIaCnTJPovW1FordN7twKIXmVy1vICSOCRcCCrWmPfd3CIs6nFXC/ZSFgVly/5GRDCLcoS1fHvrPpkvoDY58s1jZEiMcP7ivQc/TvO56QZ/Ypjb0n9Kts1bAtEmMX5rI6zIBYgcGzhdR4I3hXldw1fWuKC6yJQEkcNuZgdAF5klDOBvcscwe95SpDpunj5edMzEDjwr/C6o2D2o0JmEMXgjYnT72qjYdwKLLWsLZwdoOExg/idKtbxOQyCOer0bdSzpUbE4GcO51rHTyYZuwXldGinXU4WiHSyNCYjdyiaGWaynM6pNFKdGNWDM6tQd1uia2LdR3dkf8Iu/nPJ6AZtvaMxOvzB7ZndKjnGOHJI2kcNkKh7uN5n/sXhZwMXgaZYD7NdjvrlL7NTR5/FOC6EFqplTWw0G40eir5yCJJwXC7Sp8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4483c7c6-d331-42fa-e554-08d81b5d3210 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2020 12:17:15.7597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rCBQX3kfqgLPmxp+3y73hcB9NgXtGP/HyVBTKtCXX4/hiV/rSsNvqf8qxYmuhykTuMCp1t6jm3TvIBrQ9o5TWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6708 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] common/mlx5: fix code arrangement in tag allocation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 4:21 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] common/mlx5: fix code arrangement in tag > allocation >=20 > Flow tag action is supported only when the driver has DR or DV support. > The tag allocation is adjusted to the modes DV or DR. >=20 > In case both DR and DV are not supported in the system, the driver > handles static code for error report. > This error code, wrongly, was compiled when DV is supported while in > this case it cannot be accessed at all. >=20 > Ignore the aforementioned static error code in case of DV by > preprocessor commands rearrangement. >=20 > Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/common/mlx5/linux/mlx5_glue.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/common/mlx5/linux/mlx5_glue.c > b/drivers/common/mlx5/linux/mlx5_glue.c > index c91ee33..a41650d 100644 > --- a/drivers/common/mlx5/linux/mlx5_glue.c > +++ b/drivers/common/mlx5/linux/mlx5_glue.c > @@ -752,7 +752,7 @@ > #ifdef HAVE_IBV_FLOW_DV_SUPPORT > #ifdef HAVE_MLX5DV_DR > return mlx5dv_dr_action_create_tag(tag); > -#else > +#else /* HAVE_MLX5DV_DR */ > struct mlx5dv_flow_action_attr *action; > action =3D malloc(sizeof(*action)); > if (!action) > @@ -760,11 +760,12 @@ > action->type =3D MLX5DV_FLOW_ACTION_TAG; > action->tag_value =3D tag; > return action; > -#endif > -#endif > +#endif /* HAVE_MLX5DV_DR */ > +#else /* HAVE_IBV_FLOW_DV_SUPPORT */ > (void)tag; > errno =3D ENOTSUP; > return NULL; > +#endif /* HAVE_IBV_FLOW_DV_SUPPORT */ > } >=20 > static void * > -- > 1.8.3.1 Patch apply to next-net-mlx, Kindest regards, Raslan Darawsheh