From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EC64A2E1B for ; Wed, 4 Sep 2019 16:11:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 029AD1BF09; Wed, 4 Sep 2019 16:11:00 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40089.outbound.protection.outlook.com [40.107.4.89]) by dpdk.org (Postfix) with ESMTP id 96A3F1BEBF; Wed, 4 Sep 2019 16:10:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WUeJyPJFjlYrF0is9RsaSiVgkWrK3ebzyEj3sBTdOYWTuM3hNMQOQ/QRJXCVFMjJ8eK/frKQJXX8KwMnKzmaO+iuhPAUJGI/Ob2VhYWYP/gqxxTb0ukczLA1PZ/ezoR35yGHpr/Z9LFKsXcNQEa1+rGBTTmPFGElCaLMoDq0IHKCTyanyzFeAvTI43wdnl7Oh6EVrNnJmKfOiGZpKEpqVBdoMwzBCPnY5yqub9hSLOevhl5n0OLWNVrLsnXNiwKy8xigBTt+nvjoj7m5CKN+Wf0giBzPnJwwERnzkGUl1cTSOd/hqqMb4av8xgdBxxPkpRsedH7EPH7T6IZPOKaRmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2WVkWbO4OlvF2uGTRi8DWz7pCUVOoDWEeMdlF/Hr/zA=; b=N10AizHh+TsdTkUyadT78F3yszvEC+JFFwpKvJo/S91oQGjB/hf1rsedg5mWX9wfZWeFUuNovlly4t38IVYcp/QnS84jOwrhMgNjqpH1DsXj8e3HhAs8gm+upJCHxeIiQ189RLywZzXqEMyhkaw64X1QtnQW5wtU2peLZBptAq9RIF6vyKc7NUD+PpethtBBfsQ3V/E7/VlBuRwcA91suqTqzkiIDP453TaG/eUJYVXfpBDA8xnI4YjlKwDU/NIN/TAPzuPNy6YM1CGgxweOWNqeIfimd3GgDHERlfXeou8pbkyXjMhd7z6K58cER8A5k/iIEclg/u97UV6cror6SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2WVkWbO4OlvF2uGTRi8DWz7pCUVOoDWEeMdlF/Hr/zA=; b=YhOBWet9LNnVnbwaDGeKz0pYyXu/EKOdBdxsGrf6VSlx1v9pIE6ydLFmKcqp5nvAoDGTAxexlZZP2RDqwMSjZ9+4CDY1v6YxYDFnFoO+QXGDCFu4SnhCwqfwDgVa32AbUMLcF8auPZU0tlh/OFzM6qxOjsBBe/F9RkNWRbLX0js= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3313.eurprd05.prod.outlook.com (10.171.189.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Wed, 4 Sep 2019 14:10:55 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::da9:65ba:1323:a39b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::da9:65ba:1323:a39b%7]) with mapi id 15.20.2220.022; Wed, 4 Sep 2019 14:10:55 +0000 From: Slava Ovsiienko To: Dekel Peled , Raslan Darawsheh CC: Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix validation of drop action Thread-Index: AQHVU0u1s8eFCHzcd0iRIviLvU0bQ6cbrnhA Date: Wed, 4 Sep 2019 14:10:55 +0000 Message-ID: References: <7a681061efe7fa66f1827515039f83a2793fee15.1565861079.git.dekelp@mellanox.com> In-Reply-To: <7a681061efe7fa66f1827515039f83a2793fee15.1565861079.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 903fb3fd-3d8d-4c00-c95e-08d73141b3fa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3313; x-ms-traffictypediagnostic: AM4PR05MB3313:|AM4PR05MB3313: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 0150F3F97D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(199004)(189003)(13464003)(33656002)(486006)(52536014)(478600001)(7696005)(4326008)(476003)(446003)(11346002)(186003)(450100002)(25786009)(53546011)(6506007)(26005)(102836004)(76176011)(66446008)(66476007)(66556008)(256004)(76116006)(14444005)(6246003)(64756008)(66946007)(14454004)(71190400001)(71200400001)(3846002)(316002)(9686003)(6636002)(66066001)(8936002)(55016002)(6436002)(99286004)(53936002)(5660300002)(6116002)(2906002)(81166006)(81156014)(86362001)(8676002)(110136005)(74316002)(305945005)(229853002)(54906003)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3313; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: m0GnJViJ2hrmiidQP7SibTWdpJqTKxsk4xOxSXUOOlZBYVhDm8P3Cv30tge9ijU9qk5XHhj4ls34DeiGqVRFdRz1znj2E1Rxs/CaIMpleX3gns60+ICGYyd25nGRILnrjzbuMhW/rir+pd3OvPRs7RTUP4julM7Qxe6drXJ9p+l5ZSLLLpf6V2lAahjRBEtpokkrlsDPWfDgrscYPwJDS9meoJn9jNHz5BulREk1S/dpyVfJc0/vpezxnbEa1tooq8MP5Ap7uHb0nTCA1+fkfd6uCxZqrOb7XQn4avh71vvXjPNqxRX+hRHSnJ5Y1JpgAaIypmbsDNqJ+LSCPa4Vga8Oh4Q91yoGWccv+yelqNksJhEWEbs2raGA7Pu+Izz7g3KnwYaExN44sdkSLgIUY3EaQ7x1sWMHINWdO8nJk/Y= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 903fb3fd-3d8d-4c00-c95e-08d73141b3fa X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2019 14:10:55.7587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nbqONokzo03aGlHJo/q7MoOf5pqQ68fZqyiV8JbyozEtqhiCBWa4p54DfqqfG6fXl/NwIStQN3tS1tOTKJ+ygwM9IqdJGr2y4qNNvxqN5HY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3313 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix validation of drop action X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Dekel Peled > Sent: Thursday, August 15, 2019 12:27 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix validation of drop action >=20 > Function mlx5_flow_validate_action_drop() checks if another fate action i= s > already present in this flow rule, using defined value > MLX5_FLOW_FATE_ACTIONS. > This patch enhances the check using value (MLX5_FLOW_FATE_ACTIONS | > MLX5_FLOW_FATE_ESWITCH_ACTIONS) to make sure all relevant fate > actions are checked. >=20 > Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated functi= on") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 9d2c8c9..2356c14 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -809,7 +809,8 @@ uint32_t mlx5_flow_adjust_priority(struct > rte_eth_dev *dev, int32_t priority, > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > "can't drop and mark in same > flow"); > - if (action_flags & MLX5_FLOW_FATE_ACTIONS) > + if (action_flags & (MLX5_FLOW_FATE_ACTIONS | > + MLX5_FLOW_FATE_ESWITCH_ACTIONS)) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > "can't have 2 fate actions in" > -- > 1.8.3.1