From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B9DCA0535 for ; Thu, 23 Jan 2020 08:57:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9259B2C6D; Thu, 23 Jan 2020 08:57:08 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30075.outbound.protection.outlook.com [40.107.3.75]) by dpdk.org (Postfix) with ESMTP id C9B35343C; Thu, 23 Jan 2020 08:57:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X/3Y7tiKED3lSzvSfVpbfDBK9k9DfOX6ehTZAZHwcVlmhRwSWueCWJ9kdrTlX9AJCQgnEwo7tE2UWb/Q7qJDR9HWQ3uetvNEE6VI+QqvBK0Y2EVq3omooPld0gGXy7gr66aAA4awjsTKegQkveUWQ5cUS8RpWEp3I+NQ2JrRMwVViRm4BA9u+1YV2YVfiRAPtJxVsq/SU2h2SuziFdTJ15dnltPA3Xl09pvWuVTjdryiVVTnpVxzv9tHD1girOLYbjViNE9LfUNkZoD+JgsiBFVa0yjIVv2v6I7PyuXgKA0i6ZV4UrjHmh+jMVGv85rGWdNGJKADCHzp2z9U2Sse8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s2EPfS2nARNdQ32aYlWe34ZZ3RrhdT7hhms6GnPTpIY=; b=Srx35jE94JQdgGaZq3UNof82ZF4TtHtQ3WhLS5ZGzGNClyJuRtUpkqwJl9+veQRg6uNpmjha8eqTX21+ITEiBeurFOvy6anbZIzqfVqILJCatKC4jSlwCgA9zvA7M5Y+yWW6XQnoWPfDKJOoW0eDoIrfYU7V5UZzUEGBxQ1YtzRQ0Mw2Nx7btRGiMz8jBg9pG7anCfSzLuMaREko13l7fHSfNqa278EOoIO13GmkJw3HIRAcZ5NT/nYYFMQugiy5w+zcXqtWbiecL7D5x75Jbq2BfJCwy0gdpaPh47Nj3fLhk0fzUWr7C9AC8HnZZvaE4a+W9e9zzqDq3ye2wkcc8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s2EPfS2nARNdQ32aYlWe34ZZ3RrhdT7hhms6GnPTpIY=; b=WooAgDvj0/ldg7wtC/2MWhO5zOO4CI2NKPPOIZEbbXhA/1QdZZU9umWardIsKV1KOmP1YGI757cyc0ryqP+KVFcJV7dnGu4OkdD2p2x9caUEjTFq4qkaD29/Zf1gVw+5etqiv6kKj+sFiFQ8WWIv+qxL2//JUfuRZhMFBk/ZU0o= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3491.eurprd05.prod.outlook.com (10.171.188.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.23; Thu, 23 Jan 2020 07:57:06 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2644.027; Thu, 23 Jan 2020 07:57:05 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad CC: Raslan Darawsheh , Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 04/11] net/mlx5: fix allow push VLAN without VID value Thread-Index: AQHV0TBzUczFc4EtTEiuGNxeyqpafKf34v+g Date: Thu, 23 Jan 2020 07:57:05 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 73035c6e-aa6b-49eb-de05-08d79fd9d6fa x-ms-traffictypediagnostic: AM4PR05MB3491:|AM4PR05MB3491: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(199004)(189003)(54906003)(110136005)(316002)(5660300002)(450100002)(186003)(55016002)(26005)(81166006)(52536014)(81156014)(71200400001)(8676002)(8936002)(6636002)(53546011)(86362001)(33656002)(478600001)(6506007)(76116006)(2906002)(9686003)(66946007)(66556008)(66476007)(64756008)(66446008)(4326008)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3491; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DnGCpv45HYPYgC/uLMo7QpFTo28FkVUr1c2RpSvst20AqYvL6TYuffLb5tJ5ipn1oEN7eVmB6sm+KV1P7hnyoaIhAJT4SGCBayrThV6FDSb6upMNzrjZtbp4OobXX/eRhmi0g77agPjN4rRMAwwUY+U2Cg9ZOP+2dmFEWxCFm1MeLHA3mn6kD5KeXKewA+d678sIDWy7fRJY5pEtHAIy12r6uVfC6Q2oCzmROZ1vHHyOx1a87ET//W9tRVOo2G+BJS9HKcND2linyGfpQM3n+3jK5d/1YqIbs42sWkwGopkDMkGJ0Vt7LUsAm9NoIoe84L0thxV7O/P3sgLyPRl4QXih9UNVICgUDNdiztfFJIajo0CUcUjOLH4dtyDhgGZA+h0ZVlHlFLlq7w5DJoasPC5ggt9v+jFqhB4yuvQM0dLMN2u9mXIXLooERJtjhukz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73035c6e-aa6b-49eb-de05-08d79fd9d6fa X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 07:57:05.8320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Biww15Yj8RxyBNcHIPEhEHVBO5Y08N225q6bUxhHAfk2Lgo6Ex9WZ+LNhaLwtzkKjUg/iden3Vgy+i0xGBA3WgiatVoLKX7swZugd+B66xc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3491 Subject: Re: [dpdk-stable] [PATCH 04/11] net/mlx5: fix allow push VLAN without VID value X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 04/11] net/mlx5: fix allow push VLAN without VID value >=20 > Currently the push VLAN action requires a VID value, either from existing > VLAN item, or from following 'set VLAN vid' action. >=20 > This patch removes this limitation, allowing a push VLAN action with vid = value > 0. >=20 > Fixes: b8c0372bc5ac ("net/mlx5: fix set VLAN ID/PCP in new header") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index d7176c8..59ece01 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1734,7 +1734,7 @@ struct field_modify_info modify_tcp[] =3D { > */ > static int > flow_dv_validate_action_push_vlan(uint64_t action_flags, > - uint64_t item_flags, > + uint64_t item_flags __rte_unused, > const struct rte_flow_action *action, > const struct rte_flow_attr *attr, > struct rte_flow_error *error) > @@ -1751,14 +1751,6 @@ struct field_modify_info modify_tcp[] =3D { > RTE_FLOW_ERROR_TYPE_ACTION, > action, > "no support for multiple VLAN " > "actions"); > - if (!mlx5_flow_find_action > - (action + 1, > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID) && > - !(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN)) > - return rte_flow_error_set(error, ENOTSUP, > - RTE_FLOW_ERROR_TYPE_ACTION, action, > - "push VLAN needs to match on VLAN in order > to " > - "get VLAN VID information because there is " > - "no followed set VLAN VID action"); > if (action_flags & MLX5_FLOW_ACTION_PORT_ID) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > action, > -- > 1.8.3.1