From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81B53A0535 for ; Thu, 23 Jan 2020 08:56:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65BCD493D; Thu, 23 Jan 2020 08:56:55 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30058.outbound.protection.outlook.com [40.107.3.58]) by dpdk.org (Postfix) with ESMTP id D2E152C6D; Thu, 23 Jan 2020 08:56:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HxbnULlkM4Jwu3UavNW9oH+4AMxvq6yoBtJEX8oBsUkGSV5oD051AklJhAWeeRKeTTiiWCU7mPbp8ImlLjSoEMIZnBjbQglniY9xfhLkfQOVdoQRwQQRNAgZmflDLzYoiO7+pnSD/c3qJetcxXCgplK0QHoQyVlD4OQUmR1z6KNEBhEL47/W9Rso+U7/SS0MKjdCd0NY48+zXhj7NtP4xLV4RNWA6zD4wEYcBdeZRwKGZ3X2g9pyUFD1tVuFkUzdhn6nZMZ9EP5vwn585HgTyTezFWjGrYFiqJR6Sv9cIaMMb+9VqZrdJqp1pjOF3f1Cmh5jlcb+l3KVWTXQXfo/VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OhPyGUpQEU5X0jDEhuHQUjyS/lS8z4fpQj385o7sQzg=; b=Yis4SR7VrPAOlf+lIdYCccZzdg8RvH8eGgF12437+g01WltlG/N7jlBoCrxj5xmFmeouSrA6U/wTL/FasJNl+AjMJY7zKDGMM2PcJR0ESyM7gx0ZVA6Zwx7rGicMSbQo9loptM1HYwu1EVFKjvwSgO4tqPUeW7E4TZ/EbGK+7D3zcNLQKCP5jGKIYVWC9Db+/RmOIu7i2stNa/E3Ji79dOtIdFu7nmgaBWDWdJjVnyKuTJcurl07gEcr3OvqC6wAJOeMerj8bgqdzIbfPfc20oxa6RCRastcMUewJIjtH6KrL7pR8dq2jQxwzXy+ygAICMnDCvWOnJFDX2HMP5FNDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OhPyGUpQEU5X0jDEhuHQUjyS/lS8z4fpQj385o7sQzg=; b=khgKMweEVH4bbssoK+1RR+eKn+FqhS5vKqQ0VYM/gYtuH1jS4eaRgoAHaisPDZwx2++FRSYpABddeSRNZlH7tklM8c0YknSr70HSwXPpkXwCk1R0b0unMxP79zwm4Jm5J483Z5ulXsBGSdejnG/7f+lw0fn1bit6Ylx7g6kEa9E= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3491.eurprd05.prod.outlook.com (10.171.188.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.23; Thu, 23 Jan 2020 07:56:51 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2644.027; Thu, 23 Jan 2020 07:56:51 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad CC: Raslan Darawsheh , Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 03/11] net/mlx5: fix bit mask used for push VLAN validate Thread-Index: AQHV0TB0tO0YwY8RFECfxzsuUgCQaqf34u7w Date: Thu, 23 Jan 2020 07:56:51 +0000 Message-ID: References: <8aa91586a23ecd1718038e2a5d9deac45264f3a5.1579703134.git.dekelp@mellanox.com> In-Reply-To: <8aa91586a23ecd1718038e2a5d9deac45264f3a5.1579703134.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2be23a14-007a-4e9b-b212-08d79fd9ce2d x-ms-traffictypediagnostic: AM4PR05MB3491:|AM4PR05MB3491: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(199004)(189003)(54906003)(110136005)(316002)(5660300002)(450100002)(186003)(55016002)(26005)(81166006)(52536014)(81156014)(71200400001)(8676002)(15650500001)(8936002)(6636002)(53546011)(86362001)(33656002)(478600001)(6506007)(76116006)(2906002)(9686003)(66946007)(66556008)(66476007)(64756008)(66446008)(4326008)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3491; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2EAqYTz1Vc6zS5zAqVabmorIJ9CdEhlrE3KLQhMYtVtTpvRLiPsDEBYLrqw5Ad4utgFY+pMdBRtazFbZLc3WcQI9AOZrOjwVg5CEi7WkJEtEvrpHt48vO3r9jmQEv5Mz4sqxory5mSvM8guVNllqdLsOFTeFtUMh/RbnALlDTJRvcYn2cO5ekG1GlsYsfN07wR0GV+GRznojPfQArk9MbNXH5XzIT03qVSDbdEPrQy1kCtHsHqUi0EL/ntKWWm7alwER2asSFFKLYA8oK9nSpjYX3I0PQ3WtZrqu2Od38gdOfooplyg8lCJA5mm25xCN5S3oPElJ5yQ1UQ1+PF4li/uX8l8bdykKopHYtmDtHG2w4dncEnur0001pu9TAZwAV/c5H/b39BDZASBR0/XlIKcF/dIXHsYA/TMEL9P4rhs0G1YC/wuAWtRasxMbf/5N Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2be23a14-007a-4e9b-b212-08d79fd9ce2d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 07:56:51.0376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IwlKs4EgVLZs2jITdT43Rr0NiGByrkQASZqGFYVZchyGdVDnOg5mU61/J7RDqQT/7F1optnk3a9b6OyBYXUyr2mX/Iv2zjFn7VUmhXrInpw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3491 Subject: Re: [dpdk-stable] [PATCH 03/11] net/mlx5: fix bit mask used for push VLAN validate X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 03/11] net/mlx5: fix bit mask used for push VLAN validate >=20 > Validation function of 'push VLAN' action uses (POP_VLAN or PUSH_VLAN) > actions flags, instead of using a mask of both flags. >=20 > This patch replaces it to use existing VLAN_ACTIONS mask. >=20 > Fixes: 9aee7a8418d4 ("net/mlx5: support push flow action on VLAN header") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index afa3d0e..d7176c8 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1746,8 +1746,7 @@ struct field_modify_info modify_tcp[] =3D { > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > action, > "invalid vlan ethertype"); > - if (action_flags & > - (MLX5_FLOW_ACTION_OF_POP_VLAN | > MLX5_FLOW_ACTION_OF_PUSH_VLAN)) > + if (action_flags & MLX5_FLOW_VLAN_ACTIONS) > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ACTION, > action, > "no support for multiple VLAN " > -- > 1.8.3.1