From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5173A0535 for ; Thu, 23 Jan 2020 08:57:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A94042B98; Thu, 23 Jan 2020 08:57:30 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150074.outbound.protection.outlook.com [40.107.15.74]) by dpdk.org (Postfix) with ESMTP id C08382B98; Thu, 23 Jan 2020 08:57:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YVmWbgANTjKHpbbwBd5nig1IUlvU5rSGzwuc5ceSD+oWquU0Eu4SGpgG+lgarsEW5fiL66VlSJaA8qstS9LCEaKDMCqAyDeyZ6Ta5n9Qp+nFfLnQ9+lNXd9KCTstSq+bJGxkdxqoef65yfs4egtbvFg63Em7vxkXKINwz+74N+QdFS7xpvyJB3OOKtxZHNQEhf0BYGY+RNOjmiXVhbE9QI9MUI7QeTQviQObLr6s5A0pOTwa5lrJ1mNBCQR3/4ytZn6whhx24+YJPKjsbUSv98WOCsj87ssDdk3N0NdO1kKZTE0ogUzWYtF/Y9jNa6Np/yS/yqpR4NQn9XDVSkB7Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F+/Kkd0u+93+3LZWyDNAeB+0MsMwfUBFf2m/SlZVoxM=; b=hULVopdvUmRfvX1A9WJY/7ssgAhChMbJ5It7eisGd44f0lRe68aXdHk9cXTn1K7/kpeSy8fyVKCrCOwajhD1D0DCVM/Rn4DH89JwtQsDNWZ8b8o4kz1fDu2c+u2rqzMrcvuaoyr5qlui4a3nyru7dEJnafTIlS/iRidI1PydeIpF+LXAJI8x6L7xxkfMMKK2bZKP4kWu3RIoLvf/q9rhfnyZqyqPw/fb57I4s/5A8EQdlcIPOKNyI0Z696G/dt6ote9qudgtym5J4ccBvMlZ44YdenVJNP4GrKDAphb1JdPNo+j/9WoUjUkD+gRGPKflZA5bu8vCKrcVMzpUCLvy6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F+/Kkd0u+93+3LZWyDNAeB+0MsMwfUBFf2m/SlZVoxM=; b=sPZG7+f5q7OOdDVHG92bykL5dEiBWreF+B8/9wNHlMmY/0PFJ/Ih4UNAYoS5zzwfG8inVzH0ybgpsQjoP9vfaWB4KGdUzV74IamNFGD3jymZK+mfMap5QJkO6jqUWdYmupozOJz2nPniVcrAe2cax2EeaLxhXxOdr4Jgm1QuO2w= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3492.eurprd05.prod.outlook.com (10.171.187.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.20; Thu, 23 Jan 2020 07:57:27 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2644.027; Thu, 23 Jan 2020 07:57:27 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad CC: Raslan Darawsheh , Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 06/11] net/mlx5: fix block push VLAN action on Rx Thread-Index: AQHV0TB5yxfcdtl/RE6730ujyeNCJKf34xrg Date: Thu, 23 Jan 2020 07:57:27 +0000 Message-ID: References: <90d9d10b99a33b66deee2ec708269160a2c77fea.1579703134.git.dekelp@mellanox.com> In-Reply-To: <90d9d10b99a33b66deee2ec708269160a2c77fea.1579703134.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c6e0620a-0562-4d5a-6b51-08d79fd9e3a0 x-ms-traffictypediagnostic: AM4PR05MB3492:|AM4PR05MB3492: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(189003)(199004)(450100002)(81166006)(8676002)(81156014)(2906002)(316002)(54906003)(110136005)(8936002)(4326008)(55016002)(9686003)(186003)(26005)(7696005)(53546011)(6506007)(5660300002)(66556008)(66476007)(66946007)(76116006)(64756008)(66446008)(52536014)(86362001)(71200400001)(478600001)(33656002)(6636002)(83323001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3492; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +7qfV/7GvXE8LoFYsURxUiT4ah+nwIyBXuXXNFnom1SGVLD8+TRhsFcylTAiokH5nGc0P6jYczZaNHfjdL7epZ4DcBOvejD5YPiCbFtlcCpMbIOMmzs8gloegrWnkt9WcOS9FEgtOYjbRbWqNwLETtS9PVt16Gfod0T9/kj+oZ8sRxT0LZYlofwQU103FZdCCmz9GsoEfvCa4BixeMAfEPRf9kcS5jUtP90wio/oKKQtOwq4qXijnaR8aeuV+p+k1CZ9Qnf2imnRtYXFOQYgHpwXa5RJmpWpdib+gSEmD8rDXoRJj7uKtdhDkr/T/kBqaJ1EV+s3Vhs+C9CIImQCyKF6ISn8r363noM1VpMrQvDKbC7Boew1j/Gtiz3Cze4Q7m45sCUJAzBAcB7yKSg/XSEXlMhMabRM0tF89nvVS2j37lEdaxaepHYg/NOv7vuge/1yzJPFO5Phq6diSmHqdAhbaQaT0j2Y2pg3oVOeUUur+bZuifXrDCDCf0zJ/Mk+ x-ms-exchange-antispam-messagedata: jX1yzx7R46cOKHbT4VjnzMUWpamEAnqjfAQ2QAXYWUKptDXroH62foz1RjCJ2iFyAQ6BDudwGOlIeCRkTzcyZ55JpRD9V1k1BWtxu9TMzNsr1w7I10W+mZ7t7fVtb1wKllGHxeWGNmhrfwwuEB6Esg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6e0620a-0562-4d5a-6b51-08d79fd9e3a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 07:57:27.0286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Pae0q+gLhGG5xWytl3AfhAbtapizwykaTQEDwZ0rJVPrTd7cfAfPujGwCrjtMeBrpnDfDrSwcCXzBTmQllhRd1bqyGf4lnWPQoqjBgjIJXQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3492 Subject: Re: [dpdk-stable] [PATCH 06/11] net/mlx5: fix block push VLAN action on Rx X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 06/11] net/mlx5: fix block push VLAN action on Rx >=20 > Add missing check in validation function of 'push VLAN' action. > Action is not allowed for ingress flow rules. >=20 > Fixes: 9aee7a8418d4 ("net/mlx5: support push flow action on VLAN header") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index b0d5688..1ed677f 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1741,6 +1741,12 @@ struct field_modify_info modify_tcp[] =3D { { > const struct rte_flow_action_of_push_vlan *push_vlan =3D action->conf; >=20 > + if (attr->ingress) > + return rte_flow_error_set(error, ENOTSUP, > + > RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, > + NULL, > + "push VLAN action not supported for > " > + "ingress"); > if (push_vlan->ethertype !=3D RTE_BE16(RTE_ETHER_TYPE_VLAN) && > push_vlan->ethertype !=3D RTE_BE16(RTE_ETHER_TYPE_QINQ)) > return rte_flow_error_set(error, EINVAL, > -- > 1.8.3.1