From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>,
Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>
Cc: Ori Kam <orika@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix LRO dependency to include DV flow
Date: Thu, 24 Oct 2019 13:42:21 +0000 [thread overview]
Message-ID: <AM4PR05MB326565A82B3127E7E0D42A01D26A0@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <8fd5a11fbe9cde80ac55b2cbec9d79e3fac56bf5.1571921204.git.dekelp@mellanox.com>
> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Thursday, October 24, 2019 15:47
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix LRO dependency to include DV flow
>
> Rx queue for LRO is created using DevX. Flows created on this queue must
> use the DV flow engine.
>
> This patch adds check of dv_flow_en=1 when configuring LRO support on
> device spawn.
> Documentation is updated accordingly.
>
> Fixes: 175f1c21d033 ("net/mlx5: check conditions to enable LRO")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> doc/guides/nics/mlx5.rst | 2 +-
> drivers/net/mlx5/mlx5.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> 600cea7..45fa968 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -203,7 +203,7 @@ Limitations
>
> - LRO:
>
> - - Requires DevX to be enabled.
> + - Requires DevX and DV flow to be enabled.
> - KEEP_CRC offload cannot be supported with LRO.
> - The first mbuf length, without head-room, must be big enough to include
> the
> TCP header (122B).
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> b99c5a9..5977d06 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -2033,7 +2033,8 @@ struct mlx5_dev_spawn_data {
> if (priv->counter_fallback)
> DRV_LOG(INFO, "Use fall-back DV counter
> management\n");
> /* Check for LRO support. */
> - if (config.dest_tir && config.hca_attr.lro_cap) {
> + if (config.dest_tir && config.hca_attr.lro_cap &&
> + config.dv_flow_en) {
> /* TBD check tunnel lro caps. */
> config.lro.supported = config.hca_attr.lro_cap;
> DRV_LOG(DEBUG, "Device supports LRO");
> --
> 1.8.3.1
next prev parent reply other threads:[~2019-10-24 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 12:46 Dekel Peled
2019-10-24 13:42 ` Slava Ovsiienko [this message]
2019-10-29 8:57 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB326565A82B3127E7E0D42A01D26A0@AM4PR05MB3265.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).