From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17DFCA32A2 for ; Thu, 24 Oct 2019 15:42:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE9FD1EAE5; Thu, 24 Oct 2019 15:42:27 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30062.outbound.protection.outlook.com [40.107.3.62]) by dpdk.org (Postfix) with ESMTP id A5BC21EAC9; Thu, 24 Oct 2019 15:42:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UKDHYrCBhRDpvyd4JGGVfyccZYQj/YELR03Hh9LyQw5QKP3kStG0uqRZSWS9wv8eFVcg5VydOWa3OFjKNMmHKJW0xjYk3DJSiMuEww1ypajcU4PxkGnUNct/2IRy9JC0v67+DH2Iqlei9zBRNWutn5Ssx2uS+0nWxsmEvxF27FEmSjnEW1eMkd3nZTttDP71TNIwyHAZTfb32Fu/0Ljmn64/H7ZB0T5mJlMtA2cFftFeVs/h5oh+jOvs0IXErcB8HM/12N2m0cQQDtICuMay4ol7Cqllw+i1kz+L+M5EB/431PrnSmSOK01n4AEXfa80eWH/nIjOA9BrASUHJNhbdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yxje7E3C2KQMgKz0jfaiUUpsTVbPSZ0/q+Ptm5K5EHk=; b=nvvTSGC/Dj0PQ05FNblNzEV18tr0kXYex6YLOI6H88izkM0CKiTEA/nJ4bFEvOdRbHvZuFOt5yKUGNDIwUgFWRJbYtT3qW7memnegYapK/mN26tICworr0uqcCsJ8jVys8eGx9YWgsVlPW2Yna5JPsBknktrhMSdJjyn8/m/OSrXNWHt/El+R6lKBzFXw68Cyn/AZgzAJQEkwhG9taCOsxN8TU8i2g7U+yeCOiWRvT4o/553vp+nj82EKRfQ8PwaZP114jM5pNyyntwRJcM5ZW/7MaVcR639KCgQItyG86U/BjfFR7TwNNKIt0hmh7S98sNuyZw5dlD4D2yb7tcBxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yxje7E3C2KQMgKz0jfaiUUpsTVbPSZ0/q+Ptm5K5EHk=; b=J3MJcAbKJ+xizaGGB1rSnPJv215phXt2fQG4bvl8xUMYSb82QoGsBgVL4iCaeK9DABDlrAoslZA8IxpLR9jzlj/Rx51F1kKV+CKVgKnNT5ENBNzeby7N2cmJ9q9tRKiWLdNYApkDoXY6mXt0svMS1+vjeLxhtoSbFlXM1kr8H8c= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3492.eurprd05.prod.outlook.com (10.171.187.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.22; Thu, 24 Oct 2019 13:42:21 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b%7]) with mapi id 15.20.2387.021; Thu, 24 Oct 2019 13:42:21 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix LRO dependency to include DV flow Thread-Index: AQHVimmUIh5cvcXqbEGK2bJOx1j2Z6dpzKBA Date: Thu, 24 Oct 2019 13:42:21 +0000 Message-ID: References: <8fd5a11fbe9cde80ac55b2cbec9d79e3fac56bf5.1571921204.git.dekelp@mellanox.com> In-Reply-To: <8fd5a11fbe9cde80ac55b2cbec9d79e3fac56bf5.1571921204.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b34ef885-f052-4536-303e-08d75887feb6 x-ms-traffictypediagnostic: AM4PR05MB3492:|AM4PR05MB3492: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0200DDA8BE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(136003)(376002)(396003)(346002)(189003)(199004)(13464003)(86362001)(66446008)(66946007)(66556008)(76116006)(26005)(186003)(66476007)(64756008)(33656002)(102836004)(53546011)(6116002)(3846002)(2906002)(7696005)(52536014)(6506007)(76176011)(99286004)(110136005)(54906003)(476003)(11346002)(446003)(486006)(74316002)(7736002)(5660300002)(9686003)(256004)(4326008)(305945005)(6636002)(66066001)(6246003)(25786009)(450100002)(478600001)(6436002)(81166006)(81156014)(8936002)(8676002)(14454004)(55016002)(71200400001)(229853002)(316002)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3492; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0wEhCAu1tNMiadck4+U3kl9LXCI5tTiFKLRPQbbf7qw5mvjbC6mekaUSE+GNphRSAMkAfdr+4pDtmJjUfTqQAQ50e6lYfJO1LOQ/sooiHnxFfiBzCj4BjHA+/n2S7XoXRPqX5f3Cz1FcrdAx6esPA/Jk5EhjxbtIU600/G+YIEmAQ8iK5SXN5I7lCyZkRfkW7We05abuRFvhgQLub0CDG7PUt7Db/Z9dYQCA/YNl4svQtG5+q45yCyILx1/ZAKOmWo7x3tI8w3Hzj8jcgBksaNw8S5RKPztF9Pz34VQCttYikngk7cESvVUPdro72fXoZi79QGagOqZV2SLnkefflgitxk0msipMvN0LsIFVC6VQ5KtPrPlRIuHBw9vurVRYxL4JLWMX/bz/J0rjjhdFmLNz68kNdQoT2f3+pJE3qAnsNbJv1i2ut+eODeF8WWeW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b34ef885-f052-4536-303e-08d75887feb6 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2019 13:42:21.2427 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PAhFprCnonvDw7KTcDoEm+6cj1kiwEg8/63oTqw8w1N2rsZpD5jLhVM3oIbNjm5hTkz3SndvIG7FTKqrEH3eV6vIGqsRJjT8xg1srCo4Ic0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3492 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix LRO dependency to include DV flow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Dekel Peled > Sent: Thursday, October 24, 2019 15:47 > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix LRO dependency to include DV flow >=20 > Rx queue for LRO is created using DevX. Flows created on this queue must > use the DV flow engine. >=20 > This patch adds check of dv_flow_en=3D1 when configuring LRO support on > device spawn. > Documentation is updated accordingly. >=20 > Fixes: 175f1c21d033 ("net/mlx5: check conditions to enable LRO") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko > --- > doc/guides/nics/mlx5.rst | 2 +- > drivers/net/mlx5/mlx5.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index > 600cea7..45fa968 100644 > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -203,7 +203,7 @@ Limitations >=20 > - LRO: >=20 > - - Requires DevX to be enabled. > + - Requires DevX and DV flow to be enabled. > - KEEP_CRC offload cannot be supported with LRO. > - The first mbuf length, without head-room, must be big enough to inc= lude > the > TCP header (122B). > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > b99c5a9..5977d06 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -2033,7 +2033,8 @@ struct mlx5_dev_spawn_data { > if (priv->counter_fallback) > DRV_LOG(INFO, "Use fall-back DV counter > management\n"); > /* Check for LRO support. */ > - if (config.dest_tir && config.hca_attr.lro_cap) { > + if (config.dest_tir && config.hca_attr.lro_cap && > + config.dv_flow_en) { > /* TBD check tunnel lro caps. */ > config.lro.supported =3D config.hca_attr.lro_cap; > DRV_LOG(DEBUG, "Device supports LRO"); > -- > 1.8.3.1