From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7729BA0539 for ; Thu, 23 Jan 2020 08:57:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 536394C93; Thu, 23 Jan 2020 08:57:39 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150052.outbound.protection.outlook.com [40.107.15.52]) by dpdk.org (Postfix) with ESMTP id 42CFD2B98; Thu, 23 Jan 2020 08:57:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksRXkPG5RroJZormsIqd+oFrwlz++f7COg5RvGwNvKO6SKv5ZSvsur6uziKn5oSeU98jtDvEsY7LjDAPdl3K4JwG/4BpM8wEectxrARVIWTib4k4JfVJLOXx2DvWlpuSa2n2RBGsWTxwX5tQQN17qrUEYH4z/gDpFE1fpVmdPnYq2iEOHfsxHZ6fW5bkUMq67quHb+GonH5TgRP5LkJzdaml0Ntr91Mz7DSl7Esj3XBejQY9zRU5C35XjdYwBADZVgln8oxVhOTwaSaR5C9wigoKrAs7itW0iWnlrLOHEriS9DAY9Po7vA4GcrZORm/uK788VxUrgUQWm88BZ97Nzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jU0KSXsGV2Luj8kZvbRKApy12nZQbgY8WUuBLPs4lE=; b=UBKvk9gGdWKk0RNWB/WCWhnkJO56lbx0V4wFI65bjBBEdYIn8BF/xJMjAmiNfCpA3ZTsEGAOwbakWoLRt2w+blrsTYJ4xzFXOZgVrllxiJmAnS1dVhOn1pWTGObl8P/RYRe6DwqeM/XRNcT5rnq4jY/ReBZM0+kz9jY3aJqkMAk7B1J7CTkugLurnRDX7VMh63rITNN46X9n3wgg7YTU2YtgyuCLBUXHsat1UoOX7YAIHH02RXE8kx6UXerekg4nhi9V1Sm7o3uUweCXBSRl7BTMNPOrqnFXbLJJ6CJKYtMuj3c7+esD0a9eEEOkRTWOLNkqZXd5RZOV4xkuAmKwEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jU0KSXsGV2Luj8kZvbRKApy12nZQbgY8WUuBLPs4lE=; b=V0zQeNYLZLYYV9HGkMm/ieERDIPWNbkxG+w95E3KC9Zj1OqaGezQ0OZuoZeFEBGfLFPmnqWLTE9zTTqMKnLAArR36T2Zq8HBqfYSq1O2dAI3WRzNjfprlxvOJpLWBzS6UKy/P+3HOk/YGxU7Y5d83zvhikaIo0e0zDWfqtxLBao= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3492.eurprd05.prod.outlook.com (10.171.187.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.20; Thu, 23 Jan 2020 07:57:35 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2644.027; Thu, 23 Jan 2020 07:57:34 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad CC: Raslan Darawsheh , Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 07/11] net/mlx5: fix block pop VLAN action on Tx Thread-Index: AQHV0TB7dy1M2pmbg0WrANzUhbnciaf34yNg Date: Thu, 23 Jan 2020 07:57:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d09ff1dd-d177-4655-85f5-08d79fd9e83d x-ms-traffictypediagnostic: AM4PR05MB3492:|AM4PR05MB3492: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(189003)(199004)(450100002)(81166006)(8676002)(81156014)(2906002)(316002)(54906003)(110136005)(8936002)(4326008)(55016002)(9686003)(186003)(26005)(7696005)(53546011)(6506007)(5660300002)(66556008)(66476007)(66946007)(76116006)(64756008)(66446008)(52536014)(86362001)(71200400001)(478600001)(33656002)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3492; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ChF1INB5yXysW85baWOQP5C+IeDhKLSF9pillV3NZJ+zni9DdXClNPE+/1/bR2fPbff9yziQY7YxYceIU8hMmq5DZav7wSRwmV44URHOa2t46y/oSvZfaRFnUF31nJxT8+uVXHuYaXQBMSMiBygJ/bQVbWtXXswgmYv5igFeVk01Fkc0+x1s4t7XB7Z3sl5EAYj+MKwFFwqYAkKFdTTyjHe9nWKS1tb/Csvcq1mKBQFroxPkLa5oTGaObkvuOZt7zw82q1mMA6ZvBCdJVg1k/GrEyZdgYfibEHs1993YpkSXof+tKBfDeTgbEVtoPDzL3Pi0glIEOFNPgawuRy9C1OK8kCBueSxMcklmBefwkvNy4VXo6AMmbWzilzsOIcmL2SEgePUov8+dx5HaSJ9nscLnNM3OgF0pp5/DdbwjWdhY4v2SGqVCPMTazgVkzsvi x-ms-exchange-antispam-messagedata: iCngjJqcW7+tTpGWSH7W2c62+oUUiT+KKeRjcECFXfEP0fx4NuUgj4NTBCdLpb71+e/hQ32J/iJ28lQRB9knEjtuoQ8vNmtwUBG94gq/t1dayPomAQxjDM35u2Tx5e2MY24PNtP4bPT47MYXXnnDzQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d09ff1dd-d177-4655-85f5-08d79fd9e83d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 07:57:34.8250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p+ionjwnHU4priSYF+ArbPvRxltphl3mQlMK0dT9gfUCG4YlNLmE1gL4KxYOG/e3CJBmBQkHy1i/gATf+NRryN5muPUrCDaV3uoRSDYlw0Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3492 Subject: Re: [dpdk-stable] [PATCH 07/11] net/mlx5: fix block pop VLAN action on Tx X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 07/11] net/mlx5: fix block pop VLAN action on Tx >=20 > Add missing check in validation function of 'pop VLAN' action. > Action is not allowed for egress flow rules. >=20 > Fixes: b41e47da2592 ("net/mlx5: support pop flow action on VLAN header") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 1ed677f..9dc08ce 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1634,6 +1634,12 @@ struct field_modify_info modify_tcp[] =3D { >=20 > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > NULL, > "pop vlan action is not supported"); > + if (attr->egress) > + return rte_flow_error_set(error, ENOTSUP, > + > RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > + NULL, > + "pop vlan action not supported for " > + "egress"); > /* > * Check for inconsistencies: > * fail strip_vlan in a flow that matches packets without VLAN tags. > -- > 1.8.3.1