From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD948A0535 for ; Thu, 23 Jan 2020 08:56:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5A36322C; Thu, 23 Jan 2020 08:56:41 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30084.outbound.protection.outlook.com [40.107.3.84]) by dpdk.org (Postfix) with ESMTP id 501D6322C; Thu, 23 Jan 2020 08:56:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nDiyBifWGbJxKHJrJSTxTHi2/ZKSiKKdQvHQENeUrtsJ+S4Tw8H0P0Hit6JiBpZbvOu0Kd1yhG7w/WGOl6wzWCTcZSAGRGME1WCL7TVCT9II6MNUXEiZNgF28E7k7ElMvi/zPQcXzZFnIWVpw6X0uiv6efOTj5j1YSDvwgDCjgxSI8TyCc5IAFbwa5xgimXAap2Tvw/y3+UqDHOtqdo1+418BamUdQ9xAmAkzMEby1BR+BGBXqo2g0bz4nDqIVeqtwRUvzsyvf6KjePsGLFd/9aiGUxKv3XC2sbya7dPG2+C3HPFo7nqbObyv+XrLOSIEIAQw7JYWHwZ4t6KeQncPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z1/jGToQ0OaPR32C1VZd8b9IuMfWP8QbSx1YvhEh9ns=; b=X2r+9uAK06OVqnPz86qjTmc8NVt1scDxpI4f+i97+Vx6gfsEXXVSRxq11tUW23TlqeT3FodVEBIiT4KAS2ZnJw6lAcYWnZ00hSQL9xZjuPWs7is7NmhiCL8RPZAfGJcLVcKna77b1GpsPSpJSbgEXZDsFjSJssxFxIWsFkgeQzGrhbHPz97dCAPQ8QUoYuz2gVfSGgm1ThBXMbNXos+eWes5d1r78V4iCW1FW0YEX40HhZ9+7rRYyhQB5gmq/mhM6myy992zsukUwWICO0uA65Ae5YJh2FAAWxpHWRGvG8VSN7xFFL54MtN+blPwCgsUo0X34GVisK8ECJ0p/6O5ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z1/jGToQ0OaPR32C1VZd8b9IuMfWP8QbSx1YvhEh9ns=; b=mpRsIRJCEd27zXyUnFBOPqJWvHSD3P9CEx3tjKsJJUboounxDma+J0748se0aZj8EPu1cF9Q7YUYwDW10tOX+hlLVQurynNLgBTvkw/P6PBt4JN3vWu0u2ftVkpRgjhZcDn7iBNvHknmfiDEK76FLpVnUuwpjXdxsz3YVYqNKnY= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3491.eurprd05.prod.outlook.com (10.171.188.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.23; Thu, 23 Jan 2020 07:56:40 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2644.027; Thu, 23 Jan 2020 07:56:40 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad CC: Raslan Darawsheh , Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 02/11] net/mlx5: fix invalid check for VLAN actions Thread-Index: AQHV0TCaj+k7fbLN90K3yIhE0MNeEqf34uAA Date: Thu, 23 Jan 2020 07:56:40 +0000 Message-ID: References: <7ad0543b9d423640c5213606184237f57fb17b70.1579703134.git.dekelp@mellanox.com> In-Reply-To: <7ad0543b9d423640c5213606184237f57fb17b70.1579703134.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9a2e4ad4-b4c2-4b5f-b316-08d79fd9c7d9 x-ms-traffictypediagnostic: AM4PR05MB3491:|AM4PR05MB3491: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(199004)(189003)(54906003)(110136005)(316002)(5660300002)(450100002)(186003)(55016002)(26005)(81166006)(52536014)(81156014)(71200400001)(8676002)(8936002)(6636002)(53546011)(86362001)(33656002)(478600001)(6506007)(76116006)(2906002)(9686003)(66946007)(66556008)(66476007)(64756008)(66446008)(4326008)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3491; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xay4eFvVEaTfQXV9xXW4SSZRnSRTfsaabUKUKLrBLYGLIQhqEgJLONIcMpVf8evDcwTdmG5GK5di7Qxt0CcdIQrfx9Apu0FWcX3tKTXKaBQqsCrTw5vU4azpNVjvG2BQT9L/R7e2W1e7+IT98NQY5ioXgXTBUAMBTyw6N0fYmvV3JQo10wPsUCJhBhrL2+cHbathKnYFeYp2HG+Y7ralc/T+ecGG9XI1tmyyWZtM/SQVi6Kq/vfkU3s50k3k0oWYSXVuTZut0vyxY2e0oYIiYZcxQJVNjQtcGvwFoilRGnF+XRdTCMT1IwrutKrcqHfqqQlDsnQsJ4hE/QoKzOq6pWYWmLa91yO1D6G+MIM65rejxmyj2j/2hu72Eo/Hg3oN6tkRvZiAgnRgX2K9RUmx2d39N5Nlk00G9dlFzET7VDIPKwZgZ+CXjhgV1Ov4Esm0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2e4ad4-b4c2-4b5f-b316-08d79fd9c7d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 07:56:40.4438 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sGn66yysewd+FjuEyO1fVr8z8rUvkfcgd98oRpJ9n9xVcbvTO4bcLTxvvViJ55OAeEUefNMMsdzKtcCZpehRFzCOipLZabGAEme9f/jCfXY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3491 Subject: Re: [dpdk-stable] [PATCH 02/11] net/mlx5: fix invalid check for VLAN actions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 16:27 > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH 02/11] net/mlx5: fix invalid check for VLAN actions >=20 > Flow validation function includes, after all items and actions are valida= ted > discretely, a check for VLAN and VXLAN actions. > This check is incorrect and redundant. >=20 > This patch removes the invalid check from validation function. > Check is incorrect, action_flags bit map is checked against items mask > MLX5_FLOW_LAYER_TUNNEL. > Check is also redundant, because VLAN push/pop actions can be used > together with packet reformat actions. >=20 > Fixes: b41e47da2592 ("net/mlx5: support pop flow action on VLAN header") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 5a1b426..afa3d0e 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -5060,13 +5060,6 @@ struct field_modify_info modify_tcp[] =3D { > "action not supported"); > } > } > - if ((action_flags & MLX5_FLOW_LAYER_TUNNEL) && > - (action_flags & MLX5_FLOW_VLAN_ACTIONS)) > - return rte_flow_error_set(error, ENOTSUP, > - RTE_FLOW_ERROR_TYPE_ACTION, > - actions, > - "can't have vxlan and vlan" > - " actions in the same rule"); > /* Eswitch has few restrictions on using items and actions */ > if (attr->transfer) { > if (!mlx5_flow_ext_mreg_supported(dev) && > -- > 1.8.3.1