From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA171A0487 for ; Tue, 2 Jul 2019 17:00:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA1611B9ED; Tue, 2 Jul 2019 17:00:40 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10053.outbound.protection.outlook.com [40.107.1.53]) by dpdk.org (Postfix) with ESMTP id 371DB1B9CA; Tue, 2 Jul 2019 17:00:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AfsQAlquJpMnp7AGfXuUl2EtD+RirAQr9XuRsrCxGN0=; b=Ntg/K43Cb6STboAnzdB0989JfjLtOWYw7/4ymWx1e/8SXZIjGyPA1Unm5eO6lbNockUlahr3PGMOq2SOO0DezHEmd0lvHdq3ov2jpgu7YD7l6Bpg8O41d8fsk8vNSbTJ9T+hK6ZTMvk3ejLT5OzFV6Vt5lykz2Dj1S1fGZwwTjw= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3348.eurprd05.prod.outlook.com (10.171.187.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.18; Tue, 2 Jul 2019 15:00:34 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2%5]) with mapi id 15.20.2032.019; Tue, 2 Jul 2019 15:00:34 +0000 From: Slava Ovsiienko To: Asaf Penso , Yongseok Koh , Shahaf Shuler CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value Thread-Index: AQHVJoPoJLIYUCEJJEW//e81OF0Hgqa3gGLw Date: Tue, 2 Jul 2019 15:00:34 +0000 Message-ID: References: <1560937584-447773-1-git-send-email-asafp@mellanox.com> In-Reply-To: <1560937584-447773-1-git-send-email-asafp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: accdc4f1-00a8-4abf-0b78-08d6fefe08e7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3348; x-ms-traffictypediagnostic: AM4PR05MB3348: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 008663486A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(136003)(39860400002)(376002)(396003)(13464003)(189003)(199004)(305945005)(2906002)(478600001)(6246003)(55016002)(186003)(8936002)(64756008)(68736007)(7696005)(8676002)(25786009)(9686003)(81156014)(81166006)(5660300002)(74316002)(33656002)(86362001)(102836004)(6436002)(76176011)(53546011)(6116002)(3846002)(52536014)(256004)(71200400001)(14444005)(71190400001)(446003)(11346002)(6636002)(66066001)(229853002)(73956011)(76116006)(99286004)(486006)(450100002)(316002)(53936002)(476003)(6506007)(110136005)(66446008)(54906003)(26005)(7736002)(66476007)(66946007)(4326008)(14454004)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3348; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ilaX5/ql0baoR6br/pkSxgw+CN3wgpdFCJ+6i+cT2c9ulZ0Qa1YSYy0VqFklyzGplD3nQ/39CHa0NB75TvKOUl8Y/fZmyOONBKBrRSXmBA/THNgt9WtUAz0pubciZS4F1pnJye0aAKmpGg1ZmxKqDtGfalJmFnZrd2Hgm1FtG4tqXDpms5EP2ON3HIb1rK1dJlDHFjiRjfhyPnZ0kls892+X6qFbgMZtKRtVa50Afa8Cl6J032QA/x8fESv62nikLejbCNDXyzgJeadjZZAErfPJMbj+xUg0vUTWQCKvgPkVQA40WbaxCJlZhtx+YCl7PkyQ644B17pMUNb3bSU57Od7XR4l0F1mghtmlUYpfSXB9fjgMQE+nP3cK41tnTeEq176ZjBka6ntGLG7zZj8+Mb1t+4lH1ueDr23KAtY2dw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: accdc4f1-00a8-4abf-0b78-08d6fefe08e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2019 15:00:34.2292 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3348 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev On Behalf Of Asaf Penso > Sent: Wednesday, June 19, 2019 12:46 > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return val= ue >=20 > rte_calloc functions returns a non-null pointer in case of success and nu= ll > pointer in case of failure. >=20 > The return value should be checked and the function flow should take that > into consideration. >=20 > This patch adds a check for rte_calloc return value in function > flow_list_create. >=20 > Fixes: 84c406e7 ("net/mlx5: add flow translate function") > Cc: stable@dpdk.org >=20 > Signed-off-by: Asaf Penso Acked-by: Viacheslav Ovsiienko Thanks > --- > drivers/net/mlx5/mlx5_flow.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 9887018..a5821e5 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -2092,6 +2092,10 @@ uint32_t mlx5_flow_adjust_priority(struct > rte_eth_dev *dev, int32_t priority, > else > flow_size +=3D RTE_ALIGN_CEIL(sizeof(uint16_t), sizeof(void > *)); > flow =3D rte_calloc(__func__, 1, flow_size, 0); > + if (!flow) { > + rte_errno =3D ENOMEM; > + return NULL; > + } > flow->drv_type =3D flow_get_drv_type(dev, attr); > flow->ingress =3D attr->ingress; > flow->transfer =3D attr->transfer; > -- > 1.8.3.1