Re: [dpdk-stable] [PATCH 19.11] eal/ppc: fix bool type after altivec include

[Ori Kam <orika@mellanox.com>]

Do you need anything else from me?

Thanks,
Ori

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Tuesday, June 2, 2020 4:30 PM
> To: Ori Kam <orika@mellanox.com>
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH 19.11] eal/ppc: fix bool type after altivec
> include
> 
> Hi,
> 
> Yes, it's part of your patch. Probably some build files machinery
> missing. I do not have a ppc setup either.
> 
> On Tue, 2020-06-02 at 11:27 +0000, Ori Kam wrote:
> > Hi Luca,
> > Off list.
> >
> > Can you please see that the rte_altivec.h file was added?
> > I don't have a setup with ppc.
> >
> > Thanks,
> > Ori
> >
> >
> > > -----Original Message-----
> > > From: Luca Boccassi <bluca@debian.org>
> > > Sent: Monday, June 1, 2020 1:07 PM
> > > To: Ori Kam <orika@mellanox.com>; David Christensen
> > > <drc@linux.vnet.ibm.com>; Beilei Xing <beilei.xing@intel.com>; Qi Zhang
> > > <qi.z.zhang@intel.com>; Matan Azrad <matan@mellanox.com>; Shahaf
> Shuler
> > > <shahafs@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>;
> > > Maxime Coquelin <maxime.coquelin@redhat.com>; Tiwei Bie
> > > <tiwei.bie@intel.com>; Zhihong Wang <zhihong.wang@intel.com>
> > > Cc: stable@dpdk.org
> > > Subject: Re: [PATCH 19.11] eal/ppc: fix bool type after altivec include
> > >
> > > On Sun, 2020-05-31 at 15:36 +0000, Ori Kam wrote:
> > > > [ upstream commit f5bf02df3145f95b1ee8ed9dee67f4222ac42c8c ]
> > > >
> > > > The AltiVec header file breaks boolean type. [1] [2]
> > > >
> > > > Currently the workaround was located only in mlx5 device.
> > > > Adding the trace module caused this issue to appear again, due to
> > > > order of includes, it keeps overriding the local fix.
> > > >
> > > > This patch solves this issue by resetting the bool type, immediately
> > > > after it is being changed.
> > > >
> > > > [1]
> > >
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> > > k.org%2Farchives%2Fdev%2F2018-
> > >
> August%2F110281.html&amp;data=02%7C01%7Corika%40mellanox.com%7C30
> > >
> f4a48b032b46dbb97408d8061390af%7Ca652971c7d2e4d9ba6a4d149256f461b
> > >
> %7C0%7C0%7C637266028392843046&amp;sdata=fJAaZN9tNjycMH30Gwh8ILZ
> > > %2FjuiYgBVN%2BwdAn6GAbcY%3D&amp;reserved=0
> > >
> > > This patch breaks all ppc64 builds:
> > >
> > > [  136s] In file included from /home/abuild/rpmbuild/BUILD/dpdk-
> > > 1591003733.2dff15dd5/lib/librte_eal/common/eal_common_options.c:27:
> > > [  136s] /home/abuild/rpmbuild/BUILD/dpdk-
> 1591003733.2dff15dd5/ppc_64-
> > > power8-linux-gcc/include/rte_memcpy.h:12:10: fatal error: rte_altivec.h:
> No
> > > such file or directory
> > > [  136s]  #include "rte_altivec.h"
> > >
> > > --
> > > Kind regards,
> > > Luca Boccassi