From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00063.outbound.protection.outlook.com [40.107.0.63]) by dpdk.org (Postfix) with ESMTP id 39CBC1B44D for ; Mon, 14 Jan 2019 08:46:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RqZm+bssb7G8w3PfUGg0ojUS0oW2y4hNm4NrR7qqmIQ=; b=UAtSZ2CWot3SxMFylBdN30cVY2bTI7QiWIoXyR+s+krVBhgOYE5VUDcXl2HzQ4E5eWCXzRcV/LDp6ayqmAzCYJyCC3Hg9u2LRmQz36BonowAshlhRQDkPd08k9V6SwQqe9tl9pm2mWfRkYaGWVxzjG1pVUWLbeCveb+6PJzczso= Received: from AM6PR05MB5926.eurprd05.prod.outlook.com (20.179.2.27) by AM6PR05MB4168.eurprd05.prod.outlook.com (52.135.160.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.13; Mon, 14 Jan 2019 07:46:01 +0000 Received: from AM6PR05MB5926.eurprd05.prod.outlook.com ([fe80::ccd7:b679:e405:93fb]) by AM6PR05MB5926.eurprd05.prod.outlook.com ([fe80::ccd7:b679:e405:93fb%4]) with mapi id 15.20.1516.019; Mon, 14 Jan 2019 07:46:01 +0000 From: Raslan Darawsheh To: Yongseok Koh CC: "stable@dpdk.org" Thread-Topic: [17.11] net/tap: fix reported number of Tx packets Thread-Index: AQHUqxveirlyhoE8LEqDZrXnL6n2OqWuK6qAgAA4AyA= Date: Mon, 14 Jan 2019 07:46:01 +0000 Message-ID: References: <1547368916-22381-1-git-send-email-rasland@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB4168; 6:nr5xJXwjbxmsLKIPCzr0rIsAJolJ0pJkODQAZEumslmsTaVgGO3uxXtZVD0mFmsW9LxKNkI214JLDg733feD632xWc6Px0GYGDk1tD7SesbE0Ir993FavDW00O2Xajn7Z1lGYXqQ1A2GAR1d5dXzIDDHmLFyvoaMnm8SFjg845/kS+G94brenKoz5WU8QdW2moxAVyStJByxAz+9yIRfZPh32sOAdHtSS2WJTyuqUM+hICCK2KIw6xdrd6waAaBYCoIcQUd3B6cUxqJpN7PE1xJ8tm+jYdY2G7rxK1LW2iK0I/+WQ++w3qTX4GmYJyd0FvEUNODw9Y8UyxJ9OreDIfGGMQJ+UvDtG2NwTtt0qAi+MNcoIiGS6k78pW7A2uS/AjGGmsK7V2BM9OqVSuY5iDklV4LkTCVwurpZxTNU/lRIyTuDJ3YOttXZVG8Xx+Aed8KHX5zidr7NeLtBRKW4fA==; 5:4m7E4al1IJgc63eEMxtx/tFfKbOCrNIe9mQ89pIUTjY0oUA0bj7UA2ZyJfOU6CshKmVftts62uSupJ3J06NBwdP9T+J85th4TsI/ndnG6G6wzuWdx5YY/o3gw6+iaO5KbpITpO5K3RKfnSLxwqybfxMqnExQxtdJOsoHlo++wESw1ILZN8qnOrFS+Wd6KIfbUOPeg96QkPHFeZad1gWzRA==; 7:OKf3sl1D4Gz3JkQYHDHOgWEzk3CSppKrD3l8tzs9OO2EmfnFpb3RNaPwZU4FrpFI2VKotFjHN+LeJkoeAnT0yY4Ps4IaHCK0Gf5PFgab6z1EPBfVyCjHVDwUCx/0zIHByUZr+B6NVaA2GWxA3Fktjw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 42e4b0ca-13c3-40c6-db00-08d679f45496 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB4168; x-ms-traffictypediagnostic: AM6PR05MB4168: x-microsoft-antispam-prvs: x-forefront-prvs: 0917DFAC67 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(346002)(376002)(366004)(39860400002)(136003)(396003)(199004)(189003)(13464003)(106356001)(486006)(14444005)(256004)(2906002)(81156014)(6636002)(97736004)(105586002)(7736002)(316002)(8676002)(81166006)(3846002)(229853002)(6436002)(8936002)(68736007)(66066001)(6116002)(305945005)(55016002)(4326008)(11346002)(26005)(6862004)(76176011)(102836004)(86362001)(5660300001)(575784001)(25786009)(186003)(446003)(53546011)(6506007)(7696005)(476003)(71190400001)(74316002)(14454004)(33656002)(71200400001)(478600001)(9686003)(53936002)(6246003)(99286004)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB4168; H:AM6PR05MB5926.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zX5yOkA989Jgiq1yEy6PYAFOn+KP7H9XN6Z37HuAbLz/vbACohzbKsCaFr/+QRlsKEEFicH4nt71kkZvLIKxsLAOPWVZJys7Pwre76orrSaDdevyPGlUE8KxZ6uXJ3/bMj1UsCiyUWdn6TxgwhxhRpb9kB+dCyIsGle8Q3xof8aNhJ/UWFDj0Mwfg2TE4KXI1ANqKtO84ABNaEwRh7LaRFNen0g6Nhvu8ZUuE38TWoFt7cilFIzW92NGx79TyVYMjmc3YvQajltcNQLN8x2/jX6ykX6RQtKtox8WK7OH6gqhM9ir6HbGWsLKP+vIuyPvxXvZpNoR2yKfGnVcTlFtJqCcnjT7KDr7ycaM55T/lTAIS2B9ccOc7Rrl9DPgdj9M4qnb5T2MkgXvPUoXF5X0l1CpJiEJasY7NFGBUXjWC24= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42e4b0ca-13c3-40c6-db00-08d679f45496 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2019 07:46:01.6796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4168 Subject: Re: [dpdk-stable] [17.11] net/tap: fix reported number of Tx packets X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 07:46:03 -0000 Hi Yongseok, I've just double check that, sorry for this issue, but it seems that we don= 't really need this patch for stable. The issue that this patch solves came from the fact that when the call to w= ritev fails It was updating num_tx, but this is not the case for 17.11 so I believe we can drop this patch for = 17.11 Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Yongseok Koh > Sent: Monday, January 14, 2019 6:24 AM > To: Raslan Darawsheh > Cc: stable@dpdk.org > Subject: Re: [17.11] net/tap: fix reported number of Tx packets >=20 >=20 > > On Jan 13, 2019, at 12:42 AM, Raslan Darawsheh > wrote: > > > > When writev fails to send packets it doesn't update the number of Tx > > packets, but it still num_tx is updated. > > > > The value that should be returned is the actual number of sent packets > > which is num_packets. > > > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > > CC: stable@dpdk.org > > > > Signed-off-by: Raslan Darawsheh > > Acked-by: Keith Wiles > > --- >=20 > Raslan, it doesn't get compiled on stable/17.11 >=20 > Thanks, > Yongseok >=20 > > drivers/net/tap/rte_eth_tap.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/tap/rte_eth_tap.c > > b/drivers/net/tap/rte_eth_tap.c index 466624a..50757ef 100644 > > --- a/drivers/net/tap/rte_eth_tap.c > > +++ b/drivers/net/tap/rte_eth_tap.c > > @@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf > **bufs, uint16_t nb_pkts) > > txq->stats.errs +=3D nb_pkts - num_tx; > > txq->stats.obytes +=3D num_tx_bytes; > > > > - return num_tx; > > + return num_packets; > > } > > > > static const char * > > -- > > 2.7.4 > >