Thanks Kevin. Looks good to me. --wathsala ________________________________ From: Kevin Traynor Sent: Thursday, February 13, 2025 3:58 AM To: Wathsala Wathawana Vithanage Cc: Jack Bond-Preston ; hemant.agrawal@nxp.com ; dpdk stable Subject: patch 'crypto/openssl: fix CMAC auth context update' has been queued to stable release 24.11.2 Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/17/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2ecc6d401bac097e91f52ab2137a8aed7b588c77 Thanks. Kevin --- From 2ecc6d401bac097e91f52ab2137a8aed7b588c77 Mon Sep 17 00:00:00 2001 From: Wathsala Vithanage Date: Fri, 29 Nov 2024 20:20:22 +0000 Subject: [PATCH] crypto/openssl: fix CMAC auth context update MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 0241aebfa3bdc53fb36972fb116298adbdbd3957 ] This patch removes an unnecessary cleanup of the shared CMAC context at the end of the CMAC authentication function, which causes subsequent calls to it to fail. Fixes: 17d5bc6135af ("crypto/openssl: make per-QP auth context clones") Signed-off-by: Wathsala Vithanage Reviewed-by: Jack Bond-Preston Acked-by: Hemant Agrawal --- drivers/crypto/openssl/rte_openssl_pmd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index d2cf20c059..b090611bd0 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -1596,7 +1596,4 @@ process_auth_final: if (CMAC_Final(ctx, dst, (size_t *)&dstlen) != 1) goto process_auth_err; - - CMAC_CTX_cleanup(ctx); - return 0; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-12 17:29:38.265596425 +0000 +++ 0034-crypto-openssl-fix-CMAC-auth-context-update.patch 2025-02-12 17:29:34.304945655 +0000 @@ -1 +1 @@ -From 0241aebfa3bdc53fb36972fb116298adbdbd3957 Mon Sep 17 00:00:00 2001 +From 2ecc6d401bac097e91f52ab2137a8aed7b588c77 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 0241aebfa3bdc53fb36972fb116298adbdbd3957 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.