From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A796FA0AC5 for ; Wed, 1 May 2019 16:12:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89C83325F; Wed, 1 May 2019 16:12:45 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 19F482C52; Wed, 1 May 2019 16:12:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2019 07:12:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,418,1549958400"; d="scan'208";a="135955547" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga007.jf.intel.com with ESMTP; 01 May 2019 07:12:39 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.30]) by IRSMSX102.ger.corp.intel.com ([169.254.2.21]) with mapi id 14.03.0415.000; Wed, 1 May 2019 15:12:38 +0100 From: "Mcnamara, John" To: "Lipiec, Herakliusz" , "Richardson, Bruce" , "Medvedkin, Vladimir" , "Kovacevic, Marko" CC: "dev@dpdk.org" , "Iremonger, Bernard" , "stable@dpdk.org" Thread-Topic: [PATCH] doc: fix broken link in programmers guide lpm library references Thread-Index: AQHU+rNEmYP6RqbTBkGimSoTBpb2saZWWC1g Date: Wed, 1 May 2019 14:12:37 +0000 Message-ID: References: <20190424153536.26122-1-herakliusz.lipiec@intel.com> In-Reply-To: <20190424153536.26122-1-herakliusz.lipiec@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTE4ZDIzMzctMzg0My00NWNmLWE3YjktMmM3NTIyZTliY2E1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWXZSOTRcL0FQSFNSVmFudW4yXC9xREpDOXRhZTNoOTRDaVF3UFFGQ1NucDNSYkQ1QWFEdnlFOTU3ZjRrU1kzK3JaIn0= dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] doc: fix broken link in programmers guide lpm library references X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Wednesday, April 24, 2019 4:36 PM > To: Richardson, Bruce ; Medvedkin, Vladimir > ; Mcnamara, John ; > Kovacevic, Marko > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > Iremonger, Bernard ; stable@dpdk.org > Subject: [PATCH] doc: fix broken link in programmers guide lpm library > references >=20 > Bugzilla ID: 235 The fix is good and should be applied. However, if viewed strictly, that `Link text `_ syntax is onl= y required if the link text and the url are different. So in this case you could (or the original author) just use a simple url wi= thout any additional syntax. However, better still would be if we did something like this to put the lin= ks inline in the text: diff --git a/doc/guides/prog_guide/lpm_lib.rst b/doc/guides/prog_guide/lpm_= lib.rst index 99563a4..375e666 100644 --- a/doc/guides/prog_guide/lpm_lib.rst +++ b/doc/guides/prog_guide/lpm_lib.rst @@ -191,8 +191,10 @@ The LPM algorithm is used to implement Classless Inter= -Domain Routing (CIDR) str References ~~~~~~~~~~ =20 -* RFC1519 Classless Inter-Domain Routing (CIDR): an Address Assignment a= nd Aggregation Strategy, - `http://www.ietf.org/rfc/rfc1519 `_ +* `RFC1519 `_ Classless Inter-Domain Rout= ing + (CIDR): an Address Assignment and Aggregation Strategy. =20 -* Pankaj Gupta, Algorithms for Routing Lookups and Packet Classification= , PhD Thesis, Stanford University, - 2000 (`http://klamath.stanford.edu/~pankaj/thesis/ thesis_1sided.pdf = `_ ) + +* Pankaj Gupta, `Algorithms for Routing Lookups and Packet Classification + `_, PhD + Thesis, Stanford University, 2000. However, the fix is better than a broken link so: Acked-by: John McNamara