From: Yongseok Koh <yskoh@mellanox.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
Shahaf Shuler <shahafs@mellanox.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Luca Boccassi <bluca@debian.org>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension
Date: Mon, 6 May 2019 21:46:50 +0000 [thread overview]
Message-ID: <B85DB924-5B3D-419E-8A20-CD88BD47181A@mellanox.com> (raw)
In-Reply-To: <20190503175034.GD2510@mtidpdk.mti.labs.mlnx>
> On May 3, 2019, at 10:50 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
>
>> I think this change might have an impact on the existing users. Does this
>> change need to be documented somewhere (at least in the release notes)?
>
> Practically, there would be no impact. Even if user's app makes use of crypto
> instructions, the build config of the app should have the flag.
On IRC, I could see you concerned about the case where user app derives build
flags from DPDK like apps under the examples directory. Yes, that's a valid
concern.
Thomas/Jerin, where could be the best spot to document it? Just release note?
I think release note would be fine.
next prev parent reply other threads:[~2019-05-06 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190502015806.41497-1-yskoh@mellanox.com>
2019-05-03 12:28 ` Yongseok Koh
2019-05-03 15:02 ` Honnappa Nagarahalli
2019-05-03 16:10 ` Honnappa Nagarahalli
2019-05-03 17:50 ` Yongseok Koh
2019-05-06 21:46 ` Yongseok Koh [this message]
2019-05-07 7:59 ` Jerin Jacob Kollanukkaran
2019-05-07 11:03 ` Honnappa Nagarahalli
2019-05-07 12:02 ` Jerin Jacob Kollanukkaran
2019-05-03 22:13 ` [dpdk-stable] [dpdk-dev] " Dharmik Thakkar
2019-05-06 21:41 ` Yongseok Koh
2019-05-07 21:11 ` [dpdk-stable] [PATCH v3] " Yongseok Koh
2019-05-13 19:26 ` Honnappa Nagarahalli
2019-06-03 23:11 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-05-03 16:06 [dpdk-stable] [PATCH v2] " Jerin Jacob Kollanukkaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B85DB924-5B3D-419E-8A20-CD88BD47181A@mellanox.com \
--to=yskoh@mellanox.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).