From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Maslekar, Omkar" <omkar.maslekar@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ntb: fix write memory barrier issue
Date: Mon, 16 Dec 2019 01:57:02 +0000 [thread overview]
Message-ID: <B9E724F4CB7543449049E7AE7669D82F0B347567@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <VI1PR08MB53761EBBD5D79E15CDE84F308F570@VI1PR08MB5376.eurprd08.prod.outlook.com>
Didn't notice that. Will fix it in v2. Thanks!
> -----Original Message-----
> From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com]
> Sent: Saturday, December 14, 2019 23:30
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; nd <nd@arm.com>
> Subject: RE: [dpdk-dev] [PATCH] raw/ntb: fix write memory barrier issue
>
> Hi Xiaoyun,
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaoyun Li
> > Sent: Wednesday, December 4, 2019 11:19 PM
> > To: jingjing.wu@intel.com
> > Cc: dev@dpdk.org; Xiaoyun Li <xiaoyun.li@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] raw/ntb: fix write memory barrier issue
> >
> > All buffers and ring info should be written before tail register update.
> > This patch relocates the write memory barrier before updating tail register
> > to avoid potential issues.
> >
> > Fixes: 11b5c7daf019 ("raw/ntb: add enqueue and dequeue functions")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> > ---
> > drivers/raw/ntb/ntb.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c
> > index ad7f6abfd..dd0b72f8c 100644
> > --- a/drivers/raw/ntb/ntb.c
> > +++ b/drivers/raw/ntb/ntb.c
> > @@ -683,8 +683,8 @@ ntb_enqueue_bufs(struct rte_rawdev *dev,
> > sizeof(struct ntb_used) * nb1);
> > rte_memcpy(txq->tx_used_ring, tx_used + nb1,
> > sizeof(struct ntb_used) * nb2);
> > - *txq->used_cnt = txq->last_used;
> > rte_wmb();
> > + *txq->used_cnt = txq->last_used;
> I am ok with the re-location of the barrier, but why not the rte_io_wmb instead
> of rte_wmb?
> Rte_io_wmb is sufficient to guarantee the preceding stores are visible to the
> device, rte_wmb is overkill.
> https://code.dpdk.org/dpdk/latest/source/lib/librte_eal/common/include/gener
> ic/rte_atomic.h#L92
> >
> > /* update queue stats */
> > hw->ntb_xstats[NTB_TX_BYTES_ID + off] += bytes;
> > @@ -789,8 +789,8 @@ ntb_dequeue_bufs(struct rte_rawdev *dev,
> > sizeof(struct ntb_desc) * nb1);
> > rte_memcpy(rxq->rx_desc_ring, rx_desc + nb1,
> > sizeof(struct ntb_desc) * nb2);
> > - *rxq->avail_cnt = rxq->last_avail;
> > rte_wmb();
> > + *rxq->avail_cnt = rxq->last_avail;
> >
> > /* update queue stats */
> > off = NTB_XSTATS_NUM * ((size_t)context + 1);
> > --
> > 2.17.1
next prev parent reply other threads:[~2019-12-16 1:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 15:19 [dpdk-stable] " Xiaoyun Li
2019-12-14 15:29 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
2019-12-16 1:57 ` Li, Xiaoyun [this message]
2019-12-25 3:52 ` Gavin Hu
2019-12-16 1:58 ` [dpdk-stable] [PATCH v2] " Xiaoyun Li
2019-12-16 10:49 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
2019-12-23 7:52 ` Li, Xiaoyun
2019-12-23 8:38 ` Gavin Hu
2019-12-23 9:35 ` Li, Xiaoyun
2019-12-24 15:46 ` Gavin Hu
2019-12-23 2:38 ` [dpdk-stable] " Wu, Jingjing
2019-12-26 1:46 ` [dpdk-stable] [PATCH] " Wu, Jingjing
2020-01-20 9:04 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9E724F4CB7543449049E7AE7669D82F0B347567@SHSMSX101.ccr.corp.intel.com \
--to=xiaoyun.li@intel.com \
--cc=Gavin.Hu@arm.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=nd@arm.com \
--cc=omkar.maslekar@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).