From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AD7AA0524 for ; Thu, 4 Feb 2021 14:01:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D21124058E; Thu, 4 Feb 2021 14:01:01 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id ADC4224058E for ; Thu, 4 Feb 2021 14:00:59 +0100 (CET) IronPort-SDR: 152rBouQwIV6+i9byCJ+/DO2ebgIuajJWIxP0E3rp+hYy2lAiIHRUOfEVWHA1VfaojUpe8k7HC ltBPnlh7BozA== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="160989826" X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="160989826" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 05:00:58 -0800 IronPort-SDR: 7NQvovHXKxbyUfrPtHeKMP32EgPKnXmhDBdP2BcgrYkxUxyOH3F8FU5otbumDWxA5SHcVSzhEh YmDlC+fwzXzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="415355761" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 04 Feb 2021 05:00:58 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Feb 2021 05:00:58 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Feb 2021 05:00:57 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 4 Feb 2021 05:00:57 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 4 Feb 2021 05:00:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ncBPQckZd6mugUJHZOCXdHAMfZTeeYXH7e9ua3Pov+v8eUc4GBQSuH3kcBRmRP8RfPKBCo9eyrO1TW1MQVhgFVOSzE4/d/pmj+61hZ51G6m9Vp7+M72mLafQ/7Orx1zONFnvowCYJOVCaHOd6QJvPHq+YUApaV1axGjyYLT6bZylvd6duLFGbPwBH/yGXIjT+lmwz6fSzKFgWydrrXh0JAhIXFIlHP0WIFGzYe8vrgJkojh3LDMt0PvFDq7lHC7zvLaKMSqBSMLlwq6Sj7uMO6cAWI8meJySFTblG7Cp4Ps50nOHXLq8sornBVtavFKGJ6j9wyXPYNZWwL1Baie4hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gHWQkJB3nMZeTAxCG5cvWfise7K4qaCuYE5qeWbwwBk=; b=Szx4NvAgndmuq9D6rRVqa5TRnw+dkOxHu4LmaLDIiIeOz0FClmj4QW0jViID5KDbDoQLwi/lpyDsb1pT+0tr2BjLGVDqDiicJ2a1k7q0i6UC0+X5Oo9mUudyW7+Odal2MGYQTDDIP+E1EbhTc2IuhN8C8GXVdZpCLtc85eHHPJ0t/6+h3gsvjmJYGoaiPSHoZfhGtestbLRP8KCHKNSFa7iS0g5E118Y6Evdt04hKJevclzTmjn46IYkLPsLqPmb7Fh+4eIiF8kgLQ6/3wZV7RHQOnxjK4sU4/OkYY0MW5BCpQdOQUg2rUSa5E/lNmEqVMf413UHZBSlp+qRkdn3TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gHWQkJB3nMZeTAxCG5cvWfise7K4qaCuYE5qeWbwwBk=; b=OJyiGLyjrcVjoagvn8t67suheGE3e8xBSW7Q4Wo74YPCzn0VVh/mszckDsej9k47GYqDae67SB+io57z3J+HBNyKTzD/ZiG2o/kNEUG0GeIdWoLhY8XKODW0os2JHSUlDSQvwnKfQrW5vVl/hrFM9xNiiQ6PP5DlAFbq7PfoIpg= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by MN2PR11MB4582.namprd11.prod.outlook.com (2603:10b6:208:265::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17; Thu, 4 Feb 2021 13:00:48 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::d4b2:ee79:7a97:301b]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::d4b2:ee79:7a97:301b%5]) with mapi id 15.20.3805.027; Thu, 4 Feb 2021 13:00:48 +0000 From: "Zhang, Roy Fan" To: Christian Ehrhardt , "Yigit, Ferruh" CC: dpdk stable Thread-Topic: patch 'app/crypto-perf: remove always true condition' has been queued to stable release 19.11.7 Thread-Index: AQHW+ukuTlASOCMM+UGx5JiglQImz6pH9Q+A Date: Thu, 4 Feb 2021 13:00:48 +0000 Message-ID: References: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> <20210204112954.2488123-8-christian.ehrhardt@canonical.com> In-Reply-To: <20210204112954.2488123-8-christian.ehrhardt@canonical.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [95.44.220.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e222262c-9600-4ba7-7813-08d8c90ce4e0 x-ms-traffictypediagnostic: MN2PR11MB4582: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zQ7khXMY83/vLrr3MXgwJQzqLJovgw1psQ1f0eqQBzkMYrwDu/Bc9lGyMLqNu+PZGypv9GFZD3z+Yb5lb2cjtnViRDPGdBEx/lFRVHvrEGe1ogD8FcqOGRPNaTZPIDCGB0MvBBDNkf+5cUAin7byTTFjbWLTNdGUsPHXqT7VIk3RwaRjdJkGwRharKTC8UX8et81lfWKqLOgwcjNlkH0BpkOUCDVsmOO73H+RZDGMyac3Cxnf1eZOXSgy4BJgAVT4F961yOFliSQuwoi6w7AgyagQCzrdYvYp+oDpiYoWifXa0WTif6aZ7C3mvuI5PFZaVW6jOravguyoBxsJvtBMo7LvFN8eiuhr1Nw4SDjT37rxGCY5m9hqBY2pYJfSFcH0Ie1zDz/wahKNI7FIGyS5zQbyPowq8HOMxF/AcPuevS5hJ21waV32ouLZ5+/S5sfec/rCBXUG+6H3wyCK469675yHEEcjzVlFZTcOXy0TZkRGYpDOCqalSz+3EvRj97epbvhDqeCkmiGLVTj5Y13FT1UC3iqVA1jS1e/yT6Rm0aFus7aMXK/ktAwWKemQY0p+Gcoa3AuDFZOhK44vZSI+niYRRkEPhlzGtOsPsMd8Bs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(376002)(366004)(39860400002)(346002)(5660300002)(478600001)(55016002)(7696005)(76116006)(66556008)(66946007)(316002)(71200400001)(966005)(64756008)(6506007)(4326008)(66476007)(52536014)(86362001)(9686003)(66446008)(6636002)(8676002)(26005)(53546011)(33656002)(186003)(83380400001)(8936002)(110136005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?i+cTYZ6vWMP1sgj4ha66fbmyEDEBOhF+3no459PPEl15x0PLcq0b9VY+?= =?Windows-1252?Q?TPhhQHVp6vGn3Tb/sDjiiqJjL0eENoZ8JdqjHF9HcF2n9QzdtkwPPWJc?= =?Windows-1252?Q?8B3UjR2HuJ5dUE+12UZzUIzd4/op+dEehJhBzTNg0y7tRX4NKHUjAEQJ?= =?Windows-1252?Q?ImfTAvPS+/2m7WQse2lF52h2oeYJY1zVOD95xMUalXdOEg3hd3U0CpTg?= =?Windows-1252?Q?R5ipkH8B5fBeAxWhAWT72QRu643STsO50Un1SRjkeAv1EEHba4yYboyb?= =?Windows-1252?Q?Qq5hgL0d1/v0o8DY7lkEpw9rWt1SmVEqFA/xpHS0ETD/ngryRddLhZtE?= =?Windows-1252?Q?1sT5Kat4BEKsMYTPQYG6+F1y/VHIu29ogQSM+1Lazv8kQUqN+UilOqp5?= =?Windows-1252?Q?XeSXfpVq292NihR2mdnUp/yWj8rbjb67JqZxyhHr2rZsH7bcGCX7MoNF?= =?Windows-1252?Q?4tjnBDsX5VSfJOHDRasCzzeJMdfe3WOeayHt1czIWyVeZZX9vme+BxNB?= =?Windows-1252?Q?0Y/Yp4qKMxMg9q+S3RwHBtVdx40sek/V3NKvkoDQvy7lImtDQe8NdIUH?= =?Windows-1252?Q?gMH+mud2wbb1ApXv7OfqPSfUaF338EIMUJSy5VK6xMfkpZUGUBsrUalS?= =?Windows-1252?Q?F5ocuWord2Pl/jYsNW7OlCU3e+0E1v0tw5DKKSLHdp/3uGPKbSasklst?= =?Windows-1252?Q?SQE7nTm4EOLskRW6F3Ro+cx1fAI1cHBKmiTr4AWpZPMg69VeMS0ocE7T?= =?Windows-1252?Q?7Tp1a36JPyHVjJ/B8eahLmGg+jScXteN45h+Oh1fqM8ueF3dC5WDG/dk?= =?Windows-1252?Q?zHlG+9/tBJ8lSCfUcjwfaVNcefLmSV8CLbpAJd649d64l5lC0TWXcGMj?= =?Windows-1252?Q?HGoJUOWArmeuL5O0Hj12VlNwBHbfkrZdIaPSQ2Ln3T8kuviYgTx62dOR?= =?Windows-1252?Q?m/K1mHPSGYqq0TfFEoikNuDuq/YCv4IJjP8/70u0WWMgl2+6uitmof+u?= =?Windows-1252?Q?2Ec5V1XBgcf0IW8d68DaC9VpYra3lYhY+mqFjKzIxFS7rpSqKt8bhoEU?= =?Windows-1252?Q?86W6tdKlRE+QB3SF1qyOGxATAKFsLq/HEM+W4X2qWCOJKekgoCCQT6N6?= =?Windows-1252?Q?viZV5tG5xYJyGHYb1saG8bA86ZfMeUZpHgGPgINEKJQYnfsT8gTh0QPT?= =?Windows-1252?Q?LchtRmspmr8YzkFsGrwtWE4ZoTyqdZOREzJJzR9P4YGgDXaO+HG7IXKJ?= =?Windows-1252?Q?/yoJASwcpXyaIIgzROuPxMJBE+HBUkpXCxp8GjG/3YvtEHja2klPnIUC?= =?Windows-1252?Q?klSMPRrg0isbPVMIgZVIF/KLQlEFtjwzu9N5dItIeycgJ5655iZHXkoC?= =?Windows-1252?Q?sWLjoQaiPynSi4uHWhMecXglbUa+85Ai69qqgoKzfj3/dVSsEUWtVHiO?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e222262c-9600-4ba7-7813-08d8c90ce4e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 13:00:48.8084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vOS1+miwdS+iJfZkJITyzcC/4W2eVvW4x0/U4F0PNz2vy7HfHL02WjCpeywbntYnFQUmuGWpeAjZdAHqItwB/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4582 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] patch 'app/crypto-perf: remove always true condition' has been queued to stable release 19.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Christian, The queued change looks good. So do you think we need a patch on master to = change this too? Regards, Fan > -----Original Message----- > From: Christian Ehrhardt > Sent: Thursday, February 4, 2021 11:28 AM > To: Yigit, Ferruh > Cc: Zhang, Roy Fan ; dpdk stable > > Subject: patch 'app/crypto-perf: remove always true condition' has been > queued to stable release 19.11.7 >=20 > Hi, >=20 > FYI, your patch has been queued to stable release 19.11.7 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 02/06/21. So please > shout if anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Queued patches are on a temporary branch at: > https://github.com/cpaelzer/dpdk-stable-queue >=20 > This queued commit can be viewed at: > https://github.com/cpaelzer/dpdk-stable- > queue/commit/6c0a0f5e578eb67c9947d237eb5445f2c32511f8 >=20 > Thanks. >=20 > Christian Ehrhardt >=20 > --- > From 6c0a0f5e578eb67c9947d237eb5445f2c32511f8 Mon Sep 17 00:00:00 > 2001 > From: Ferruh Yigit > Date: Thu, 19 Nov 2020 11:58:59 +0000 > Subject: [PATCH] app/crypto-perf: remove always true condition >=20 > [ upstream commit 427ec3b7285d8e8b939f7e5db4976476c931c005 ] >=20 > This is already 'else' leg of the opposite comparison, simple 'else' > will be logically same. >=20 > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test > application") >=20 > Signed-off-by: Ferruh Yigit > Acked-by: Fan Zhang > --- > app/test-crypto-perf/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c > index 7bb286ccbe..b065ab2acb 100644 > --- a/app/test-crypto-perf/main.c > +++ b/app/test-crypto-perf/main.c > @@ -380,7 +380,7 @@ cperf_check_test_vector(struct cperf_options *opts, > if (opts->cipher_algo =3D=3D RTE_CRYPTO_CIPHER_NULL) { > if (test_vec->plaintext.data =3D=3D NULL) > return -1; > - } else if (opts->cipher_algo !=3D RTE_CRYPTO_CIPHER_NULL) { > + } else { > if (test_vec->plaintext.data =3D=3D NULL) > return -1; > if (test_vec->plaintext.length < opts- > >max_buffer_size) > @@ -430,7 +430,7 @@ cperf_check_test_vector(struct cperf_options *opts, > return -1; > if (test_vec->plaintext.length < opts- > >max_buffer_size) > return -1; > - } else if (opts->cipher_algo !=3D RTE_CRYPTO_CIPHER_NULL) { > + } else { > if (test_vec->plaintext.data =3D=3D NULL) > return -1; > if (test_vec->plaintext.length < opts- > >max_buffer_size) > -- > 2.30.0 >=20 > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2021-02-04 12:04:28.540974655 +0100 > +++ 0008-app-crypto-perf-remove-always-true-condition.patch 2021- > 02-04 12:04:27.802789508 +0100 > @@ -1 +1 @@ > -From 427ec3b7285d8e8b939f7e5db4976476c931c005 Mon Sep 17 00:00:00 > 2001 > +From 6c0a0f5e578eb67c9947d237eb5445f2c32511f8 Mon Sep 17 00:00:00 > 2001 > @@ -5,0 +6,2 @@ > +[ upstream commit 427ec3b7285d8e8b939f7e5db4976476c931c005 ] > + > @@ -10 +11,0 @@ > -Cc: stable@dpdk.org > @@ -19 +20 @@ > -index 5f035519c3..99f86e9019 100644 > +index 7bb286ccbe..b065ab2acb 100644 > @@ -22 +23 @@ > -@@ -390,7 +390,7 @@ cperf_check_test_vector(struct cperf_options *opts, > +@@ -380,7 +380,7 @@ cperf_check_test_vector(struct cperf_options *opts, > @@ -31 +32 @@ > -@@ -440,7 +440,7 @@ cperf_check_test_vector(struct cperf_options *opts, > +@@ -430,7 +430,7 @@ cperf_check_test_vector(struct cperf_options *opts,