patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Raslan Darawsheh <rasland@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Kevin Traynor <ktraynor@redhat.com>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-stable] [PATCH 2/2] net/mlx5: use global default miss for E-Switch sampling
Date: Wed, 27 Jan 2021 15:25:11 +0000
Message-ID: <BL0PR12MB24194CC05BCC97967AFB2759C6BB9@BL0PR12MB2419.namprd12.prod.outlook.com> (raw)
In-Reply-To: <11002ac2-1a6c-4be8-76ea-acdb25785e8a@intel.com>

Hi Ferruh,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Wednesday, January 27, 2021 8:50 PM
> To: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Ori Kam
> <orika@nvidia.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi
> <bluca@debian.org>
> Subject: Re: [dpdk-stable] [PATCH 2/2] net/mlx5: use global default miss for
> E-Switch sampling
> 
> On 1/26/2021 12:53 PM, Jiawei Wang wrote:
> > In E-Switch steering domain there was dedicated default miss action
> > created for every sampling flow.
> > The patch replaces this one with the global default miss action.
> >
> 
> Hi Jiawei,
> 
> The impact of the patch is not clear, what was the problem using action per
> flow? What will change when global action is used? Is this fixing some
> problem or is it optimization by preventing per flow action?
> 

The patch is optimization not fix,  MLX5 PMD can reuses the global action don’t need allocate new one each time. 

> > Cc: stable@dpdk.org
> >
> 
> Since this looks like optimization, I am removing the stable tag for now.

Yes,  please remove this tag.
Thanks.

> 
> If it is a fix, please reply with a fixes line, I can update it in next-net.
> 
> > Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


  parent reply	other threads:[~2021-01-27 15:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1611665613-123388-1-git-send-email-jiaweiw@nvidia.com>
2021-01-26 12:53 ` [dpdk-stable] [PATCH 1/2] net/mlx5: fix the E-Switch sample action creation failure Jiawei Wang
2021-01-26 12:53 ` [dpdk-stable] [PATCH 2/2] net/mlx5: use global default miss for E-Switch sampling Jiawei Wang
2021-01-27 12:50   ` Ferruh Yigit
2021-01-27 12:54     ` Thomas Monjalon
2021-01-27 15:25     ` Jiawei(Jonny) Wang [this message]
     [not found] <1611665298-122181-1-git-send-email-jiaweiw@nvidia.com>
2021-01-26 12:48 ` Jiawei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR12MB24194CC05BCC97967AFB2759C6BB9@BL0PR12MB2419.namprd12.prod.outlook.com \
    --to=jiaweiw@nvidia.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git