From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 906D0A0561 for ; Wed, 3 Mar 2021 07:47:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 775801606F0; Wed, 3 Mar 2021 07:47:10 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id B3D104067B; Wed, 3 Mar 2021 07:47:06 +0100 (CET) IronPort-SDR: yarR5v++FnQLklhWnrieUsPTgnkgy30D4aYKM3XF5b1Hu6gpWj47+5g+y55329HoR/YerQ22Nz zLQ7wyB2mcAQ== X-IronPort-AV: E=McAfee;i="6000,8403,9911"; a="187178491" X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="187178491" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2021 22:47:03 -0800 IronPort-SDR: r/TNmCw01/QKffVNSiC3p79dHOibWexpeFgPk+zl9ueY8mQQ4C0TIVEco5z6pgpT77xizh/czL azLaz7G08xWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="445123177" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga001.jf.intel.com with ESMTP; 02 Mar 2021 22:47:03 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 2 Mar 2021 22:47:03 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 2 Mar 2021 22:47:02 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 2 Mar 2021 22:47:02 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 2 Mar 2021 22:47:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTruwvwIu4eWNeZhYkelbzUoQw4mwUpJZUNcnkKXa9KClnsoZJiUKWqASFoVGlyz0fQxRBkRx5p1pZlAa7Xdken4d4dHz6Np6FsPcbb4nTUzdLuy1pfrpFfLn4ZdTxIPT4hfNCRyuP+31s05LQJe+/7TFeUeMkhEIBr3GAK1M0+pU32wZ1xnsXFxLnG1FWu7vjKESBu1ZVIijF4+Ft1VSZhHVVFg7+O4jfrNCet8fwF0Wc6Ly7PnqwwYk1PH3bvjpvjSmYb6/vYyzJECmccq10BA6FRkXiC8bUfzk8P3QzwOm0n3/qeEqvQbsAsWZHGQOML9aCL+PdQ8/6ndSoVSqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6K7f+fdvTVjt2MWxcyAk2wmG5M1PUg5WozyjEbwe7Eg=; b=grHT5je2QjDDeD5wSgnCh3Wpk+XRkGhYvm6iqebp71wJa+I+vZ/0hlXkN4TI46rEZntxco++nKn4D3OUblNyh5hsnyomKNYY9oxWc5Omenrh61HKVYr9V/P8R5iOyZTHcp7wXOW7lsV4Xegyj6QbmG1jlMhoBuEEmRE59TQJz59f1q61wtQz7hBhuQg8GQBiYc/DMBRGtjuVyaoxdwoKqOxs/7Iwetq8RmtIMywG8cZRw8Y06mKkdn0Qq5UyJTWyzXKzo1jMU5DjRUlXeWAJ5n3nXYSvWnUrJnGpTVch3F+2iyZ0J/4r5WQVeC3opkDm/P17+ZQvWlgkueLCNStHXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6K7f+fdvTVjt2MWxcyAk2wmG5M1PUg5WozyjEbwe7Eg=; b=ey08wNdqdmPNrPbuUGiTXIU2BD87LwPpKQf/M75VxgygxTw8VzN0hp/EQgmUaEGyfXn4PDQ9Hmgmpms5M+qBvDh+UexbkaoGB8+4Db/OetGj0Dxgjp82YYjcf1SmBPTzL5l8rLdDd7jLu1PLoZJeHePZMB3XL+7V4sBnA84J9i8= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN7PR11MB2644.namprd11.prod.outlook.com (2603:10b6:406:ac::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Wed, 3 Mar 2021 06:46:45 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::31fc:8a3:8229:1619]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::31fc:8a3:8229:1619%4]) with mapi id 15.20.3890.028; Wed, 3 Mar 2021 06:46:45 +0000 From: "Yang, Qiming" To: "Wu, Wenjun1" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" Thread-Topic: [PATCH v1] net/ice: fix wrong RSS hash update Thread-Index: AQHXDydSHzcWuoKJ1EmSEDn68KKpEqpx01mg Date: Wed, 3 Mar 2021 06:46:45 +0000 Message-ID: References: <20210302053105.63783-1-wenjun1.wu@intel.com> In-Reply-To: <20210302053105.63783-1-wenjun1.wu@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f2ed2ca-68fd-4c40-8d71-08d8de101cf4 x-ms-traffictypediagnostic: BN7PR11MB2644: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GQaaQcZpTUQjaaHFfwnnMJnl5rrGTK8wbiJp7vYFkwPvfdfY96KqWjC6/vDo/j2qhwD+X5RBDhWyPXelY4epPnHMBbnjAYF70g7K0c4xbyTK+0pWsJY7i4KPmPXuWwXY7WTrgiAML71E6J6glW0XzsWjasC2u1QDVOrGy0BKzZhZqgB667to326ypy7vcUf71CTKML22Nvia+eBkLFFbd3W8kLIU5+eppFWTg0075ect4vXfRH9EbB4y0/M+XwsBcpKvTQsJJAUu6dcvOx4y0WJwoelEMHZ56yVt+jyP+Tdr0zBKMEXM5hHeuJc/1QC50TxPn/sOV7Ij8om/Q0bWVEvkVXALExCklInHNBuA58iEmUfr0OVJ8kgHbFL1+/7LS+BAYbca1q6o3E5KhoY/3EiAlGlYxHKo76VJ8ZNTBoX6CmL7HAx3diaDfQhTVYbTmQpuZudQW10N3FBTEgaD2LAixkyxHWnZ7MbPBR358138wJah6Sm5fH4LUFYQSYcaI2Futq6BKnjWfYHLzF01dQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(396003)(346002)(136003)(366004)(39860400002)(2906002)(6636002)(186003)(83380400001)(71200400001)(52536014)(110136005)(5660300002)(26005)(478600001)(8936002)(86362001)(66556008)(64756008)(4326008)(66446008)(8676002)(316002)(76116006)(66946007)(66476007)(33656002)(15650500001)(7696005)(53546011)(55016002)(6506007)(450100002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?uM0pcGHLKxYdWJX0hg1Gnt4UuZGATIp8fyGmbh0Ui7HZyTmDpYPRaOCn1FHK?= =?us-ascii?Q?xJ93+GfpZ6eEmB9PhrKUbpFh4yFjqstCAFHp+6ASL6TiHxKFGE0y8WR6A11r?= =?us-ascii?Q?5wNJ+AECSWqOJgVwsljNJhqVuMurTAV3S8KD5eZE/4eXav+XJvl4EbR75SE6?= =?us-ascii?Q?gw7hXWQT0hEbPWrdrU2hqz7uML0CSFB1zNpEIa29f28p9FeWtYAHEuxjS40L?= =?us-ascii?Q?M447zUoYmKjw7x2ObHX0VR/bt/zIGjppBtVt1uipNiNNGPA0lE9U423ujP0e?= =?us-ascii?Q?08lMLA5wRj/I38JLT0rbjF/im+wTrksfKCtFqEzGLZNoI7sZgOPNMOl9jTQA?= =?us-ascii?Q?hgG+Xxi/GEyX19V8xpwODoThGY97+LpRAjjXPVZ0sCXELoHNLhY85yX1ezRG?= =?us-ascii?Q?72eoXgIPrltlCu/FnI8w1Lio0DPDgw/Sqxd4hsoZt5CW3Uv0uSuwG/0cuVFi?= =?us-ascii?Q?qU4v6dSsEtgrqTf+Pw2lO33Tw/Sg/mgMywfi+m8/LZsyWIS47BHki8EVzKpq?= =?us-ascii?Q?fQK8hJlYpa5DnG47CD6Nc+0ycg9xBadFSzi9I3i91zQRTjgU+WbQU1QwUOeq?= =?us-ascii?Q?jgNhWy8pRvb+dLBFyMbXbHODpMytwN4Socsc+RpejiHsx8M5MdHgEGCooqPH?= =?us-ascii?Q?4yOMXQst/uvXX5Ob6c4ltmTPqi/ivwVjLq5VNitlDqQShaOoTMLdfpk0ITvd?= =?us-ascii?Q?ppyP6mihmVsSqRjRodoVhHvyd0VeTeWm2rjzMexaBcanIqwvGgeGErLJVnti?= =?us-ascii?Q?/g7OFFtwmDWaNu4yr/pQMSmhKxmxDtxLz93AbzjNGL0iv5jmqcBixitXHcp7?= =?us-ascii?Q?mTOz2GFyJ9CBXFxvTTIRlAhuZaudgth3DwgH6pjH3/2PTB7IuNb6mi0AqTOM?= =?us-ascii?Q?DKcWk8ajdy1TBjAFu+CHMoz+vtRaqYynidDP6HYE3bP4VbUr/EcHKrOeLsRE?= =?us-ascii?Q?o1PWbz6RENjMEg414nWy+Tcno2GktE/bAf0ycoC+i9XL4UfaKbhWDJchZbka?= =?us-ascii?Q?os4towXVYpWPb3iiYLLu9mzcr3EhjuLcpmZ5ympyxYNmXjnBdKIKw5Icle/6?= =?us-ascii?Q?ye8AdMTjfkHmB01aYn8aqBpfVjKnWWgWkLpwXx+eHJ9bjDkgN3LdAfiGod04?= =?us-ascii?Q?qd39IT5XIA6AKjXUSUwoQRpW71aoNO+1xsqujULvU0FSC9WJEpwoE+PvLoSw?= =?us-ascii?Q?EzNxdGHS9Y9ZG7aGV1I9kEFUOGqczbTLAChn/L/68PNXa8Y7ZdmWru16+YtN?= =?us-ascii?Q?W4r4dx2y5nAFLao6UB2UKJ+jW2qItiFR1pfGZ8hdezQ2jaM04wH0ZVVFRDqe?= =?us-ascii?Q?8a/uFZfX0yDfEXPCpYHxWlNv?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f2ed2ca-68fd-4c40-8d71-08d8de101cf4 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2021 06:46:45.8497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pV3My6s3GxtHYhL0hwmZfpXQG4w3WGhwoA+LrQPvUAhj2W4ceqDiwVOGnkCnENpL3OefavcLRD7U2oCfF/mQBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2644 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v1] net/ice: fix wrong RSS hash update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Wu, Wenjun1 > Sent: Tuesday, March 2, 2021 13:31 > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wu, Wenjun1 ; stable@dpdk.org > Subject: [PATCH v1] net/ice: fix wrong RSS hash update >=20 > This patch removes redundant judgment statements to disable RSS when RSS > hash function configured is not supported. >=20 > Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user co= nfig") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenjun Wu > --- > drivers/net/ice/ice_ethdev.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > f43b2e0b2..a84b3d3c0 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -4461,9 +4461,6 @@ ice_rss_hash_update(struct rte_eth_dev *dev, > if (status) > return status; >=20 > - if (rss_conf->rss_hf =3D=3D 0) > - return 0; > - Why need to delete this code? It's a code clean to avoid to do more judgeme= nt in the next funxtion. > /* RSS hash configuration */ > ice_rss_hash_set(pf, rss_conf->rss_hf); >=20 > -- > 2.25.1