From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15D81A0352 for ; Thu, 6 Aug 2020 11:16:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EAF7E1C0AF; Thu, 6 Aug 2020 11:16:00 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B768C37B4; Thu, 6 Aug 2020 11:15:57 +0200 (CEST) IronPort-SDR: DkgdchO7IrMq+9feA+qvR6VlnIz/ploXBicqAkMJNTlyXu2ZfxARIUIg859+AKNTxVxKy1JgcV uf9H6bWFt5wA== X-IronPort-AV: E=McAfee;i="6000,8403,9704"; a="132310065" X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="132310065" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2020 02:15:56 -0700 IronPort-SDR: Kp7H1q1edWDAn+DlkczQreByIxwgYsd7HOK9OpsiRw4QhzRdZRcw1o0ojBgyI5hWaxbrp9viy/ LRDTnhaHATHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="325320746" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 06 Aug 2020 02:15:56 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 6 Aug 2020 02:15:55 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 6 Aug 2020 02:15:55 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX116.amr.corp.intel.com (10.22.240.14) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Aug 2020 02:15:55 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.55) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Aug 2020 02:15:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d9KtbZ/CPJCzt4+o79T64lPqOvCdYa0CG2w2sPoET5y7D+1h+HA+R+bwJXiB2q8jPRj+B6HULBQWkUilRwzAYZ8TDDHNGDB3szX09GpQDziHbvOBw9uDPH29lQXl0CfqaXUTYzAyD4JVct4YFr9Fe0PwLYdGCe6WY4ymIb3SD5KINSxdraaD/t4bzuWZJ7hxxfHN4mtKaAHRdXhlQDY5SJIXazdkEFCBHMtYLnfSkLCa4RDx+JMx7xyX1d/IrgjoOJbVnjH5cuVukc3xOfbjrd3iSrD7YJ57UsE2j19OncqtsU6tffWOgr+Jl0CjzaudUQw+xF2EdLf1EjcG6UqmOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kzG574fs+Wc65+NhtUHqHy5pb25IuvBIqAXmpAwIyzE=; b=hBJMHwq52oqjjwuo4WvlUAfB7SVlW8wEAQvCwBUhefV4PYTMoK/mgZ4z0BKciVlnR2I3fSN2SrPfXtQNajqUKWzivYYUTkpUF1F1xqnjKmLpW1+IoFeVxKPF+56i2CCmOvyQp82Tyl4++h9SLnMt+mtB63dq2eUvk9Lg2rV1R0uLJaDIv3HbXwmS3h62BlqMlE+y99jga1QdZrgPClRO3KdMPnVTfGtEitN/8g493BzceYCokN8gmIoR94T1Ecf/PKyp7kBoQurpSpdS0964st9oPU/rbsp4OdrQFMAMVXizFrHC++bSGTwgul+jaQ3nIjM6OKoaPnL/ITOzSsLDJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kzG574fs+Wc65+NhtUHqHy5pb25IuvBIqAXmpAwIyzE=; b=eOB2/4NM5dxfSHSK9007sC+IaFmlEV5nStSdAx4c3/4B7we7EjPO0l3yVL0F3+9HwDgPkm9fpJxQwvy9V2gDrGCaFSPgrz8klxvqZiQeuyF4ZF8P+dgFewyfxQSWy0xjwSrq3BW5m6BZ9dX6i8a3Ajkz78KVD+yhdb/VV1C7NaQ= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN6PR11MB1651.namprd11.prod.outlook.com (2603:10b6:405:e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Thu, 6 Aug 2020 09:15:53 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::6c3f:f9b6:80fd:5f29]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::6c3f:f9b6:80fd:5f29%4]) with mapi id 15.20.3261.018; Thu, 6 Aug 2020 09:15:53 +0000 From: "Yang, Qiming" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ice: fix incorrect firmware version Thread-Index: AQHWa83z2urHpkTmxESq15rEXi5r2KkqzHUA Date: Thu, 6 Aug 2020 09:15:53 +0000 Message-ID: References: <20200806082519.71727-1-shougangx.wang@intel.com> In-Reply-To: <20200806082519.71727-1-shougangx.wang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cdccc9db-ffb8-4fb3-5898-08d839e951ce x-ms-traffictypediagnostic: BN6PR11MB1651: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HB7DH/uOjVq8ULzFm4JeMNrQFKLN5bUmwo82XRpw+jIds5rgUJJ5giDBOjxon34DobyvduzBGPtl3tdBFdyq6Rg2enwWFvnLS+IJbR1DrCuyewk45D/SNdUOje4c3ANBjJkRZFZB1qqp4TwUa5ul6jAouZLV6w7gu2MdZx2D5jkU+ZXRIYjQbS4UnRwnBqBJZ1vccd6bVReX/xufeqj9oGo7isi2uvN8pTrZyX4PQDn6+24n0FycYN860z4zMNaA5R6jFpoiYMLv++kiG9ExJlBhtoDo7szDX83ix7TrFUFkGSkZJkqUCJLk8K+mqVSA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(396003)(366004)(346002)(376002)(2906002)(66446008)(64756008)(66556008)(66476007)(52536014)(8936002)(83380400001)(76116006)(66946007)(5660300002)(8676002)(4326008)(7696005)(316002)(54906003)(110136005)(71200400001)(55016002)(33656002)(9686003)(478600001)(86362001)(26005)(186003)(6506007)(450100002)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: mHm4DP2OabaxqwsVqx2hIpLO49waxk5GYM0ZSjmqS6KXTo+f79Jb2E7wO2CAQumiV8A6hX3xXmnoAfH8Q2DqCSxJjrPqYbJ0gH8TbLy862oRasvV3krQzCH2arKcQmEC/u1M/YPJxUwoSmN8TCZoAGf13wV20eBOAkpUCWfeZo3UH3bwUpY0Z80Bb1nk8MSWUTRV8ldnFXXEoriapNugD4zu4uJs9e3w05m88bYlSasP6ulRjk68rNqnS/Bz/gqDGJp5sMlwtUIZSgNTOjKJMCPdaXe6F4YVl65yeU39F8f7DF0Uvh7KJgyz1IQP716LJGnt5iNd4ycroZUPvn7e+uP+DYxPQGdIcr1nk7XSc/D5I2aaafV32pxe8ECZrs/sh9tcBLUV5Giq5yK9f2L8L3dE2iy10YqY+wjGAOnl1d5UfByj7QAvO9732jh5FNWqHO3IrGptDi7bYceV6IW/Cy9sdhNPWtBPzbW7x6oZ04GOH+iH6gmsO7AOuUr6aaUIh3Ds9ywZDaCzSvcK9KO2pTtuaB08/GBBoAYH6zZNCWOP1dn5uGbql361MNnbDu9flm/P+5gJxZqn83U70xFFJWyIm3RiWmO+L7ynUifgZIxEnCx0hTU/ZBB4SYej0lIUUoOF5Akoujd0W6UFACPzXw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdccc9db-ffb8-4fb3-5898-08d839e951ce X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2020 09:15:53.3407 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MjBNy4SFfOtlXChGRHzJ3P5GjDK91UATlYcGkSvfVS+bs5HJvu+MEtMpHrTlYTlbzHCd1VLP1Edpkx5T/jZSyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1651 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Wang, ShougangX > Sent: Thursday, August 6, 2020 16:25 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, ShougangX ; > stable@dpdk.org > Subject: [PATCH] net/ice: fix incorrect firmware version >=20 > Kernel driver shows firmware version as hex but ice PMD shows as decimal. > This patch fixes the issue to make consistent with kernel driver. >=20 > Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted format= ") Fix line not correct, should be the code you fixed > Cc: stable@dpdk.org >=20 > Signed-off-by: Shougang Wang > --- > drivers/net/ice/ice_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 8d435e889..88b8428b9 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char > *fw_version, size_t fw_size) > build =3D hw->nvm.orom.build; >=20 > ret =3D snprintf(fw_version, fw_size, > - "%d.%d 0x%08x %d.%d.%d", > + "%x.%02x 0x%08x %d.%d.%d", > hw->nvm.major_ver, > hw->nvm.minor_ver, > hw->nvm.eetrack, > -- > 2.17.1