From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC195A0567 for ; Thu, 4 Mar 2021 03:19:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEC0222A2CA; Thu, 4 Mar 2021 03:19:35 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7566C40147; Thu, 4 Mar 2021 03:19:32 +0100 (CET) IronPort-SDR: ds7QH6pH428bQXm0Y9YJM9aLqOEcCyp1N/cfMjMJxaCvTJgXdbDQVOHN/oaWyCa+4fTh1Y3HmF LyojqR/wpzKQ== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="184910930" X-IronPort-AV: E=Sophos;i="5.81,221,1610438400"; d="scan'208";a="184910930" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 18:19:31 -0800 IronPort-SDR: GaU6AohMYguyMD9lbk3G3AIU7z5GpAzwqtENwBEASyZP0N43/5Q3QoE4SUopvHfl+r4PjaIMJB D+w1UB7w0juQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,221,1610438400"; d="scan'208";a="518492833" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga004.jf.intel.com with ESMTP; 03 Mar 2021 18:19:30 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 3 Mar 2021 18:19:30 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 3 Mar 2021 18:19:30 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.51) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 3 Mar 2021 18:19:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J25LglUdd+0MmSBXcjxvKVeLSbLJlFSREgp+omwTPFZ7Nx9VNNlqejmcU95vxZIR6Mt4rYEn8SDyK/1fRmKzqIJOn7aM/A3wHDRKFFLQK3gM2FVWaWuL/j9dNf3p310YxMTHcLq83uQViRhJ0tKibmoo1GKUG4PVvq7fEbG8UoaC/8W5gbppR3IRBFaW+L34Alo3UdHhursb9TTkvZg0cwhvq8pUUM4sOOuTwlBA32r9p809zz7VzZjDyQPGURv4e69LQSpwN2QnvoJigpmv2XiqJLqalHAH200hUkC7jKjbXkX9dXQLTnvYw8YeV1LgYFUOnoK/0YLIFwW6zYs2uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B2KpgiXezeD0+u5I7HD0LWorXFbL21cTEy0r3lNiGL0=; b=hRp6CVXcCB+1TDca1V3tm2A5axtAX62S816UXzbi15p92f8jiuQLU9yR1WFgVVlshKoFT3V1ropMtK+c8otojJ0w5pHh2Y3dNMFp20kGvGUzP33KRj54Vfd5jsRmTrPObpx/w2DINzqwSTf/DwHYvgovaDNwuZGByF/j4bxWBq2QKsQkK2W+1PHdNW2w9X40WPyAACjoREaHam+Igh7eJ+TPjvfaWhd50VwfXR2RO5KqOB/cMvVCuyKgBjv//iU4fxnrSgVop17leEqIKcRHm6qZoq8ttCnEdof0BJknltHEfuNqhdRdLrjiyqZJjRupa5yv3EpIb7KcJRk3E/rwOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B2KpgiXezeD0+u5I7HD0LWorXFbL21cTEy0r3lNiGL0=; b=ErkRMFSQSvvE/pGKGZ+HoyHIEk+ejnfyjgJQzmOb8dzIOFnqK7AjlceFN9dBIapymmVI4Vxs+yoGnBcYIA7DYyXmcBcAzcIg7Ake/EqFUJbbUhQ6ScfmRRT9p/3FbO/wfqdI8ynbBGpTA6jg8ANRI2AMWkS3eeDulQnr3yDzAv0= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN6PR11MB3940.namprd11.prod.outlook.com (2603:10b6:405:82::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20; Thu, 4 Mar 2021 02:18:53 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::31fc:8a3:8229:1619]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::31fc:8a3:8229:1619%4]) with mapi id 15.20.3890.028; Thu, 4 Mar 2021 02:18:53 +0000 From: "Yang, Qiming" To: "Wu, Wenjun1" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ice: fix wrong RSS hash update Thread-Index: AQHXEATbRpGluryYX0K7YmGBxLJ7QqpzGVCA Date: Thu, 4 Mar 2021 02:18:52 +0000 Message-ID: References: <20210302053105.63783-1> <20210303075648.12399-1-wenjun1.wu@intel.com> In-Reply-To: <20210303075648.12399-1-wenjun1.wu@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.197] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4890ed47-0826-4439-0fec-08d8deb3db44 x-ms-traffictypediagnostic: BN6PR11MB3940: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c5HorCE6DetMgMlqZgtfsdwUeVXyzsOsGRvRhSMxCsr76N2E4DquqSzKWDhyziOzQqwwMS0zIG8G8vz/8j/Cyi9kWaaz/IroygUD0eZ9hs5o4jUDWYhsnKKyksKmKqyVRMB1Aa+6RyXEITh6/wVqoAj60SycZ7aE48hBgd4tYw/NJMjN90de/B/hAlMQ0WxrMNySaG6g4huDZtA/G7H3yeo59BXG3USQSrx/lJPM2Q1m5Tsmp6rEHnIYXRzLqoYRCLV5WJvkSd1Kll8e6vmaJbbiYmuG/XfXTg3ExmJoX9YtzR81eb8JgV00Tp7oOJHypdGID41Q3GgYY1HVjS9ljhw6DKpAr6aUQjvWHqPRUfWE2R7L2TgiKExrLjbSfL6K7b/8M6Txrg+rh36lST5+BO3HlPHzzSNcPReOCaajUG29xzZGQs/omdGDA65D0olovwvwPKagEZr11jiDIC5Kv/l4sHFIXxALLFPm+Wq3xsrXTRNlEanvp9QrifFS/ZpgppSEYA2g34G5aBsjknYDtQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(136003)(39860400002)(366004)(376002)(6506007)(478600001)(52536014)(83380400001)(55016002)(8676002)(8936002)(71200400001)(5660300002)(110136005)(26005)(76116006)(64756008)(66476007)(66556008)(66446008)(53546011)(9686003)(15650500001)(33656002)(316002)(66946007)(450100002)(86362001)(4326008)(6636002)(2906002)(7696005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?em1hZHM5NTFJZW5aYjhVajFaWmtOd3lOa1cvYjAzOWpHc1lvdXpLc1Y3?= =?iso-2022-jp?B?MjdkNEJhVEVmODhleUthV1p1Q3lIN3Bqc3hOd21MUUdyNFBBYVVHdzdk?= =?iso-2022-jp?B?Qm9OODQvcm56TW5xYmgrd2h0ZVd1bGVjdEExRVlOakZIU0p6TEF0SWxY?= =?iso-2022-jp?B?VTZUM1dEQjFlZzZTVExjQ3FLRXl6aFJyZ216OE9kazArTDhmUmdqaE54?= =?iso-2022-jp?B?bWc5NDhHVmxNYWx6MUhrRXYzQzc5UjMvN1R3Z1BndjlybEVXTFIrN3ZF?= =?iso-2022-jp?B?VkpTRTJuZFE2MjRvK2dqMVdrTTVnblJ4bVpXOHNTMzVOL0h4MHo3Y0R4?= =?iso-2022-jp?B?di9tRVRWZXkwMVE0anpTdkRyK0plQ3R2OEVPdEdmZE10eWdJNjhhK3E4?= =?iso-2022-jp?B?cEpvV2RJRlBSdHhzSlV3Q2djd0dnZTloaXU4YzVTWVlwMWo5Y2o5Wkd2?= =?iso-2022-jp?B?dnFnY1VkclUyV2tnNkJDOWhkL3VCTDM4RkxoM1NsbVhLUm9TaU1VdVBm?= =?iso-2022-jp?B?Sm5SZUN3VzJnTGZleDkrTFRXUU9WVHBxY0lPUUwyVkpVZjAzRHRPMUF6?= =?iso-2022-jp?B?ZkFiWm5tWXhXd3N5T3dwcWppdVFocEtWL2J3TWxpaWd6MEx4K3dKWWxT?= =?iso-2022-jp?B?NHYvbGxKZndFVEZBck1obzhxWTZ6SEt3MThnUmFsak9tWENsR3pEbCs0?= =?iso-2022-jp?B?REF2ZXB5UHIwd1lKLzdadXQrSUhnRHlGY3REREhxbHVMVTNZanU1Ynpm?= =?iso-2022-jp?B?NFd4aTFIbFdJb1lpSFdqV1BOMkpWa1Jlc0l2UWt2L2h5Q3JlRnhUYWhV?= =?iso-2022-jp?B?RTM0dCtLUW50dEVrdm1MTkhla3oxczNFd20xRThrSjlMNExEUGFHT0VJ?= =?iso-2022-jp?B?bUNxSktMdVBjS0FkdDF2U3RsQlF0MWNINjRWMjBvQ0hkS0lZZ2R0eEM5?= =?iso-2022-jp?B?TlhCTGtJak1BdzNvOFpPdTExNSt1c1M0YWMzeS9SUjR0VXhxV2VlQzJU?= =?iso-2022-jp?B?czE4UHloSWVxWDNPdVVQd0RIN2VtOVRoM2o2MjZXcDNDK0JWS3MxS0dC?= =?iso-2022-jp?B?cFpuNVZMODFqYURtUmFSamxEcy9icExZWTZ2a09oWVU4WjhnUWNQSEhS?= =?iso-2022-jp?B?TG5SSlpnY0NrRW1jMjU4ZW11TjVQZEVFQllWQ1k5TU9ZWHBHMmF5STli?= =?iso-2022-jp?B?Q24wc0JhcFJPaTBRV3RNK0RtQzB3NmMvdHhDRVJLR0w0WkRYZXpGQk9x?= =?iso-2022-jp?B?MGRFcm52dS9vTGVINWpBNzVKZFJHejROb2JDd3ZuRWRWaDVmeEV0dUkr?= =?iso-2022-jp?B?cDE2bnMzNGFCaGVPVzFObDAwZjh3NkVxK0JEcHg1NWZGYTYxMmMwdHZV?= =?iso-2022-jp?B?YkdURmFuRDVFQjUzVUM0WkxMejUwcjZOSnJLSytKdGw1Z2x3V0lvc0JO?= =?iso-2022-jp?B?MmRWT3pQT1ZIRThZamVHd0Y2dk12TnV2ZmR0Z1Z1N1kwZzFJS1VmMm9H?= =?iso-2022-jp?B?RWlDUWpFekZLby9OOSsrNlhBVElsTXcrckJVZXZRcnFYbFd0NkQ0NUx5?= =?iso-2022-jp?B?SDFXcVNtTVVBWUkvQUhISXE1dENjeXRrZm1INFR4RDlBZHNkV1U3aE9E?= =?iso-2022-jp?B?WG9JdDJVV0RYZlh3ZVA5VWlxSmdZQmR6Um9MWm51NkwxVjJCRVFtOEt2?= =?iso-2022-jp?B?SDJ5L2ljR2tib0Y4VnhUSnJUNWJ1TzZZbEJtOURUTDlYUWQ0NHVNOFRp?= =?iso-2022-jp?B?dTNEWVc4YkthMHpCTUtVN0V4cGlRZDUwcFl5SExlYnllVmZhWlhxSkZT?= =?iso-2022-jp?B?NTFsdmYxcXhaSGVUTnVsYU5hNURWam1jZHgxYTlTdnJlMjdoaE9jQnZD?= =?iso-2022-jp?B?L2c0RGxzVmZDajkvbmxvdERBenUrdUl6V0MwUE1lcHQzMXRCbGFiWEpQ?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4890ed47-0826-4439-0fec-08d8deb3db44 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2021 02:18:53.0589 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AcNoHsw2NkwrETLmowSC4L3+JArK8g2wdVOrSg9I8LbVywJJFBk/+I4Dee6I7+dB08I1jDNFwSnHV5zDchC6eQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3940 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v2] net/ice: fix wrong RSS hash update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Acked-by: Qiming Yang > -----Original Message----- > From: Wu, Wenjun1 > Sent: 2021=1B$BG/=1B(B3=1B$B7n=1B(B3=1B$BF|=1B(B 15:57 > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wu, Wenjun1 ; stable@dpdk.org > Subject: [PATCH v2] net/ice: fix wrong RSS hash update >=20 > This patch change redundant judgment statements to disable RSS when users > need to disable RSS or RSS hash function configured is not supported. >=20 > Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user co= nfig") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenjun Wu >=20 > --- > v2: do pf->rss_hf =3D 0 when rss_conf->rss_hf =3D=3D 0 instead of direct = removal to > avoid unnecessary judgment. > --- > drivers/net/ice/ice_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > f43b2e0b2..299162286 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -4461,8 +4461,10 @@ ice_rss_hash_update(struct rte_eth_dev *dev, > if (status) > return status; >=20 > - if (rss_conf->rss_hf =3D=3D 0) > + if (rss_conf->rss_hf =3D=3D 0) { > + pf->rss_hf =3D 0; > return 0; > + } >=20 > /* RSS hash configuration */ > ice_rss_hash_set(pf, rss_conf->rss_hf); > -- > 2.25.1