From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D4A7A0350 for ; Wed, 24 Jun 2020 17:09:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 595821D9F9; Wed, 24 Jun 2020 17:09:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id E74DC1D9DB; Wed, 24 Jun 2020 17:09:32 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05OEpQ1m022572; Wed, 24 Jun 2020 08:09:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=RFtxR+vwrdii98+lwBjJbQZjkfdbgb7sJbcXRT57Q5Y=; b=rrkC52W7b/cQ/fQmaEYZPwep/P1KnyC4zDOtXAvL/PgD5/e+i+UMBDnxtCjOu8CsZRvM jYMPpz1WE+05PsdKqPShfmFMYLhmRfpyGsCL66fEN/a2PI+b3ZRU95Lzh11nRYu/q4Mx JGZs0oCOIwYggUaPMwd0rTEuZtEtEoLKgDcdAL0l4gVvLD+m+w/ifNR5Oysg8OwFHDPG 6HWrY2qtHRRddNaIqdgBvMoeXA1XyJwlETCdVs8SPGd46cDanHYbo1ogGclaTXAvZYQm 1ZOczrZ8kD/TQlYSzwKS3WRVibjY/jiY96xKRM3ofLeBX7lSLGtL3IbH3gDAhxb1saGu bA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 31uur1bbqr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 24 Jun 2020 08:09:29 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 24 Jun 2020 08:09:26 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 24 Jun 2020 08:09:26 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 24 Jun 2020 08:09:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=My9if7AePpDftzM3wQH+IcCc9NQkgiM3sla1a9t6h9ihZFxSZlw1ljFkooJ6L3bC8jsAAbR5us7hhp0+dYpD4B5sfzeTii7mWai7Q5Dyburiq7+y5u9gY+0HsvHALhWx5kIuy7sBWmFQHmEaX3cLerDJz28LhHrPTe6eEutpz8BCE4n+C+6koojkS/UNm33p+JCA+SVQqPd98OiObFSAneJbpdUN3b8QznUcDV2+W53J3EfYPQivmQvZeNJ1STkTIF7oal9GvCjDKbZSYJf/E/HHfcexNGyXqUh6T5yHyHK7oWDdRKsLv9SQC1RVMMQqKm/1mbAu/gMrm9SZXXb4AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RFtxR+vwrdii98+lwBjJbQZjkfdbgb7sJbcXRT57Q5Y=; b=VicEp4UsoqWACBfQcThYcpH8coLaf5Nv6UPZa7RfhMV9xJ+27w23VXR4CF9zWGJE+H8PLYrgYIla5pBLeWviPzivV3TBgLolT2PHOgWeliEOrze7Y4hHqkJ84yhhNaOK5Luf8BpkB6vmOuwwsawTbDwh9B51wS7MXMCbNU1L0IM+j9d6H3nACQhFbSogK/nICuoj3+OlLzNkUEvVWjGrODVnwk2ROJOYvSNLQGFsY3jGVOGmKEeY51MdpYzzBHGU0b7G+7beUWpcU0XxyHdjSOY7YgV89AmdGhM+zGFhfESTbxP+O/H9T3rY+GlbOxIleqh9no4452Ep0tBiNkw66g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RFtxR+vwrdii98+lwBjJbQZjkfdbgb7sJbcXRT57Q5Y=; b=QkEvYHfNK4lEsIrrR+MpmTc/n2/790Lx8HMURv52w1AyJ72P2WA/Se4qFAHscd1zixJUxu8W57uw8WwP4541JW6t2uBInCThrbsdTdjASA5zN2ZvFyOexuKRA1LrXddjX510QFpTgNBa0VfaiQWqyiyuN5GhpbAJ4PtXYGyAmi0= Received: from BN6PR18MB1140.namprd18.prod.outlook.com (2603:10b6:404:6a::10) by BN8PR18MB2948.namprd18.prod.outlook.com (2603:10b6:408:a6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Wed, 24 Jun 2020 15:09:25 +0000 Received: from BN6PR18MB1140.namprd18.prod.outlook.com ([fe80::f8a7:bea6:bfaf:e4d8]) by BN6PR18MB1140.namprd18.prod.outlook.com ([fe80::f8a7:bea6:bfaf:e4d8%2]) with mapi id 15.20.3109.027; Wed, 24 Jun 2020 15:09:25 +0000 From: Pavan Nikhilesh Bhagavatula To: Honnappa Nagarahalli , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "hemant.agrawal@nxp.com" , "akhil.goyal@nxp.com" , "ogerlitz@mellanox.com" , "ajit.khaparde@broadcom.com" CC: "ruigeng.wang@arm.com" , "dharmik.thakkar@arm.com" , "phil.yang@arm.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal: generic counter based loop for CPU freq calculation Thread-Index: AQHWPdygjLj/aAIvw0ilNdZjJL4dIqjn9LQw Date: Wed, 24 Jun 2020 15:09:24 +0000 Message-ID: References: <20200608213417.9764-1-honnappa.nagarahalli@arm.com> In-Reply-To: <20200608213417.9764-1-honnappa.nagarahalli@arm.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [122.171.121.97] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 64ad6d47-1d0c-4509-4a82-08d818509530 x-ms-traffictypediagnostic: BN8PR18MB2948: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0444EB1997 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7UxEvxdSTFQlNDd0vbcjx5rDjzbJBrdce2wsPmeU5DwWjoZ+zZNu4rDOfIW0lt1uUzdGdZxAhzdHGaHVM/i2rhQQyPATl3C1nLiRh9Pvy8KCK5RdFBI+5AerTeZPD94lQoHA18NG9YnGOcC/5TEYcerE5moPeqv4+7yxyEt9p4/rc+eyIxYL8v2r+M0qlOtByRradYxQFge5J1cqJSDPf1VA/uQFzn5rO42JZLw/o9cwymDDQB4H+9XeHjEt2jrz6IMtGz2p8W9qnyUeHPBDCixRX6kLSrA/E6GLpW3vUaHcvduaCT7JRNKdz1I5dTk5wEsFlpvd4PqR0PQdtkUZL5DX9l8se/ioTzHuLGxQDPzwPxYpY2N/mOU57U00EiyUy05/WeatqWkpb9zrj9RwL2qDpAZgixt9/GE2sJjAtXPMCSKMYgzCzWsrZVGoxyXZnKz7bvStF3d19/F8NOkP1w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR18MB1140.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(66446008)(6506007)(9686003)(8936002)(26005)(52536014)(5660300002)(55016002)(2906002)(66946007)(76116006)(186003)(66556008)(86362001)(66476007)(7416002)(71200400001)(4326008)(966005)(478600001)(33656002)(7696005)(54906003)(110136005)(316002)(83380400001)(64756008)(41533002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: RQ2/8sgl1qHFt5LUTmYSxh9SHH/HVtDcQJYmek4W8iMpsRwWCB4X+jFa8SEBb7bZKcz1Cg55DM0IG8b1nC+Y3hgfByrMh/oeFA07AMnuIKroupNjT61uzzthJg3XhKjVQby6GB9OsG3ptzeLt7tGHsDfgOiwlNvjkgTJY8tE/WkDSwWEhaCXAj7x6CHrr55chCloOPWCSpMPyEpSipmaimPgwF2p+OxPRKO6fRy+JgtEd3EcuQzLuv9/R4ZhE1OYfcmocZIJQ19rZtUVG5Thp2+aig+BmU2sPZeJWqOQymtbLdN7kXa3IzHznRrLkSSm0gu6HMfgbbnK3b7NBX3Vwru5koEEDVPrlDw8aNneeTBl4jEYtG04ipc7n8rVGC1YnbGtIIt/C2IEz4qW5BE0+8oglmZfzmn6ar5eTwdaB/Du2yNCZFmm6n7GPa9R7B/bLGRDUV46ljpsJrXpSEAOcstTndt7YyQmXj1I4YyON/nFtXT26ljqi7tAOJBTRJXi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 64ad6d47-1d0c-4509-4a82-08d818509530 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 15:09:25.0756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9CzsNYojje3Q/QdL0HbKhnF7PJ0jJuUZXcudg6M13vLThA0rna4QioLhPzwRio9UkQDJZwKL0oIa4m1jz8f2qimFF2FkCMU+pfjyH9gHU5I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2948 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-24_08:2020-06-24, 2020-06-24 signatures=0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: generic counter based loop for CPU freq calculation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" >Subject: [dpdk-dev] [PATCH] eal: generic counter based loop for CPU >freq calculation > >get_tsc_freq uses 'nanosleep' system call to calculate the CPU >frequency. However, 'nanosleep' results in the process getting >un-scheduled. The kernel saves and restores the PMU state. This >ensures that the PMU cycles are not counted towards a sleeping >process. When RTE_ARM_EAL_RDTSC_USE_PMU is defined, this results >in incorrect CPU frequency calculation. This logic is replaced >with generic counter based loop. > >Bugzilla ID: 450 >Fixes: af75078fece3 ("first public release") >Cc: stable@dpdk.org > >Signed-off-by: Honnappa Nagarahalli > >Reviewed-by: Ruifeng Wang >Reviewed-by: Dharmik Thakkar >Reviewed-by: Phil Yang > >--- > lib/librte_eal/arm/include/rte_cycles_64.h | 45 >+++++++++++++++++++--- > lib/librte_eal/arm/rte_cycles.c | 24 ++++++++++-- > 2 files changed, 61 insertions(+), 8 deletions(-) > > > uint64_t > get_tsc_freq_arch(void) > { > #if defined RTE_ARCH_ARM64 && !defined >RTE_ARM_EAL_RDTSC_USE_PMU >- uint64_t freq; >- asm volatile("mrs %0, cntfrq_el0" : "=3Dr" (freq)); >- return freq; >+ return __rte_rd_generic_cntr_freq(); >+#elif defined RTE_ARCH_ARM64 && defined >RTE_ARM_EAL_RDTSC_USE_PMU >+ /* Use the generic counter ticks to calculate the PMU >+ * cycle frequency. >+ */ >+ uint64_t gcnt_ticks; >+ uint64_t start_ticks, cur_ticks; >+ uint64_t start_pmu_cycles, end_pmu_cycles; >+ >+ /* Number of ticks for 1/10 second */ >+ gcnt_ticks =3D __rte_rd_generic_cntr_freq() / 10; >+ >+ start_ticks =3D __rte_rd_generic_cntr_precise(); >+ start_pmu_cycles =3D rte_rdtsc_precise(); >+ do { >+ cur_ticks =3D __rte_rd_generic_cntr(); >+ } while ((cur_ticks - start_ticks) < gcnt_ticks); >+ end_pmu_cycles =3D rte_rdtsc_precise(); >+ >+ return ((end_pmu_cycles - start_pmu_cycles) * 10); I think we need to round this of to the next multiple of 10. Sometimes it is off by one EAL: TSC frequency is ~2399999 KHz Similar to http://git.dpdk.org/dpdk/tree/lib/librte_eal/common/eal_common_t= imer.c#n54 Pavan. > #else > return 0; > #endif >-- >2.17.1