patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Apeksha Gupta <apeksha.gupta@nxp.com>,
	"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 6/6] app/test-eventdev: fix eventdev queues
Date: Thu, 2 Jul 2020 03:27:16 +0000
Message-ID: <BN6PR18MB114032FEA74DAC857AFFEC40DE6D0@BN6PR18MB1140.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20200701060626.28627-6-apeksha.gupta@nxp.com>

>Subject: [dpdk-dev] [PATCH 6/6] app/test-eventdev: fix eventdev
>queues
>
>In pipeline_queue test case, if event queues are greater than the
>max event queues it will fail. 

Nak, it should fail. If sufficient queues are not available how would the pipeline work?

	/*
	 * The pipelines are setup in the following manner:
	 *
	 * eth_dev_count = 2, nb_stages = 2.
	 *
	 *	queues = 6
	 *	stride = 3
	 *
	 *	event queue pipelines:
	 *	eth0 -> q0 -> q1 -> (q2->tx)
	 *	eth1 -> q3 -> q4 -> (q5->tx)
	 *
	 *	q2, q5 configured as ATOMIC | SINGLE_LINK
	 *
	 */


>To handle this check is added.
>
>Fixes: 032a965a8f1 ("app/eventdev: support Tx adapter")
>Cc: stable@dpdk.org
>
>Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
>---
> app/test-eventdev/test_pipeline_queue.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/app/test-eventdev/test_pipeline_queue.c b/app/test-
>eventdev/test_pipeline_queue.c
>index bee4ac0344..b958953bf9 100644
>--- a/app/test-eventdev/test_pipeline_queue.c
>+++ b/app/test-eventdev/test_pipeline_queue.c
>@@ -325,6 +325,9 @@ pipeline_queue_eventdev_setup(struct evt_test
>*test, struct evt_options *opt)
> 	memset(queue_arr, 0, sizeof(uint8_t) *
>RTE_EVENT_MAX_QUEUES_PER_DEV);
>
> 	rte_event_dev_info_get(opt->dev_id, &info);
>+	if (nb_queues > info.max_event_queues)
>+		nb_queues = nb_stages;
>+
> 	ret = evt_configure_eventdev(opt, nb_queues, nb_ports);
> 	if (ret) {
> 		evt_err("failed to configure eventdev %d", opt-
>>dev_id);
>--
>2.17.1


  reply	other threads:[~2020-07-02  3:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  6:06 [dpdk-stable] [PATCH 1/6] app/test-eventdev: Enhancing perf-queue packet flow Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 2/6] app/test-eventdev: Removed unwanted checks Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 3/6] event/dpaa2: Add all type queue capability flag Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 4/6] app/test-eventdev: Fix pipeline atq Apeksha Gupta
2020-07-10 13:08   ` [dpdk-stable] [PATCH v2] " Apeksha Gupta
2020-07-13 11:44     ` [dpdk-stable] [PATCH v3 1/2] " Apeksha Gupta
2020-07-13 11:44       ` [dpdk-stable] [PATCH v3 2/2] event/dpaa2: Add all type queue capability flag Apeksha Gupta
2020-07-21 17:51         ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-07-23 13:36         ` [dpdk-stable] " Nipun Gupta
2020-07-24  5:24           ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-07-23 17:04         ` [dpdk-stable] [PATCH v4 2/2] event/dpaa2: add " Apeksha Gupta
2020-07-22  1:13       ` [dpdk-stable] [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq Pavan Nikhilesh Bhagavatula
2020-07-22  7:48         ` Thomas Monjalon
2020-07-23 17:02       ` [dpdk-stable] [PATCH v4 1/2] app/test-eventdev: fix capability check in pipeline ATQ test Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 5/6] app/test-eventdev: Enhancing perf-atq packet flow Apeksha Gupta
2020-07-02  3:25   ` [dpdk-stable] [dpdk-dev] " Pavan Nikhilesh Bhagavatula
2020-07-02 14:46     ` [dpdk-stable] [EXT] " Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 6/6] app/test-eventdev: fix eventdev queues Apeksha Gupta
2020-07-02  3:27   ` Pavan Nikhilesh Bhagavatula [this message]
2020-07-09 13:05     ` [dpdk-stable] [EXT] RE: [dpdk-dev] " Apeksha Gupta
2020-07-02  3:24 ` [dpdk-stable] [dpdk-dev] [PATCH 1/6] app/test-eventdev: Enhancing perf-queue packet flow Pavan Nikhilesh Bhagavatula
2020-07-02 14:46   ` [dpdk-stable] [EXT] " Apeksha Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR18MB114032FEA74DAC857AFFEC40DE6D0@BN6PR18MB1140.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=apeksha.gupta@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=nipun.gupta@nxp.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git