From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 496D1A0547 for ; Thu, 1 Apr 2021 03:58:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39126140FA7; Thu, 1 Apr 2021 03:58:02 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 8B25B40142; Thu, 1 Apr 2021 03:57:59 +0200 (CEST) IronPort-SDR: 3BmT66hoBYqyU4gtVVB2CIWFwHhURGXZM0DSMEW7tCxKj2WkNJdlKTW7FzgCFNG3lKR+qY3oPC VL3CYKXg0viA== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="191609458" X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="191609458" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 18:57:58 -0700 IronPort-SDR: VppjdcCCUcCWcawZtkckny/VhmQasc36StZ5ypni4pUymN8NzTAS6oT39Toznxziu2DE9uTT4+ s/nHTN4Vc/bg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="610720737" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 31 Mar 2021 18:57:57 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 31 Mar 2021 18:57:57 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 31 Mar 2021 18:57:57 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 31 Mar 2021 18:57:57 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 31 Mar 2021 18:57:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BgmJAPKGqbu8nbNGtLXUr8z+cnJVJtb7jZ4B7UGqzPGakUiOQPRKL1Jovzg2ifcyiCQUDXsDHoce8Xvj10DffpxtuBWkF4+EcFtmqm5VsVHgp+BtuGSYy2HLMEsI503eiNp9HPAWCprBJzbLQKVQUwCx9uy8VHv0oXQyKrUxhq36KSldQdc/aAu3MWpk3r4m0SjWaDjnf86c8pYOFuDqAe3WX0eEn3UuWNjohkRAnIBBlfGLI8qHJyLLXxl/0ZQWfgn0dJmd52tH9qz5PUwUDffw8vcFAQcRUJYDYLO2fiPOWpp1UOEzY0R3q+RxI5nmmyBdWiw4H/d5ygpzWPuhow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PbyE5Fc1unGO1OiGPNjO/EYDIQniPS5sQtS7yizq2J0=; b=UrzWWVeawdbR/PweZzqMVTEiMUx2BO2uEbdOSJUukU9CXe4YGBicwGjnER5J5QL6YmdwBKVa/nt1V5dA/S/+AQbJoJJXUzb1wmVKNSe61Shk2h1kxSEOKWtyn9POhcSJM55ymDItP4u7TZRl0WrhrfXERAI8ShKbYjfsIZJ0LazMdJ9KiaNoXlHvXPQPznBXxruAx4zuiBJILP0S4wo3LQyo1ndecKY816FSc3Hh6kxcs5+sABBgU9hWPOIWuH8NR/oEF2iRkCY/THKazagiVgnIPEEyIrVd46JKuuKoXeXhdpPUyQDEHiM7Q9ZEDamZVusdj5NKDatSrzq9fCqP0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PbyE5Fc1unGO1OiGPNjO/EYDIQniPS5sQtS7yizq2J0=; b=Va1KeVKwB6T4FCQLnFUX3PdgTP/NBCc2S/D6EzAde/VnP1gidrN/uJzbyEokZhXq8F0eFcQduf3Q8Yp+bZ4WbJobLQygPmDetfaSz0RLvnoOIFUoFKbZRXoV8sxYZjthoIhzOS8z9bUqAK7o52XnEFU4CCy0Ge6uLnIYErjfCT8= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB3971.namprd11.prod.outlook.com (2603:10b6:405:7d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26; Thu, 1 Apr 2021 01:57:50 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.3999.028; Thu, 1 Apr 2021 01:57:50 +0000 From: "Wang, Haiyue" To: "Zhang, AlvinX" , "Guo, Jia" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/igc: fix Rx error counter for badlen packets Thread-Index: AQHXJpTOu6f5Tk7krUG3UnFXoqwzyaqe5Z+g Date: Thu, 1 Apr 2021 01:57:50 +0000 Message-ID: References: <20210401011648.17888-1-alvinx.zhang@intel.com> In-Reply-To: <20210401011648.17888-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.56] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 086a6e01-0a1b-4689-14fd-08d8f4b18e45 x-ms-traffictypediagnostic: BN6PR11MB3971: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KiX0ISLw9NQVomQVkuV0jrPtMMx3wFtmACUD4lw243FCneKU1Twu8xu6cS7sKAQ/TnFIqzQobR0uFC2hmFYhoLxagJKaQuGHIFz0+iJAuRU4nZ4jOaY0mdyXZ5UoM/u5KWUompf4H5XcCSQIU6ytqvBigm3g+xaVW7sc+mAgJqKVnIH9IzFQ8N35H5BhEAfzG2/2bdOtS0z0/vO6kVYuQu+XGLaqrGbh/5IBI4BbxB8KNNRYpS9TGiYVZVuFky+WNMZU1esgiaGWL05C1oudSbuwZ2tyZUtz6I7rpATjkisVNSdR07nATwocWqOeFX7Wzm0vzXT+az6/5p2qhNeZo5t7u1gWMsePMbSjcliYv8dTz5rzPiFmcvNRzZDK7a/KbuQUBinBRR3GQ8RbSI2tHVQthC1zZVoFx5HE6LOgqccgUQ5/3p6DweKXnwROV+UfrcA36S2Qd2/7Fw8dzaG+SlZn8+cZAt6x7ZXJR4C3iw+5GiT/D4zuOrc7oFOCWiYuN22nOGZ6G1sQucpqf7mJ/IkPl4jCB+exmjQAhDz0ZeNcmU6sLW9VlMyaAd8UGVjXipIkc5EFFyg87FzjsJ8U/2cJ/speQq4t/8kfhtqJ29Vs9QXMr2CrmjgbohUh04+KFyauV1okOdjrEQvgk/MZudF5Pg+xcQtksAUTxtmKwMo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(346002)(376002)(366004)(136003)(39860400002)(83380400001)(186003)(52536014)(7696005)(26005)(6506007)(8936002)(450100002)(33656002)(54906003)(9686003)(478600001)(53546011)(2906002)(71200400001)(66476007)(86362001)(38100700001)(64756008)(55016002)(110136005)(66556008)(5660300002)(6636002)(4326008)(8676002)(316002)(66446008)(66946007)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?SiqgJKSmjOpkByOSW9rxTOTxgTePGXIlbxmdEaIPD+tQJEEv/uBkG2xBuGUC?= =?us-ascii?Q?AkYhjf7roUuwcD9rngccUit4cL5xBh4vfZ9jaxxvp6PaQcYwT/leTrX2+t5r?= =?us-ascii?Q?mb2WLaF5HiU3GiPa1c9ZmHlkcM7D0HHt7sKslyTmfeNHTJxuRzMb77/DpQzO?= =?us-ascii?Q?evy+w586JaFFlLzhXJUkOnFbYCTO08iHwET+4+TfchQEsEiDXp/ZL7b9uMMq?= =?us-ascii?Q?idFSi09Pf/+Uw4IBnRBVgc+U6+TUaPL9cLcoKTO7m5pOLCAnUJtwaoA7se1R?= =?us-ascii?Q?TE3YpZ1pjAZ7dZ4vaU9yF2ILc3MFdOmiP5nGnlbQq+lGBMHsJFMKStcXtVOz?= =?us-ascii?Q?KdjXOikRJtUXqvTNLgk/99ADMNxSVYABY6nq93l6BjFDJN7kgCBLR3VBjbco?= =?us-ascii?Q?CL+TuX9+/wCvoBriRG/ZuWHEjK1j4WTtqrb8sw4FgC1XESRz6BQ5e9uyR6pw?= =?us-ascii?Q?MEIwuty8QXYHjsy2/P70yIIqJQ7BRoH7H1Yn3oCfLnKz+KEfGpMNFxfn441R?= =?us-ascii?Q?rydP+7jbEy4E80wb/Vc39aPoyuDmkfsQVIk1AqTZyoGglvWDo9g/YZni8JZ6?= =?us-ascii?Q?j3Wyli+H4+otZskS8Moxb6IgWfwZY5RnSy2N/kqQKbkDVVtmbRABB6eOuWHc?= =?us-ascii?Q?1YA1S9OFIZd1temc686zNY11MHcozNbMSDxfOKcojdjydAPUO01cyXHS0UFp?= =?us-ascii?Q?nR/D0P70bNFHxco/B+3p2zoYXnadHPhAiZDry2uuFXXmwdAl0l1y6KwY1Hsr?= =?us-ascii?Q?CTfBMfCiTwqvwa8ZNmFVOIN/G7J2fbwW5KsLS4N55MJG7FY3fjl4c/nzqCn6?= =?us-ascii?Q?GzTNlSUZb0K5tWMDC6cXgMeZ7s/oRsJ7fhIn91QKE/XCo9SjebBDihFvvAxb?= =?us-ascii?Q?7FxAt0tmdl/YWEiuTtfBalzpUBbb+3RvfWZv+kjx0Z6HUd35ml8giiQiIq3u?= =?us-ascii?Q?IAal39xK9uMXY8R4UjzLnTYNfvJN5XkhR6L1u5sZxR/ijEgHy0eT+gYrr6/L?= =?us-ascii?Q?rVrIJdFezE+5JhnR1rCTfWe/jfl+iHr7s9YYECshd3Yn8USRjcl11xjm2TYi?= =?us-ascii?Q?hqDlgPrzzN9/DD6DlXdIfh0lqVnwrJc4/PLoA7UBAjs4bOJGB3+6WPVuxYFP?= =?us-ascii?Q?0OBPs4tclzQCTfZFk84tIxWPzVN5rj0ZEwromoKa7AfaOi9EFz+Sq20UJ7e2?= =?us-ascii?Q?/tVjDexM4veBjnwi4mKCWeFSg9QuuoPccGdW4H9PB2OBTNIUKyfuqrSmCRxD?= =?us-ascii?Q?AxFJ5PL4sDXRDXFIvcF2MC3ZeUHUL9cu2GtWUo1GP4+VIFdouF2QnuR4NBH6?= =?us-ascii?Q?DGk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 086a6e01-0a1b-4689-14fd-08d8f4b18e45 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 01:57:50.5186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s5/eIW80/zScHyTFxvo21iut1By4YWrw69UVLZwrIhc+ueVvmLhgGWYq7VK/7tNidzhpm35MBOB8622srZi3Og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3971 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] net/igc: fix Rx error counter for badlen packets X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Zhang, AlvinX > Sent: Thursday, April 1, 2021 09:17 > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [PATCH] net/igc: fix Rx error counter for badlen packets >=20 > When the size of the packet is less than the minimum or greater > than the maximum, the packet will be counted twice in the error > packet counter. This message is not clear, the packet should be minimum or greater, but not at the same time, why twice ? Please describe the new stats you use more clear. >=20 > Fixes: e6defdfddc3b ("net/igc: enable statistics") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alvin Zhang > --- > drivers/net/igc/igc_ethdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c > index 0ea6e2a..c398701 100644 > --- a/drivers/net/igc/igc_ethdev.c > +++ b/drivers/net/igc/igc_ethdev.c > @@ -1901,8 +1901,7 @@ static int eth_igc_vlan_tpid_set(struct rte_eth_dev= *dev, >=20 > /* Rx Errors */ > rte_stats->imissed =3D stats->mpc; > - rte_stats->ierrors =3D stats->crcerrs + > - stats->rlec + stats->ruc + stats->roc + > + rte_stats->ierrors =3D stats->crcerrs + stats->rlec + > stats->rxerrc + stats->algnerrc; >=20 > /* Tx Errors */ > -- > 1.8.3.1