From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45C85A09E4 for ; Thu, 22 Apr 2021 13:45:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9AEB41D3E; Thu, 22 Apr 2021 13:45:24 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 71DF641CAF; Thu, 22 Apr 2021 13:45:21 +0200 (CEST) IronPort-SDR: YI5zqGnUmwvApnfTSJo0IEe1wZtxyoBz4/z5RXFarSym84+NPg2HOQTMEOMRFlMw3GaB1gej2h /cN+X/7iNjng== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="195899871" X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="195899871" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 04:45:20 -0700 IronPort-SDR: 0A06wRigqTytHZ4nPJlGVzuUTAuYOoynBA0ev48zM0OHAJ9LGjxnbtshjwOQgCXgFlLD0NEQF1 BXqSQaQOivEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="401806823" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 22 Apr 2021 04:45:18 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 22 Apr 2021 04:45:18 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 22 Apr 2021 04:45:18 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.54) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 22 Apr 2021 04:45:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oKiEs9/e3DFp1AgyO6AG8DILbQcuntNWtaCTu1e5xLpXoi/rdgQXHrOEhyrvboGjhp+tpoT3CT9YBgXgUt42pSt6K7qkZ87HaSYRvJOvm5GtQZiuznXzkN0xlGt/iR+n2pTjF0B7OorDByIsAQZruwtKMc/0I0qjlWjwgzVv5Vffr7PFhRewd6QG5SUXcwEAXbognnjdzehxf8LyehiHUaS+IB7BYbzFQJROxJ0j6MQ2yBkfonBXdvJFWYrJbpusG09Zav1Tc4JQ4AfkHc9ZbPLs4MeUAgUFa5B2XdgsBVw+jAklyd0g0pJ0BvtN/2DufEggzQYdu75agp2UswKfbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XbVyPMnzR6lWuiXQop7jP/6mT59GsD2veN/PNIm6c+8=; b=Fhp+j1SvX8Ym1EXT1HuHy+ujGImp7+VlNwsCM7k7PaWDgWBRC0LsO9PmFrMdXgj7lWtBbwWkH76gvB2r1tjReOnMbbhvntQxtBhC4yNn5hOJGUV1VZvCuVwExk9oAd44M2pwTaK+qsjp4GtrVZ5mIQwHUdUwjXSmTIPtv8vQYkDq/7Pmj0dRa1e5y7OMTKxq8hHRQ2zKXQGXrwUZqpaYl9SSOH5hfx9hJkxzuQ8yeuImxpcrs8Oti39Irgv1o90FNm6pw/adqOzcb/0CgsfePdTfDNw558dkW3zby0bQEfpQmEPeT5DOzhDLpv6p3+XafQ+hkkOVhD8/mF9fX/iRTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XbVyPMnzR6lWuiXQop7jP/6mT59GsD2veN/PNIm6c+8=; b=lhXfXZ2BX241PzoMit3O+RTRZnaIT6f1Dz9O2p4BvowBsqkBj0MuZh6pWD2g/kdg7Emjr7zh8cUz9dNk0nWzpvodJqh1/uMEEkjTwyNbj/sBdIhXe07BZeoAoDpB93nkZNx83pbPCrV9lK9eqcjVohMplDseCnOpcWxDNEhkwZI= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1841.namprd11.prod.outlook.com (2603:10b6:404:102::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Thu, 22 Apr 2021 11:44:48 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.4065.023; Thu, 22 Apr 2021 11:44:47 +0000 From: "Wang, Haiyue" To: "Yigit, Ferruh" , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Ajit Khaparde , Somnath Kotur , Hemant Agrawal , Sachin Saxena , "Guo, Jia" , "Daley, John" , Hyong Youb Kim , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , "Xing, Beilei" , "Yang, Qiming" , "Zhang, Qi Z" , Andrew Boyer , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Rasesh Mody" , Devendra Singh Rawat , Andrew Rybchenko , Jiawen Wu , Jian Wang , "Thomas Monjalon" , Selwin Sebastian , Remy Horton , Chunsong Feng , Huisong Li , Hao Chen , "Wei Hu (Xavier)" , "Wu, Jingjing" , "Lu, Wenzhuo" , "Li, Xiaoyun" , "Zhang, AlvinX" , Shannon Nelson , Alfredo Cardigliano , "Vamsi Attunuru" , Yash Sharma , "Ivan Malov" , Andrew Lee CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] drivers/net: fix FW version get Thread-Index: AQHXNspkw0cwnSaF9EiHgQ5WrGJxe6rAagDg Date: Thu, 22 Apr 2021 11:44:47 +0000 Message-ID: References: <20210421162058.1352960-1-ferruh.yigit@intel.com> In-Reply-To: <20210421162058.1352960-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.209] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4cc400c-d8e9-4985-c327-08d905840810 x-ms-traffictypediagnostic: BN6PR11MB1841: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UNw/ysMEDA/qQFCf0DH0SCyCcZAreHHoGuhX4tVx2BeQXhUhVoefH/Qm5s6ygdu2275tl16Ls6Bl86/gwLKzKiVnAYvJ4sxF2YNOJePE+ObnJR8PJHi5FylUWvfd7fXuWWAvw3lD8WWzECtgHkjIvQlR6bKYSL89SOVGd7TjHQH4VnJTAoslVwU1KROlVCvTmZ2BE6chZi8V1vdAbS/jw5X/RfhJ5B9do1nnxGbVhuBNd+g8gYzwH3Z8eU0kwtHcmmpbIxVDQVc5XEavXiFAL+EBTCC7/WB2ldae4BIxEKkdUgsXKgAbF/5aR21Tyb1EmmIRvslzoB0b69cP4GPsUgutODyycw0kO5wqTmoIz2GE/ep9OgiP9OSbTQGdRJo14rYE5RGqVQ41mJZPg2j/ijlCa2fOlO5b90LSqLZpgXixAwLqRRATJmo8EDlSxSdk+rGe0fP6/HMZ6hOqomEN9GyP/f4+y3Q0daC8YY/WfmaRth18avxQrk1A0zjcnnpyJx5NVR4rFfyQt8zHp/WDJAiLB8mn0jpMboDdQxrv9ZeSAID2VAq/r0yyqHbJ188YmbYq0S2OSAytee12G8YBx/FNqs+a7XltUUsCSABO0j+WkaiFnTbLPdL8Y1AO6eBGSZI+jlTmrGtCvIhKwTOLpA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(396003)(136003)(376002)(39860400002)(346002)(83380400001)(2906002)(122000001)(86362001)(38100700002)(7406005)(66446008)(66946007)(76116006)(52536014)(66556008)(64756008)(9686003)(7416002)(66476007)(55016002)(8676002)(71200400001)(478600001)(316002)(1191002)(53546011)(8936002)(186003)(110136005)(26005)(4326008)(33656002)(54906003)(7696005)(6506007)(5660300002)(921005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?jx/L9z9l1DJaTiF3SeBYkQ38PHEqLY+8imSonEV7gWy3TqEl/Z5liI0idemi?= =?us-ascii?Q?IPsL/8Vn7naFR2nv/FTfMiO+OUu+RWdk4F23ASMYYzr0O9nd8Wubqw3T77jR?= =?us-ascii?Q?TU94Q5l1ExHaMnU3JTSMjVYSvm5yVVXS9UXzo/LXCFMCzT8pNXpPJLcDplEo?= =?us-ascii?Q?57Tcyk4nVDJur0IF53DWwT00AzHRqotyX4jlSr4+kwYNBbptqmkQIg7388cd?= =?us-ascii?Q?c9qGaQCT2k2WqdBofq3ArH3niDmq4LdOAHVWT7gtGu2Voe1kg1D3eA6fgwlx?= =?us-ascii?Q?Qnvu1p7EOJg0PS92A0Nu/RtQ7K76nkPcZ7JsOk9qocAb1hLICD2jGxpWgDnH?= =?us-ascii?Q?neE13QGcnliK44Lv77SKkcIWvO8T06kCyUiEDRyVlZzTpSF39Cixmh8DKpHD?= =?us-ascii?Q?5IArVFVuO1NT9RpwOo9mAEom/WmrN35gd6LuR/eQUL/EQaQgPNEF/p6YWNXe?= =?us-ascii?Q?d2qLfQTh+BaaFV8AgrAht8++LiZEA/u4oQurtVv7vRtL6k9lKuPfPn3ohyxJ?= =?us-ascii?Q?J0OnUmnpeBDMTTxCebIB1NESfa26kyCxFWPxCuLYlGiO8nO4FBA6TDofwF8w?= =?us-ascii?Q?sfzb9oUCxpngSzvyZ6kf5PDHZvgrQv6R+Eqj3diw8gNcycphUYMySOEvwu4J?= =?us-ascii?Q?ZVtWaJ4Lx1YSLQDH3fCpGaiCYsUV+pZ+37xeLdwvLmldRVMPTGaaN3f9DCGX?= =?us-ascii?Q?o2829YTb0D53zwzdOhSdiEEx8eULal8m7Th199a8+Sas64JF30+5n0OdngHg?= =?us-ascii?Q?/K7+pR8K+mdugfCTyIbSmTE75DzBLB5tNY37AO7okngoi/JxA0lKaV9L9z0u?= =?us-ascii?Q?F2SL6eYNQiUeUXfKjPa+LI3FlgqW74WeR4hV0N1Svr1Osswg3+WJLD76Mu6c?= =?us-ascii?Q?gZ+axgamd0UaRpnuKEnIizyLl7pdtXqqM4sZ9pwczHu3NzbPn4vEtXJEQY1s?= =?us-ascii?Q?CWQTkT4tnnPA8Gi/OOgTYd1T5bVDG864GsxAaiwYi86gn787N1Q+bG6YNGGP?= =?us-ascii?Q?U5Q8KKuyT5EIhLRS/acRONbSysXtMXj6cTzMwZ8ZaS2+mD1T3GHlwbXO9rxK?= =?us-ascii?Q?huKVT7W7g7a4nhEKxrJaZBWKTWmTsWSsJ8y4/QsT91/vkWx3N85ZTndakO7A?= =?us-ascii?Q?7UEkXUbingJUCa79zvTE0xHAzomPCfet1QlHwN5MLO1V6hd5OBrp5m4OQY4o?= =?us-ascii?Q?2EJxaGIXfl6gDDcKxKRzbUL79/ZHEK52ypwFcCxhrkI1+tmg3Sem29WZDb+O?= =?us-ascii?Q?XeB8eVEFLFvE7jCCjPCwkDMwJQQlo/9HnDkmAvVCxiGqBb4jWdx17fVY3I65?= =?us-ascii?Q?nTTCPiBcNCfWXQAryWKJ2wWO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4cc400c-d8e9-4985-c327-08d905840810 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2021 11:44:47.5366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m17DU6Doufvn3wxBdTquIYHE624UCRe2bjpzh0ugSKIU6rEruJEtiq8hax91FZqkmY3/opp+Efe4f3FloXC5RQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1841 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] drivers/net: fix FW version get X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, April 22, 2021 00:21 > To: Igor Russkikh ; Pavel Belous ; Somalapuram > Amaranath ; Ajit Khaparde ;= Somnath Kotur > ; Hemant Agrawal ; Sa= chin Saxena > ; Guo, Jia ; Wang, Haiyue <= haiyue.wang@intel.com>; Daley, > John ; Hyong Youb Kim ; Min Hu (Co= nnor) ; > Yisen Zhuang ; Lijun Ou ; Xi= ng, Beilei > ; Yang, Qiming ; Zhang, Qi = Z ; > Andrew Boyer ; Jerin Jacob ; Nith= in Dabilpuram > ; Kiran Kumar K ; Rases= h Mody ; > Devendra Singh Rawat ; Andrew Rybchenko ; > Jiawen Wu ; Jian Wang ;= Thomas Monjalon > ; Selwin Sebastian ; Remy = Horton > ; Chunsong Feng ; Huisong= Li ; > Hao Chen ; Wei Hu (Xavier) ; Wu, Jingjing > ; Lu, Wenzhuo ; Li, Xiaoyun = ; Zhang, > AlvinX ; Shannon Nelson ; Al= fredo Cardigliano > ; Vamsi Attunuru ; Yash Shar= ma ; > Ivan Malov ; Andrew Lee > Cc: Yigit, Ferruh ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] drivers/net: fix FW version get >=20 > Fixes a few different things: > * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is > zero, 'fw_version' being NULL but 'fw_size' not zero condition checked > in ethdev layer > * Be sure required buffer size is returned if provided one is not big > enough, instead of returning success (0) > * Document in doxygen comment the '-EINVAL' is a valid return type > * Take into account that 'snprintf' can return negative value > * Cast length to 'size_t' to compare it with 'fw_size' >=20 > Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop") > Fixes: ff70acdf4299 ("net/axgbe: support reading FW version") > Fixes: e2652b0a20a0 ("net/bnxt: support get FW version") > Fixes: cf0fab1d2ca5 ("net/dpaa: support firmware version get API") > Fixes: 748eccb97cdc ("net/dpaa2: add support for firmware version get") > Fixes: b883c0644a24 ("net/e1000: add firmware version get") > Fixes: 293430677e9c ("net/enic: add handler to return firmware version") > Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") > Fixes: bd5b86732bc7 ("net/hns3: modify format for firmware version") > Fixes: ed0dfdd0e976 ("net/i40e: add firmware version get") > Fixes: e31cb9a36298 ("net/ice: support FW version getting") > Fixes: 4f09bc55ac3d ("net/igc: implement device base operations") > Fixes: eec10fb0ce6b ("net/ionic: support FW version") > Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") > Fixes: 4d9f5b8adc02 ("net/octeontx2: add FW version get operation") > Fixes: f97b56f9f12e ("net/qede: support FW version query") > Fixes: 83fef46a22b2 ("net/sfc: add callback to retrieve FW version") > Fixes: bc84ac0fadef ("net/txgbe: support getting FW version") > Fixes: 21913471202f ("ethdev: add firmware version get") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: pavel.belous@aquantia.com > Cc: selwin.sebastian@amd.com > Cc: hemant.agrawal@nxp.com > Cc: qiming.yang@intel.com > Cc: hyonkim@cisco.com > Cc: xavier.huwei@huawei.com > Cc: wenzhuo.lu@intel.com > Cc: alvinx.zhang@intel.com > Cc: cardigliano@ntop.org > Cc: vattunuru@marvell.com > Cc: rmody@marvell.com > Cc: ivan.malov@oktetlabs.ru > Cc: jiawenwu@trustnetic.com > --- > drivers/net/atlantic/atl_ethdev.c | 7 ++++--- > drivers/net/axgbe/axgbe_rxtx.c | 4 ---- > drivers/net/bnxt/bnxt_ethdev.c | 4 +++- > drivers/net/dpaa/dpaa_ethdev.c | 6 ++++-- > drivers/net/dpaa2/dpaa2_ethdev.c | 4 +++- > drivers/net/e1000/igb_ethdev.c | 4 +++- > drivers/net/enic/enic_ethdev.c | 15 ++++++++++----- > drivers/net/hns3/hns3_ethdev.c | 5 ++++- > drivers/net/hns3/hns3_ethdev_vf.c | 5 ++++- > drivers/net/i40e/i40e_ethdev.c | 4 +++- > drivers/net/ice/ice_ethdev.c | 4 +++- > drivers/net/igc/igc_ethdev.c | 4 +++- > drivers/net/ionic/ionic_ethdev.c | 15 +++++++++------ > drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++- > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > drivers/net/qede/qede_ethdev.c | 3 --- > drivers/net/sfc/sfc_ethdev.c | 8 -------- > drivers/net/txgbe/txgbe_ethdev.c | 4 +++- > lib/librte_ethdev/rte_ethdev.h | 1 + > 19 files changed, 61 insertions(+), 42 deletions(-) >=20 For e1000/igc/ixgbe Acked-by: Haiyue Wang > -- > 2.30.2