From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 617FEA0547 for ; Mon, 21 Jun 2021 10:35:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53E6641163; Mon, 21 Jun 2021 10:35:06 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C200D41163; Mon, 21 Jun 2021 10:35:03 +0200 (CEST) IronPort-SDR: 0CZIZeDe1A1Al4mJyjbYc1ZzxVUd+ERStSiYQgwc0+Jf3HEvHvt5HGlAe4IrUs//6Xz2mddthj 5BFGWEGME9Tw== X-IronPort-AV: E=McAfee;i="6200,9189,10021"; a="228345206" X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="228345206" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2021 01:35:02 -0700 IronPort-SDR: G5ovf5OGmH0+apuuswid2OjT29GwU5EBcziTiZaGGbe8ndm33YEMaWtdiJiO2km4HYj1TUTAMh STI7+aKo4+HQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="480398817" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jun 2021 01:35:02 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 01:35:02 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 01:35:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 21 Jun 2021 01:35:01 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 21 Jun 2021 01:35:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SusqTY0HXQ6w36WQCWCitE8EzBRWfzOU/zZQT0BGpIhv+vnkR5G21BQSmweUc6KVX9kts5gIbH4fwic+IL1keZpcymoY4hY59z2nYztu8eKLZ+QBh/t4aombhzwNxs2rByu1zn3X0v33cDOva3IXtNv6G8hRAhZw4omIToelYwqxUyZQzyUgDF9oR5lFMaju28s16/uPdE3TOGiOPkd1EXPntMv1MX/XIQPzI2L2jF5EvwfZr80UobqrT87VzNMn62aGitB+0/dnRjLIMr6AymQ0fMZYR7aTMBCeJqNlhhsrub+DF6tL8hIXFky9sG9rilBCS6aAFzKmh4P8dtYlQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=juv09cXwxDAML/mys+5Od5qgqTfLtA95S1w2JqstVjA=; b=nvz/qsv39bZxaOfcCVTAS/wwKvkVRPP6Vy0xAtirKNV8b1SjYjgLTrNFyVAV603RRtW7tSL0HmuGX7r5QQV/Q/6PKKZ+GrAWfkOEjN02isCjAr4mWXcrLV1Qx2ak727tRGtx6Dwc0FndAQghAHJV0dK6kqzFnlOr9JYKSQe66RYYkH0ndqDqWGw9GzO9G7c8fK9vlDuPwb9i6QMlfhn+33WKD1fmWAZS1uGGoHAzrlcvlkGFmJmaC3qBap5jUHYqqC2nV5YGJrpeA9qFqm82jWr2cso2dl7DLukkHwnDnksCUXZY09LGTmgcjermHh3D9L3Can9uz1oP5el5kkWRSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=juv09cXwxDAML/mys+5Od5qgqTfLtA95S1w2JqstVjA=; b=GLPscqxvAb4XR0JDlXZbtOEWA1JSk3dnXPscETSUATyCbrGm1FtQ2x1acW/xTNTzb90aXLF5DuFR/hOEig0pZ5GAQSVunazlfjslztBNlKzOPl8B6W6AhPK7cEet8cpb3jDM1yoRbj7luzDE+srsGLP1Vy1LEnDOJuM4QUqQWKQ= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1411.namprd11.prod.outlook.com (2603:10b6:404:3c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.22; Mon, 21 Jun 2021 08:34:57 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::8807:6661:e425:102]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::8807:6661:e425:102%7]) with mapi id 15.20.4242.023; Mon, 21 Jun 2021 08:34:57 +0000 From: "Wang, Haiyue" To: Thomas Monjalon , Kevin Traynor , "Xueming(Steven) Li" , "Luca Boccassi" , "christian.ehrhardt@canonical.com" CC: "stable@dpdk.org" , "Zhang, Qi Z" , "Fu, Qi" , "techboard@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD Thread-Index: AQHXXpSS89wjvKD9LEWA6ZaxGO5s7KsW0J2AgACbVsCAAINEAIAAFAQAgAEPWaCABR8kgIAAAIrQ Date: Mon, 21 Jun 2021 08:34:57 +0000 Message-ID: References: <20210611065825.47678-1-haiyue.wang@intel.com> <30bf553b-032c-d992-487f-794cbe1816fe@redhat.com> <10618347.Fq3sR6fjhQ@thomas> In-Reply-To: <10618347.Fq3sR6fjhQ@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3b108a4c-9ef4-4035-1a51-08d9348f73bc x-ms-traffictypediagnostic: BN6PR11MB1411: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3kCfs8IGO03tJdja436W0Ab7LI4Mtt+jrIjKbSPcbB6fxZZJSaKJc4sNysoCjVgcmZ5JqDqxlgXYodxjp1yHszGQUjmDjx34Y7fzqoVnEdEaVkri5f2lkKpqUBcGWtKkGfwZLJz2YIE7grr+kfBulZ9vPihSlUrBWw5cWpMgNda68KN/a1aOvjJEBoH11FsFSFjNkl7qA+Zq3dQi27zus/t/cDBcgFAPNmpjJ0HFsKjk6ShspI1exe7f2fPIFt2ip68wN48sONavBLTf8YTKYlVCIR8C08PPJgUsnHvn2kV5AxWj5O1YMCZes4LF0igYZlMBtPRpXnoCtFoSyGAxsfguBmUCKn28qgDsrDws8eLAiVXaijoOO4p+yQQEbTwyaAXlKVU9gQOZSJ/rjHzp8ouP6cqaGUVJC7RkD/2QLTswg2wxH7pqZeohohIGxG1ftlIM2VoVoqFcokGTpNezbWfEH/oxLPGkJdMZMwDaXGWW45PdJg990s2JSR8ZEPSH1fDz33URNEh3pg1S4yvHmwl10nXv8NtOc7tY2ANv7CsqfWdxEnWx0T7Mlsd3OxAtk86Ls6ApnvcwxWSWNgZRLoNQuIfAYDuNUilNWLu6gng= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(366004)(39860400002)(346002)(376002)(136003)(9686003)(66446008)(64756008)(66556008)(66476007)(186003)(122000001)(26005)(76116006)(2906002)(66946007)(38100700002)(33656002)(316002)(7696005)(8936002)(4326008)(54906003)(83380400001)(110136005)(52536014)(6506007)(53546011)(86362001)(8676002)(478600001)(55016002)(5660300002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ByK16lv8qVs45ySN6A682OoHOhNfrMW8aAgZvf99ZVqm0OUmNMB9iZNMc1uF?= =?us-ascii?Q?laKySLjFydnsgNXJxsQjih6FIXv57ZLl7V5NQbyUQvw9wTgkkWFj1Cz7R/Ac?= =?us-ascii?Q?JMzHBIAnO4d8VgypjKHmuboOgHNyYi2E3WPzav0cKpWKJnQjKyoRv3/CoNtY?= =?us-ascii?Q?aynMW53wH/ZGfLxlWpePkqQwwZZ43elxuySqCxswv8WPPWNRmIPbdEa7qRV8?= =?us-ascii?Q?u/EDOT5Vm3GJkzx1J8JzGqwXtl8X0OfPNz0jr/cipiD2clz2d1TW9zd4AJn7?= =?us-ascii?Q?YJcsPXEC8WxCzeQQpaKjOLVbfgLGvl57ZWiXBvQEOs5RkeRhKFbFOOmfTufI?= =?us-ascii?Q?jzc+wannCf/VDEHZN0kQWd+vqnrnOhWbyN/WKWof0K2BwxnMjCCuMcPCQH7U?= =?us-ascii?Q?c2NQExCVpk2qAjMG+e2OSvzqmdQw7AONozS3FmXZwbrTuLADw+a6txVgsM38?= =?us-ascii?Q?su3VDZ7kbfcWh4DNipb/Uxb3yJC0iY9RC6CYDxLpI2OFzK1UoazjMguUpTM8?= =?us-ascii?Q?2SaEHUpq73fUdSEmQa+i2W4o48Ug6QYO8TYMUttbEDqcHDqrPnYncr9UE+so?= =?us-ascii?Q?Sq9nJ7leak2txJS3DkG6xL5qBDpDLAWKnvFokrK8LAxg/PvnB9yImHmWCSc3?= =?us-ascii?Q?9FD09pU33p8miNGUfWizbbJbCaFiFEvhX8ZOqaLVoGiTKKx62K9MBNPacTSd?= =?us-ascii?Q?RSRuCyqAzENGD3gRuUr6DNa5YH/2P1+bNqYjMB+jn17SzwE+4aPUbzbqX6lT?= =?us-ascii?Q?NJgUTAP/XHHoeMfxhqpSWSuqaLcnVumyQiLeD0BzHOmI6x55+aZr5WVk7kIr?= =?us-ascii?Q?SnoLQYcRH07D8POQqNCXWIwzri8TgPbZuJRMF6o5f6e8a1jkMlQJHeF59Y9Q?= =?us-ascii?Q?Zx+Hv3lrQBwEZ1gjw2aunZ9bs7+ejrvTcxK6oo3J2D0DEW3+5WFUzLO8PNYU?= =?us-ascii?Q?WdPNjcYd1CbXaeA+8840J4NwDGjH67BQgPwb8dI/fpFZpKFxXN0ZI+MUuSyf?= =?us-ascii?Q?qguFVMDSV2zCPvzmhhaqFRAnWks8FAS64jAsvA9Vrl655XZwiv0FpwW+dqGV?= =?us-ascii?Q?GO9akolOEAtbwUCUfDX0yqH32QXAwrwlio7j0O58dDnvnFkB7aFfSUGTLhio?= =?us-ascii?Q?+8tpiQpcZtwEIGK0pF5e5h58i8UnF5aTcgKuQmLqDg7g0KBgvvyVlYYW9V20?= =?us-ascii?Q?o1KgVMSLhF30POW+//65mPgjgZeCtpbsAoWD46sqlX4MBWLP2rnlCyUYDmAY?= =?us-ascii?Q?yG86+1l3gK0IR6zJMumHpuLK0Pm5HeuRACZiRX/eo8WpEjGcoATPaoj+GED3?= =?us-ascii?Q?qy0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b108a4c-9ef4-4035-1a51-08d9348f73bc X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2021 08:34:57.1143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y23umE+CK7b4UDzrtsv1rGcchAg1oMCiu4ADW4axlUO8+JMLF1s/RbWmwgCWFudrWUzRCqSK8NKaFSkWwspY4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1411 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, June 21, 2021 16:29 > To: Kevin Traynor ; Xueming(Steven) Li ; Luca Boccassi > ; Wang, Haiyue ; christian.ehrha= rdt@canonical.com > Cc: stable@dpdk.org; Zhang, Qi Z ; Fu, Qi ; techboard@dpdk.org > Subject: Re: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN d= esign for Intel ice PMD >=20 > 18/06/2021 05:22, Wang, Haiyue: > > From: Kevin Traynor > > > On 17/06/2021 09:53, Xueming(Steven) Li wrote: > > > > From: Wang, Haiyue > > > >> From: Luca Boccassi > > > >>> On Fri, 2021-06-11 at 15:15 +0800, Haiyue Wang wrote: > > > >>>> When LTS 20.11 was released, the Intel ice PMD has a basic VLAN > > > >>>> offload, which can only handle single VLAN mode for firmware > > > >>>> limitation. Now the firmware is updated to support double VLAN m= ode > > > >>>> and single VLAN mode at the same time. > > > >>>> It depends on the driver to do selection at the boot time. > > > >>>> > > > >>>> As VLAN protocol handling like strip, filter, flow is very commo= n > > > >>>> use, we request to support the ice PMD can run on the latest > > > >>>> firmware for enabling the new design. This is compatible backpor= t as the main tree. > [...] > > > >>>> 19 files changed, 1545 insertions(+), 363 deletions(-) create = mode > [...] > > > >>> At 1.9k diffstat, this series is quite large. Given it's a new > > > >>> feature, rather than a series of bug fixes, this would seem a bit= risky to me. > > > >>> Final word of course belongs to Xueming, since he's managing this= one. >=20 > [...] > > > >> 06. Is it obvious that the feature will not impact existing functi= onality? > > > >> > > > >> Yes. > > > > > > No. It is 1.9KLOC change. The key part of the question is "obvious". = It > > > was meant so the maintainer could use their judgement and review that > > > for example, a few lines of code adding a PCI ID or adding a case in = a > > > switch statement, is obviously not going to impact existing functiona= lity. > > > On the other hand, for a more complex code change to existing code, i= t > > > is not immediately obvious that there would be no risk to existing > > > functionality. >=20 > [...] > > > >> 11. Is there a community consensus about the backport? > > > >> > > > >> ... > > > > > > > > Kevin happens to updated the documents on new feature backport 4 mo= nths ago, thanks for checking > > > them > > > > one by one. Luca's only concern is size of the series, driver vendo= r is on it's own risk to > backport > > > a big patch set. > > > > The series supports new fw and QinQ, is it easy to split? > > > > > > > > Kevin, is this the first case of feature backport? How do you think= ? > > > > > > > > > > Like Luca, main concern would be the size and intrusiveness of the > > > changes, and if it's ok to change 1.9KLOC in this driver now, then wh= y > > > not 20KLOC in next release to multiple drivers. I had pushed against = a > > > > TBH, we won't want to change the stable i40e, ixgbe PMDs, but ice is a = fresh > > one, current VLAN has a limited usage, customer is hard to use. That's = why we > > try to request to backport the new VLAN design. >=20 > Yes ice is quite recent. > If a required feature is not working, it should motivate to upgrade. > Because ice is "fresh", I don't understand why sticking to 20.11. > My concern is that backporting this big feature would create a precedent, > so all users will require to stick on the last LTS when getting > all the new reworked features. "Performance improvements are generally not considered to be fixes, but may= be considered in some cases where: It is fixing a performance regression that occurred previously. An existing feature in LTS is not usable as intended without it." I think "An existing feature in LTS is not usable as intended without it " = can be one reason, since the old design is out of date in two year of LTS lifet= ime. > I think it would be a bad situation for all of us. >=20 >=20