From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BB6FA0351 for ; Fri, 15 May 2020 04:46:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EEB831D9E0; Fri, 15 May 2020 04:46:49 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 059E81D9C8; Fri, 15 May 2020 04:46:45 +0200 (CEST) IronPort-SDR: eGxs4B5tLJtsBH2/hX6FsCsIdG6atob3ipQ2rW7rnr9OH8uGcQGDReIrpRTJANkNhgubnaYwIs FZjr1f21Ur8A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 19:46:44 -0700 IronPort-SDR: /RMbCVN5jCBWHrLfzRaXIy8d6lgbRQyQq1H9wCwgidqc7CyPVvEULNGYHPVxI97yXZyyn5bM2c iG+8iw/b3/kw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,393,1583222400"; d="scan'208";a="263049458" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga003.jf.intel.com with ESMTP; 14 May 2020 19:46:44 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 19:46:44 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 19:46:43 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 19:46:43 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.51) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 19:46:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EkDIDLEqdnqvSI5sDdAg58pIVHP1iaVpa6dATQMxj/bmlx6TQplchd0NeqxY68jvLpiDEDxZgOLEiRn84gDSAp1ROGeldOhWSEH8NdL1WFiBFPmZpe5ygMW4B4IWBwxgEe1QRGQ1ZoLPiy+iKfX6/gj1DZO1DqNnGq3dIILckO5BJsH0Bn/bP+6pD69mn/LNCjHTaDIglxronJqkR0Tx+GYeDmNPhHbY9kLTiX5jpx33EkerYH3WEwrZWdUywutuG/hI+9MIrbZnySU/VbOVxU0KozR7mq6vpsOVf2y49TYapETj3bNBLc80CcQPZ1vk/C+EGFMCH+4oAluj4w58GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XMxasNgN0O0+3g/h4XH6x+4C8Zhhu8/aavWqIJmP6RM=; b=jW12RwWpDLnjiO9EUVgvqb+WQY7JwZt531TizmV/kPFkaTsKFYHE4MG1BuXdjeWMOtC5qwtD4cjRN4usDcahX4pae1FBTJ1FFgrCJoDqiYsJpDn97/aSyS3f3Cpa5SHItGvxwIcgL6TY+dSf0epaBg3qzcJRNXNyjNyer9wvm8oSE3UmIEgS8dnyulktD0HMIJIV4oGAY1o6c1Gq3Uk8Aeezljl0ADHnKVjXR/sfoi5+2PnT///Er/lNwz/TDSnnsl7t4a7h/Mk28N3pzjetvVHduDdoVDn96St6TKaKt7h27UptxVfRylx/rm7TQxvUUzt4rMUsyolcHusac4xxqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XMxasNgN0O0+3g/h4XH6x+4C8Zhhu8/aavWqIJmP6RM=; b=Yq3MPcJE7ne08YNGmdQYajCd+7ySp+xcmcPniCSGszynfkYsFIzVK9yOs6QWMRvR2qrfzJNbf65QdVhqaf2slCyk7CFzOeWQgu+8yHH7yOv3rkzs+S0qkPmVJnccuSjlnKxJWJqReb8NCeO6OO7Z7u/yPYxLA+axK2qs0v843ZA= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN8PR11MB3604.namprd11.prod.outlook.com (2603:10b6:408:83::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24; Fri, 15 May 2020 02:46:39 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::c96e:e522:e0dc:490c]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::c96e:e522:e0dc:490c%7]) with mapi id 15.20.3000.022; Fri, 15 May 2020 02:46:39 +0000 From: "Wang, Xiao W" To: "Liu, Yong" , "maxime.coquelin@redhat.com" , "Ye, Xiaolong" , "Wang, Zhihong" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/virtio: fix unexpected event after reconnect Thread-Index: AQHWKmGrFZpz/CuBMkeJYOtoEetqiaiocRKQ Date: Fri, 15 May 2020 02:46:39 +0000 Message-ID: References: <20200515014056.44949-1-yong.liu@intel.com> <20200515023507.46543-1-yong.liu@intel.com> In-Reply-To: <20200515023507.46543-1-yong.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50eb7e73-1e90-459a-d4c3-08d7f87a3174 x-ms-traffictypediagnostic: BN8PR11MB3604: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:46; x-forefront-prvs: 04041A2886 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xb7dAfv7ZcxBncC2mnUahyWvEeqPEaQfMelLK4boWCF1Im5ieFiOZvIXAJaefA7Pig62AZqc3qWuKhhYvl2EKoOIXJ60rfIZBqyAFKGlcDez0HmywG+op0dGQ9etpRk3/bT0Dp5GKn8YmZmwM12ZtIrTFK1ADVYLIJkv583lX6IcAGdUjspE6yOM+fTZKSDJIiIuWdcdhE4LwqVzp2gSZeCHrmjYdxlS19I+b38gIsnkH+/sWOcdtUhiEgvWr85poaeyNkyQE/uuxZiiwy4Rh9CWt3qJQJKifqefYfvt4/mBQSWUvOeDxrtrnU9iFNib/YeGC0ODWMonXDNkUocz4bnOpBgoVRlkN4QoThD2dLHltiPJWj+Xxj0dvEpvExIeAj1wpQafZU4HPzR5nZwHZhxY0BDA/dQQ9T0lXmG/6kbEmnSvfXlR3qvnES0yXy63 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(39860400002)(346002)(136003)(396003)(376002)(186003)(26005)(52536014)(6506007)(55016002)(54906003)(6636002)(7696005)(9686003)(53546011)(71200400001)(4326008)(110136005)(8936002)(76116006)(66446008)(64756008)(33656002)(86362001)(5660300002)(66556008)(66946007)(2906002)(478600001)(8676002)(316002)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: qc13/1Ymxcttd/duzFTNMyX4hfE34NETlhPy3yylmDA3kG3H20LboVlwci6EmkrwTZ+1Pg7RlbADy2Di8zem9qQ3CdtTyfKXySxj5JpBN6yqztEV6R5utXaaAYwq5BMp5MbVEQvS+Ik7YCkM/jkvz1Hzo1M4Gr0e5Ljz+iqOPvxbFwxrUY3JBv6ZICYrE5P2G7T/Vb6M/8wqOT3E1gng3waYGhQSWWLeZeqnq3a3iF7Gz94MeMxXkYBvHOkM/JoOEmoFhYC6qHw5rvmUHAzbHI9oq+6CkKNE6N34KFmOF5Cf6vemVMGzqXnsJgqzBMFZyKDHXkrnxYpm7vxqoZ0SvGDXRNNXfJ9Fy55Xk5mgyJfbV414uepKJ+62GE977RhUibfqXdYGn8pKo9RYqjsUbq8g+cbfNI57C0o9DdwDqMWO0H44LDUa/JniTmGuh6Oj7GSkxiBDt3m2yNOYxTMo9YXyhTVUvJfbKozXDRuf33tvGpE2T24UV129dKJkJCKu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 50eb7e73-1e90-459a-d4c3-08d7f87a3174 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2020 02:46:39.2804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shohNbAuQwwNjkorNjkz/vjVpjihKriIPHT412r687JviWTVbrDD7jQFu0IH+1ncVo3f7+pAGxdoaO/anus7/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3604 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v2] net/virtio: fix unexpected event after reconnect X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Best Regards, Xiao > -----Original Message----- > From: Liu, Yong > Sent: Friday, May 15, 2020 10:35 AM > To: maxime.coquelin@redhat.com; Ye, Xiaolong ; > Wang, Zhihong ; Wang, Xiao W > > Cc: dev@dpdk.org; Liu, Yong ; stable@dpdk.org > Subject: [PATCH v2] net/virtio: fix unexpected event after reconnect >=20 > Event notification should be disabled after virtqueue initialization and > enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user > device reconnecting to vhost, virtqueue_disable_intr should be called to > disable event notification. >=20 > Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode") > Cc: stable@dpdk.org >=20 > Signed-off-by: Marvin Liu > --- > v2: commit log update and cc stable >=20 > diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueu= e.c > index 0b4e3bf3e..02c8b9fc5 100644 > --- a/drivers/net/virtio/virtqueue.c > +++ b/drivers/net/virtio/virtqueue.c > @@ -174,6 +174,7 @@ virtqueue_rxvq_reset_packed(struct virtqueue *vq) >=20 > vring_desc_init_packed(vq, size); >=20 > + virtqueue_disable_intr(vq); > return 0; > } >=20 > @@ -210,5 +211,6 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq) >=20 > vring_desc_init_packed(vq, size); >=20 > + virtqueue_disable_intr(vq); > return 0; > } > -- > 2.17.1 Acked-by: Xiao Wang