From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 256F1A00BE for ; Thu, 31 Oct 2019 22:52:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D45B1D410; Thu, 31 Oct 2019 22:52:45 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 510751D17D; Thu, 31 Oct 2019 22:52:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 14:52:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,253,1569308400"; d="scan'208";a="284024327" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 31 Oct 2019 14:52:40 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 31 Oct 2019 14:52:39 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.57) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 31 Oct 2019 14:52:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QPSI6icGmlshPUrWHy5Gax+igoYGxhQ59T0nxOmWPOG1NPSVOsOMi9uP4oDdeESr2n3MStbR2npiMV51AtYxidxRqWJFNZdJjL52VRWv6Fjys/Dov11i5K37hh9hUG4axF+Sg6xHXMnbC86Qah5VZN0V7NayYvc/10SA7lAQBAI7zZrByqg+QC8kWdbD7X392pFzbw186/eKV1LNrrvx4zgwVVto503Oyp5B8x4v229txX+bXQdgnj7f//hcfimze3JypT5yXoZfmajUyw0g17Y1RwviebbPwQEkb2Ad2jf6jaqcIOkD/yxczoDeMXN7ijIFmaPFgLmA05MM8IOI5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4V+L2gx4kruRQsM7wftn4LPEa3rZkcShlFlmHZJDHLw=; b=LZoYpDQZulXXwzBVg1qFjzBsDe7RdCjWH23k0MdPg3fmDY0eklAsEiOaxi1OfUFnW5855whPPyMNmvmu/OLu4IY1Mos8nh6JzL1/7jUt7J4+60ZTKmNLb5LXgVq466yDU/fnlT8GwNxhuBQXRr0/r+Sh2qpIguESNTgzigeYmOrC7HudwJgnuzPhX0xSAue20BxN8fh/g/NcL944gwftXjV6GxHFgdAwWYSJMeROAjlNkFphQgnYzTbR855p/hUxeI55f/gdC0CIEZAKfXBurdXuFSk0YkcnvmTZTFmKYbpQmAJAunT8Pa0Twhmg9w5Z8n+1aQJhc2SBA2QfPzqhKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4V+L2gx4kruRQsM7wftn4LPEa3rZkcShlFlmHZJDHLw=; b=EZljKdCHaq2vxf6EQvK0llf+Lw7VR86OKjhjGruiFk2qPb4Dvi6kQiV6fmzKWEhnBrIksykzw3ZQh79aQBEs+RgYiGkflOqLgvwzrDqRMA0B5/rL0q0PoftMwTwu8nFVhxYiEWDrTqTUvq6nji7rFoF+3G+0neWozYL69tTZLKI= Received: from BN8PR11MB3828.namprd11.prod.outlook.com (20.178.220.87) by BN8PR11MB3668.namprd11.prod.outlook.com (20.178.218.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20; Thu, 31 Oct 2019 21:52:38 +0000 Received: from BN8PR11MB3828.namprd11.prod.outlook.com ([fe80::7417:db34:276c:2b57]) by BN8PR11MB3828.namprd11.prod.outlook.com ([fe80::7417:db34:276c:2b57%5]) with mapi id 15.20.2387.028; Thu, 31 Oct 2019 21:52:38 +0000 From: "Stillwell Jr, Paul M" To: "Ye, Xiaolong" , "Zhang, Qi Z" CC: "Yang, Qiming" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ice: fix unexpected link down Thread-Index: AQHVjhe3w0/F3A0NEUSguBo/H1nZj6dxjmQAgAO/MWA= Date: Thu, 31 Oct 2019 21:52:38 +0000 Message-ID: References: <20191029051649.25253-1-qi.z.zhang@intel.com> <20191029053504.GF12923@intel.com> In-Reply-To: <20191029053504.GF12923@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWM3MGMxOTMtYmE2OC00YzVhLTgyYTYtYzVlZmM2MjYxYjFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieEU0U2NRMGd4OTBUTTNEbDNDVTVrOFhQR2FJRkFCWGF2ZzNuVGFPK1pMZGU4YStmbmluWkkrTWJDcUdvbEtDSyJ9 dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=paul.m.stillwell.jr@intel.com; x-originating-ip: [192.55.52.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 365440c6-e1dc-4691-376c-08d75e4ca57a x-ms-traffictypediagnostic: BN8PR11MB3668: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 02070414A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(376002)(39860400002)(136003)(346002)(366004)(13464003)(199004)(189003)(25786009)(486006)(476003)(64756008)(3846002)(66446008)(66946007)(66556008)(446003)(99286004)(7696005)(66476007)(6116002)(11346002)(71200400001)(76116006)(81166006)(8936002)(81156014)(14454004)(76176011)(186003)(6506007)(102836004)(26005)(53546011)(8676002)(6246003)(66066001)(2906002)(86362001)(478600001)(9686003)(316002)(71190400001)(7736002)(55016002)(450100002)(52536014)(5660300002)(4326008)(74316002)(256004)(305945005)(6436002)(54906003)(110136005)(6636002)(33656002)(229853002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN8PR11MB3668; H:BN8PR11MB3828.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Bbj1YPPS0LiAZ2YydUqyVczsOIdqqENZKitvHcb99ig6UplShkumOaBerimaKNxeU9ZbaZza6TsRzgAfO5eO45c0EgJfkiOiCyis1XC82fsfsUJQYHXTdDVFOWkTbTfidbmOnjcPfw2o7TPgPz85M7AHrN1xv75ZquaA05UMwXY75SLdzT/hH1s4R+iEAfRI7puMBV6jbGnexqvAY2rdHDkBOg07928piQ7dZ+PULcTBQNWviuH0Jvde1TUfqx7G6mBf7/VCpc5CTJ5gGxkFe3GPpwyxUcgw4kVf6zooFL/pFQQWO2GtCU+vYbthBTohI6gEdZEsYSsKPQ4Otfa+KSFScDoHftANJgCdaX6hRYlmd6X6MVKGGEFUXKwZ3YB11D/6sf9RxFH1zOgxN3eL8uoAzVWXXZkX2+ey+Vk5tQZF27JcYkDDRdaDObzq3Ozu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 365440c6-e1dc-4691-376c-08d75e4ca57a X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 21:52:38.1041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RmFv6uCUA5z+Rb08Hb58MucI94WUaOOHBm9Rp8yhn7S8JUYZIjBIppYQ8mzkCNWuEuUu3Z/lhRmlK6aeC7GvSp32wVwwOEcWrpIPrtCI88g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3668 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice: fix unexpected link down X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Xiaolong, > -----Original Message----- > From: dev On Behalf Of Ye Xiaolong > Sent: Monday, October 28, 2019 10:35 PM > To: Zhang, Qi Z > Cc: Yang, Qiming ; dev@dpdk.org; > stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: fix unexpected link down >=20 > Hi, Qi >=20 > On 10/29, Qi Zhang wrote: > >Not to turn down link during dev_stop, it will cause the device can't > >be bind by kernel driver after DPDK driver quit. > > > >Fixes: e6161345d8a9 ("net/ice: support link status change") > >Cc: stable@dpdk.org > > > >Signed-off-by: Qi Zhang > >--- > > drivers/net/ice/ice_ethdev.c | 2 -- > > 1 file changed, 2 deletions(-) > > > >diff --git a/drivers/net/ice/ice_ethdev.c > >b/drivers/net/ice/ice_ethdev.c index d74675842..ae6eba63e 100644 > >--- a/drivers/net/ice/ice_ethdev.c > >+++ b/drivers/net/ice/ice_ethdev.c > >@@ -2277,8 +2277,6 @@ ice_dev_stop(struct rte_eth_dev *dev) > > /* Clear all queues and release mbufs */ > > ice_clear_queues(dev); > > > >- ice_dev_set_link_down(dev); > >- >=20 > Is this ice specific issue? Calling set_link_down seems correct thing to = do in > stop ops, as we can see in other PMDs like i40e, mvneta, ... >=20 Technically, this issue also existed in i40e. The i40e kernel driver added = a workaround to fix this when the DPDK driver would force the link down whe= n it closed. The FW handles the link status and the driver shouldn't mess w= ith it unless the user indicates they want it in some other state. I think = the best idea is to return the link state into whatever the link state was = when DPDK started (probably up) instead of setting it to down when the PMD = exits. > Thanks, > Xiaolong >=20 >=20 > > /* Clean datapath event and queue/vec mapping */ > > rte_intr_efd_disable(intr_handle); > > if (intr_handle->intr_vec) { > >-- > >2.13.6 > >