From: Long Li <longli@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Long Li <longli@linuxonhyperv.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command
Date: Fri, 11 Dec 2020 20:05:24 +0000 [thread overview]
Message-ID: <BN8PR21MB11553B8F433E412618003C11CECA1@BN8PR21MB1155.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20201211092136.4de4e248@hermes.local>
> Subject: Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE
> while executing a sync command
>
> On Thu, 10 Dec 2020 23:52:44 -0800
> Long Li <longli@linuxonhyperv.com> wrote:
>
> > From: Long Li <longli@microsoft.com>
> >
> > On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE
> > packet while executing a VSP command synchronously.
> >
> > Ignore this packet as we don't use it for DPDK.
> >
> > Cc: stable@dpdk.org
> > Signed-off-by: Long Li <longli@microsoft.com>
> > ---
> > drivers/net/netvsc/hn_nvs.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c
> > index a0ee7d8bfa..b6aa07cc5f 100644
> > --- a/drivers/net/netvsc/hn_nvs.c
> > +++ b/drivers/net/netvsc/hn_nvs.c
> > @@ -97,8 +97,13 @@ __hn_nvs_execute(struct hn_data *hv,
> > hdr = (struct hn_nvs_hdr *)buffer;
> >
> > /* Silently drop received packets while waiting for response */
> > - if (hdr->type == NVS_TYPE_RNDIS) {
> > + switch (hdr->type) {
> > + case NVS_TYPE_RNDIS:
> > hn_nvs_ack_rxbuf(chan, xactid);
> > + /* fallthrough */
> > +
> > + case NVS_TYPE_TXTBL_NOTE:
> > + PMD_DRV_LOG(NOTICE, "discard packet type %x", hdr-
> >type);
> > goto retry;
> > }
> >
>
> Could you change that log message to DEBUG (or INFO) level?
> Users probably don't need to see it.
Sure, I'm sending a v2.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
prev parent reply other threads:[~2020-12-11 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 7:52 [dpdk-stable] " Long Li
2020-12-11 17:21 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2020-12-11 20:05 ` Long Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR21MB11553B8F433E412618003C11CECA1@BN8PR21MB1155.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=dev@dpdk.org \
--cc=longli@linuxonhyperv.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).